[INFO] fetching crate slatedb 0.1.3... [INFO] checking slatedb-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate slatedb 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate slatedb 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate slatedb 0.1.3 [INFO] finished tweaking crates.io crate slatedb 0.1.3 [INFO] tweaked toml for crates.io crate slatedb 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate slatedb 0.1.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 79eac788a4ce5410415f3e088bd06ef98339c9a57179c50fb69173929719eee1 [INFO] running `Command { std: "docker" "start" "-a" "79eac788a4ce5410415f3e088bd06ef98339c9a57179c50fb69173929719eee1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "79eac788a4ce5410415f3e088bd06ef98339c9a57179c50fb69173929719eee1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79eac788a4ce5410415f3e088bd06ef98339c9a57179c50fb69173929719eee1", kill_on_drop: false }` [INFO] [stdout] 79eac788a4ce5410415f3e088bd06ef98339c9a57179c50fb69173929719eee1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad686e6870439e4f6b66819d439cf63bb31cbca01a752574562cf02c3ddfb250 [INFO] running `Command { std: "docker" "start" "-a" "ad686e6870439e4f6b66819d439cf63bb31cbca01a752574562cf02c3ddfb250", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Checking bytes v1.6.1 [INFO] [stderr] Compiling cc v1.1.6 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking rustls-pki-types v1.8.0 [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking untrusted v0.9.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Compiling rustls v0.23.12 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling serde_json v1.0.120 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking parking v2.2.0 [INFO] [stderr] Checking rustls-pemfile v2.1.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking rustls-native-certs v0.7.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking siphasher v1.0.1 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking http v1.1.0 [INFO] [stderr] Checking event-listener v5.3.1 [INFO] [stderr] Compiling flatbuffers v24.3.25 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking crossbeam-skiplist v0.1.3 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking event-listener-strategy v0.5.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking async-channel v2.3.1 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling ring v0.17.8 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking ulid v1.1.3 [INFO] [stderr] Checking fail-parallel v0.5.1 [INFO] [stderr] Compiling snafu-derive v0.7.5 [INFO] [stderr] Compiling tokio-macros v2.3.0 [INFO] [stderr] Compiling futures-macro v0.3.30 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Checking tokio v1.38.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking snafu v0.7.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking rustls-webpki v0.102.6 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking tokio-rustls v0.26.0 [INFO] [stderr] Checking h2 v0.4.5 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking quick-xml v0.36.1 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking hyper-rustls v0.27.2 [INFO] [stderr] Checking reqwest v0.12.5 [INFO] [stderr] Checking object_store v0.10.2 [INFO] [stderr] Checking slatedb v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_iterator.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 81 | let mut cursor = self.block.data().slice(off_usz..); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let key_len = cursor.get_u16() as usize; [INFO] [stdout] 83 | let key = cursor.slice(..key_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let v = if value_len == TOMBSTONE { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let value = cursor.slice(..value_len as usize); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Some(KeyValueDeletable { key, value: v }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(CompactorState::new(db_state.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor.rs:172:23 [INFO] [stdout] | [INFO] [stdout] 170 | let core = self.state.db_state().clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | self.tokio_handle [INFO] [stdout] 172 | .block_on(self.manifest.update_db_state(core)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_executor.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 38 | handle: tokio::runtime::Handle, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | options: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | worker_tx: crossbeam_channel::Sender, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | table_store: Arc, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Arc::new(TokioCompactionExecutorInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | options, [INFO] [stdout] 46 | | handle, [INFO] [stdout] 47 | | worker_tx, [INFO] [stdout] ... | [INFO] [stdout] 50 | | is_stopped: AtomicBool::new(false), [INFO] [stdout] 51 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_executor.rs:91:50 [INFO] [stdout] | [INFO] [stdout] 91 | .map(|l0| SstIterator::new_spawn(l0, self.table_store.clone(), 4, 256)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_executor.rs:97:56 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|sr| SortedRunIterator::new_spawn(sr, self.table_store.clone(), 4, 256)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_state.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(core_db_state: CoreDbState) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self { [INFO] [stdout] 119 | memtable: WritableKVTable::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_state.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(core_db_state: CoreDbState) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | wal: WritableKVTable::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_state.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(core_db_state: CoreDbState) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | state: Arc::new(COWDbState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 122 | | imm_memtable: VecDeque::new(), [INFO] [stdout] 123 | | imm_wal: VecDeque::new(), [INFO] [stdout] 124 | | core: core_db_state, [INFO] [stdout] 125 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flatbuffer_types.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(data: Bytes) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | flatbuffers::root::(&data)?; [INFO] [stdout] 32 | Ok(Self { data }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flush.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 80 | mut rx: tokio::sync::mpsc::UnboundedReceiver<()>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let this = Arc::clone(self); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Some(tokio_handle.spawn(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 85 | | let mut ticker = [INFO] [stdout] 86 | | tokio::time::interval(Duration::from_millis(this.options.flush_ms as u64)); [INFO] [stdout] 87 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest_store.rs:172:27 [INFO] [stdout] | [INFO] [stdout] 170 | pub(crate) fn new(root_path: &Path, object_store: Arc) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Self { [INFO] [stdout] 172 | object_store: Box::new(DelegatingTransactionalObjectStore::new( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 173 | | root_path.child("manifest"), [INFO] [stdout] 174 | | object_store, [INFO] [stdout] 175 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest_store.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 170 | pub(crate) fn new(root_path: &Path, object_store: Arc) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | codec: Box::new(FlatBufferManifestCodec {}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest_store.rs:235:61 [INFO] [stdout] | [INFO] [stdout] 235 | self.codec.decode(&manifest_bytes).map(|m| Some((id, m))) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | self.0.next().map(|entry| KeyValueDeletable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | key: entry.key().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | self.0.next().map(|entry| KeyValueDeletable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | key: entry.key().clone(), [INFO] [stdout] 45 | value: entry.value().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:147:26 [INFO] [stdout] | [INFO] [stdout] 146 | let bounds = (Bound::Unbounded, Bound::Unbounded); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | MemTableIterator(self.map.range(bounds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 152 | let bounds = ( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | MemTableIterator(self.map.range(bounds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table_flush.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 71 | manifest: FenceableManifest, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | mut rx: tokio::sync::mpsc::UnboundedReceiver, [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let this = Arc::clone(self); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut is_shutdown = false; [INFO] [stdout] 77 | Some(tokio_handle.spawn(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 78 | | let mut flusher = MemtableFlusher { [INFO] [stdout] 79 | | db_inner: this.clone(), [INFO] [stdout] 80 | | manifest, [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 151 | fn decode_block(&self, bytes: Bytes) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let checksum_sz = std::mem::size_of::(); [INFO] [stdout] 153 | let block_bytes = bytes.slice(..bytes.len() - checksum_sz); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut checksum_bytes = bytes.slice(bytes.len() - checksum_sz..); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let decoded_block = Block::decode(block_bytes); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let decompressed_bytes = match self.compression_codec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(Block { [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | data: decompressed_bytes, [INFO] [stdout] 167 | | offsets: decoded_block.offsets, [INFO] [stdout] 168 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 369 | pub fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | let mut buf = self.finish_block()?.unwrap_or(Vec::new()); [INFO] [stdout] 371 | let mut maybe_filter = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | let info = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | Ok(EncodedSsTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 404 | | info, [INFO] [stdout] 405 | | filter: maybe_filter, [INFO] [stdout] 406 | | unconsumed_blocks: self.blocks, [INFO] [stdout] 407 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst_iter.rs:153:26 [INFO] [stdout] | [INFO] [stdout] 145 | let table = self.table.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let table_store = self.table_store.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 65 | object_store: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Arc::new(FailPointRegistry::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:84:27 [INFO] [stdout] | [INFO] [stdout] 78 | object_store: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | fp_registry: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | object_store: object_store.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 78 | object_store: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | fp_registry: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | filter_cache: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | |_| Result::Err(SlateDBError::IoError(std::io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 142 | | std::io::ErrorKind::Other, [INFO] [stdout] 143 | | "oops" [INFO] [stdout] 144 | | ))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:150:29 [INFO] [stdout] | [INFO] [stdout] 150 | |_| Result::Err(SlateDBError::IoError(std::io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 151 | | std::io::ErrorKind::Other, [INFO] [stdout] 152 | | "oops" [INFO] [stdout] 153 | | ))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transactional_object_store.rs:63:93 [INFO] [stdout] | [INFO] [stdout] 63 | async fn put_if_not_exists(&self, path: &Path, data: Bytes) -> Result { [INFO] [stdout] | ____________________________________________________-----------______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | | let path = self.path(path); [INFO] [stdout] 65 | | self.object_store [INFO] [stdout] 66 | | .put_opts( [INFO] [stdout] ... | [INFO] [stdout] 71 | | .await [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 28 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slatedb` (lib) due to 29 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/block_iterator.rs:94:14 [INFO] [stdout] | [INFO] [stdout] 81 | let mut cursor = self.block.data().slice(off_usz..); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | let key_len = cursor.get_u16() as usize; [INFO] [stdout] 83 | let key = cursor.slice(..key_len); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 87 | let v = if value_len == TOMBSTONE { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let value = cursor.slice(..value_len as usize); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | Some(KeyValueDeletable { key, value: v }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor.rs:133:12 [INFO] [stdout] | [INFO] [stdout] 133 | Ok(CompactorState::new(db_state.clone())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor.rs:172:23 [INFO] [stdout] | [INFO] [stdout] 170 | let core = self.state.db_state().clone(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | self.tokio_handle [INFO] [stdout] 172 | .block_on(self.manifest.update_db_state(core)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_executor.rs:44:20 [INFO] [stdout] | [INFO] [stdout] 38 | handle: tokio::runtime::Handle, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | options: Arc, [INFO] [stdout] | ------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | worker_tx: crossbeam_channel::Sender, [INFO] [stdout] | -------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | table_store: Arc, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | inner: Arc::new(TokioCompactionExecutorInner { [INFO] [stdout] | ____________________^ [INFO] [stdout] 45 | | options, [INFO] [stdout] 46 | | handle, [INFO] [stdout] 47 | | worker_tx, [INFO] [stdout] ... | [INFO] [stdout] 50 | | is_stopped: AtomicBool::new(false), [INFO] [stdout] 51 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_executor.rs:91:50 [INFO] [stdout] | [INFO] [stdout] 91 | .map(|l0| SstIterator::new_spawn(l0, self.table_store.clone(), 4, 256)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_executor.rs:97:56 [INFO] [stdout] | [INFO] [stdout] 97 | .map(|sr| SortedRunIterator::new_spawn(sr, self.table_store.clone(), 4, 256)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compactor_state.rs:504:9 [INFO] [stdout] | [INFO] [stdout] 503 | fn build_db(os: Arc, tokio_handle: &Handle) -> Db { [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 504 | / tokio_handle [INFO] [stdout] 505 | | .block_on(Db::open(Path::from(PATH), os)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_state.rs:119:23 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(core_db_state: CoreDbState) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | Self { [INFO] [stdout] 119 | memtable: WritableKVTable::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_state.rs:120:18 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(core_db_state: CoreDbState) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 120 | wal: WritableKVTable::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/db_state.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 117 | pub fn new(core_db_state: CoreDbState) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 121 | state: Arc::new(COWDbState { [INFO] [stdout] | ____________________^ [INFO] [stdout] 122 | | imm_memtable: VecDeque::new(), [INFO] [stdout] 123 | | imm_wal: VecDeque::new(), [INFO] [stdout] 124 | | core: core_db_state, [INFO] [stdout] 125 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flatbuffer_types.rs:32:12 [INFO] [stdout] | [INFO] [stdout] 30 | pub fn new(data: Bytes) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | flatbuffers::root::(&data)?; [INFO] [stdout] 32 | Ok(Self { data }) [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/flush.rs:84:14 [INFO] [stdout] | [INFO] [stdout] 80 | mut rx: tokio::sync::mpsc::UnboundedReceiver<()>, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | let this = Arc::clone(self); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 84 | Some(tokio_handle.spawn(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 85 | | let mut ticker = [INFO] [stdout] 86 | | tokio::time::interval(Duration::from_millis(this.options.flush_ms as u64)); [INFO] [stdout] 87 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 99 | | } [INFO] [stdout] 100 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest_store.rs:172:27 [INFO] [stdout] | [INFO] [stdout] 170 | pub(crate) fn new(root_path: &Path, object_store: Arc) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 171 | Self { [INFO] [stdout] 172 | object_store: Box::new(DelegatingTransactionalObjectStore::new( [INFO] [stdout] | ___________________________^ [INFO] [stdout] 173 | | root_path.child("manifest"), [INFO] [stdout] 174 | | object_store, [INFO] [stdout] 175 | | )), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest_store.rs:176:20 [INFO] [stdout] | [INFO] [stdout] 170 | pub(crate) fn new(root_path: &Path, object_store: Arc) -> Self { [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | codec: Box::new(FlatBufferManifestCodec {}), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/manifest_store.rs:235:61 [INFO] [stdout] | [INFO] [stdout] 235 | self.codec.decode(&manifest_bytes).map(|m| Some((id, m))) [INFO] [stdout] | - ^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:44:18 [INFO] [stdout] | [INFO] [stdout] 43 | self.0.next().map(|entry| KeyValueDeletable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | key: entry.key().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:45:20 [INFO] [stdout] | [INFO] [stdout] 43 | self.0.next().map(|entry| KeyValueDeletable { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 44 | key: entry.key().clone(), [INFO] [stdout] 45 | value: entry.value().clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:147:26 [INFO] [stdout] | [INFO] [stdout] 146 | let bounds = (Bound::Unbounded, Bound::Unbounded); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 147 | MemTableIterator(self.map.range(bounds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table.rs:156:26 [INFO] [stdout] | [INFO] [stdout] 152 | let bounds = ( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 156 | MemTableIterator(self.map.range(bounds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/mem_table_flush.rs:77:14 [INFO] [stdout] | [INFO] [stdout] 71 | manifest: FenceableManifest, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | mut rx: tokio::sync::mpsc::UnboundedReceiver, [INFO] [stdout] | -------------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 75 | let this = Arc::clone(self); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 76 | let mut is_shutdown = false; [INFO] [stdout] 77 | Some(tokio_handle.spawn(async move { [INFO] [stdout] | ______________^ [INFO] [stdout] 78 | | let mut flusher = MemtableFlusher { [INFO] [stdout] 79 | | db_inner: this.clone(), [INFO] [stdout] 80 | | manifest, [INFO] [stdout] ... | [INFO] [stdout] 111 | | } [INFO] [stdout] 112 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst.rs:165:12 [INFO] [stdout] | [INFO] [stdout] 151 | fn decode_block(&self, bytes: Bytes) -> Result { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 152 | let checksum_sz = std::mem::size_of::(); [INFO] [stdout] 153 | let block_bytes = bytes.slice(..bytes.len() - checksum_sz); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | let mut checksum_bytes = bytes.slice(bytes.len() - checksum_sz..); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let decoded_block = Block::decode(block_bytes); [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | let decompressed_bytes = match self.compression_codec { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 165 | Ok(Block { [INFO] [stdout] | ____________^ [INFO] [stdout] 166 | | data: decompressed_bytes, [INFO] [stdout] 167 | | offsets: decoded_block.offsets, [INFO] [stdout] 168 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst.rs:403:12 [INFO] [stdout] | [INFO] [stdout] 369 | pub fn build(mut self) -> Result { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 370 | let mut buf = self.finish_block()?.unwrap_or(Vec::new()); [INFO] [stdout] 371 | let mut maybe_filter = None; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 395 | let info = [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 403 | Ok(EncodedSsTable { [INFO] [stdout] | ____________^ [INFO] [stdout] 404 | | info, [INFO] [stdout] 405 | | filter: maybe_filter, [INFO] [stdout] 406 | | unconsumed_blocks: self.blocks, [INFO] [stdout] 407 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst.rs:656:37 [INFO] [stdout] | [INFO] [stdout] 656 | .for_each(|b| bytes.put(b.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst.rs:710:37 [INFO] [stdout] | [INFO] [stdout] 710 | .for_each(|b| bytes.put(b.clone())); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sst_iter.rs:153:26 [INFO] [stdout] | [INFO] [stdout] 145 | let table = self.table.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 146 | let table_store = self.table_store.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | .await [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 65 | object_store: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 73 | Arc::new(FailPointRegistry::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:84:27 [INFO] [stdout] | [INFO] [stdout] 78 | object_store: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | fp_registry: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | object_store: object_store.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:90:27 [INFO] [stdout] | [INFO] [stdout] 78 | object_store: Arc, [INFO] [stdout] | ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 81 | fp_registry: Arc, [INFO] [stdout] | ----------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | filter_cache: RwLock::new(HashMap::new()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:141:29 [INFO] [stdout] | [INFO] [stdout] 141 | |_| Result::Err(SlateDBError::IoError(std::io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 142 | | std::io::ErrorKind::Other, [INFO] [stdout] 143 | | "oops" [INFO] [stdout] 144 | | ))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/tablestore.rs:150:29 [INFO] [stdout] | [INFO] [stdout] 150 | |_| Result::Err(SlateDBError::IoError(std::io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 151 | | std::io::ErrorKind::Other, [INFO] [stdout] 152 | | "oops" [INFO] [stdout] 153 | | ))) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/transactional_object_store.rs:63:93 [INFO] [stdout] | [INFO] [stdout] 63 | async fn put_if_not_exists(&self, path: &Path, data: Bytes) -> Result { [INFO] [stdout] | ____________________________________________________-----------______________________________^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | | let path = self.path(path); [INFO] [stdout] 65 | | self.object_store [INFO] [stdout] 66 | | .put_opts( [INFO] [stdout] ... | [INFO] [stdout] 71 | | .await [INFO] [stdout] 72 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slatedb` (lib test) due to 32 previous errors [INFO] running `Command { std: "docker" "inspect" "ad686e6870439e4f6b66819d439cf63bb31cbca01a752574562cf02c3ddfb250", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad686e6870439e4f6b66819d439cf63bb31cbca01a752574562cf02c3ddfb250", kill_on_drop: false }` [INFO] [stdout] ad686e6870439e4f6b66819d439cf63bb31cbca01a752574562cf02c3ddfb250