[INFO] fetching crate slap-cli 1.3.1... [INFO] checking slap-cli-1.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate slap-cli 1.3.1 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate slap-cli 1.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate slap-cli 1.3.1 [INFO] finished tweaking crates.io crate slap-cli 1.3.1 [INFO] tweaked toml for crates.io crate slap-cli 1.3.1 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate slap-cli 1.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3e3873dc8572a34fa43302e63d6c2a23f0c32b53d52e540d45adc02a0fe697e7 [INFO] running `Command { std: "docker" "start" "-a" "3e3873dc8572a34fa43302e63d6c2a23f0c32b53d52e540d45adc02a0fe697e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3e3873dc8572a34fa43302e63d6c2a23f0c32b53d52e540d45adc02a0fe697e7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e3873dc8572a34fa43302e63d6c2a23f0c32b53d52e540d45adc02a0fe697e7", kill_on_drop: false }` [INFO] [stdout] 3e3873dc8572a34fa43302e63d6c2a23f0c32b53d52e540d45adc02a0fe697e7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9b459a599479d475c1e71ae3509d0df18bf80d3c3599bd0829679d9591a2faef [INFO] running `Command { std: "docker" "start" "-a" "9b459a599479d475c1e71ae3509d0df18bf80d3c3599bd0829679d9591a2faef", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.20 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling libc v0.2.76 [INFO] [stderr] Compiling syn v1.0.39 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling serde v1.0.115 [INFO] [stderr] Compiling ryu v1.0.5 [INFO] [stderr] Compiling anyhow v1.0.32 [INFO] [stderr] Compiling serde_json v1.0.57 [INFO] [stderr] Checking thread_local v1.0.1 [INFO] [stderr] Checking regex-syntax v0.6.18 [INFO] [stderr] Checking yaml-rust v0.3.5 [INFO] [stderr] Checking itoa v0.4.6 [INFO] [stderr] Checking termcolor v1.1.0 [INFO] [stderr] Checking aho-corasick v0.7.13 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.33.3 [INFO] [stderr] Checking regex v1.3.9 [INFO] [stderr] Compiling thiserror-impl v1.0.20 [INFO] [stderr] Checking thiserror v1.0.20 [INFO] [stderr] Checking which v4.0.2 [INFO] [stderr] Checking slap-cli v1.3.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 327 | let external_app_help_subcmd = AppWrapper::new(SubCommand::with_name("help"), |app: App| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | app.arg(Arg::with_name("SUBCMD").required(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 334 | let subcommand = external_app_help_subcmd.app; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | let subcommands = external_app_subcommands.clone().into_iter().map(|x| x.app); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 336 | move |app: App| app.subcommand(subcommand).subcommands(subcommands) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_wrapper.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 22 | app: App<'a, 'b>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | modify_app: impl FnOnce(App<'a, 'b>) -> App<'a, 'b>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | ) -> anyhow::Result { [INFO] [stdout] 25 | let app = app [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let app = modify_app(app); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | app, [INFO] [stdout] 54 | | help_msg: help_msg.into(), [INFO] [stdout] 55 | | version_msg: version_msg.into(), [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slap-cli` (bin "slap") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:328:9 [INFO] [stdout] | [INFO] [stdout] 327 | let external_app_help_subcmd = AppWrapper::new(SubCommand::with_name("help"), |app: App| { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 328 | app.arg(Arg::with_name("SUBCMD").required(false)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:336:25 [INFO] [stdout] | [INFO] [stdout] 334 | let subcommand = external_app_help_subcmd.app; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 335 | let subcommands = external_app_subcommands.clone().into_iter().map(|x| x.app); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 336 | move |app: App| app.subcommand(subcommand).subcommands(subcommands) [INFO] [stdout] | -------- ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app_wrapper.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 22 | app: App<'a, 'b>, [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | modify_app: impl FnOnce(App<'a, 'b>) -> App<'a, 'b>, [INFO] [stdout] | --------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 24 | ) -> anyhow::Result { [INFO] [stdout] 25 | let app = app [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 43 | let app = modify_app(app); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 53 | | app, [INFO] [stdout] 54 | | help_msg: help_msg.into(), [INFO] [stdout] 55 | | version_msg: version_msg.into(), [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `slap-cli` (bin "slap" test) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "9b459a599479d475c1e71ae3509d0df18bf80d3c3599bd0829679d9591a2faef", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9b459a599479d475c1e71ae3509d0df18bf80d3c3599bd0829679d9591a2faef", kill_on_drop: false }` [INFO] [stdout] 9b459a599479d475c1e71ae3509d0df18bf80d3c3599bd0829679d9591a2faef