[INFO] fetching crate skeptic 0.13.7... [INFO] checking skeptic-0.13.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate skeptic 0.13.7 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate skeptic 0.13.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate skeptic 0.13.7 [INFO] finished tweaking crates.io crate skeptic 0.13.7 [INFO] tweaked toml for crates.io crate skeptic 0.13.7 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 45 packages to latest compatible versions [INFO] [stderr] Adding cargo_metadata v0.14.2 (latest: v0.18.1) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding pulldown-cmark v0.9.6 (latest: v0.12.0) [INFO] [stderr] Adding unindent v0.1.11 (latest: v0.2.3) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] eea15613e6f1f24725eb1fcd854e84053ea6955ffd74d233c3aacc3995966fe9 [INFO] running `Command { std: "docker" "start" "-a" "eea15613e6f1f24725eb1fcd854e84053ea6955ffd74d233c3aacc3995966fe9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "eea15613e6f1f24725eb1fcd854e84053ea6955ffd74d233c3aacc3995966fe9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "eea15613e6f1f24725eb1fcd854e84053ea6955ffd74d233c3aacc3995966fe9", kill_on_drop: false }` [INFO] [stdout] eea15613e6f1f24725eb1fcd854e84053ea6955ffd74d233c3aacc3995966fe9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4a44dc2385c655ac94ce5e27d282a0bb3bb0beed60159337bb7748375303089b [INFO] running `Command { std: "docker" "start" "-a" "4a44dc2385c655ac94ce5e27d282a0bb3bb0beed60159337bb7748375303089b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling camino v1.1.9 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling pulldown-cmark v0.9.6 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Checking bytecount v0.6.8 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Checking unindent v0.1.11 [INFO] [stderr] Compiling unicase v2.7.0 [INFO] [stderr] Compiling error-chain v0.12.4 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking cargo-platform v0.1.8 [INFO] [stderr] Checking semver v1.0.23 [INFO] [stderr] Checking cargo_metadata v0.14.2 [INFO] [stderr] Checking skeptic v0.13.7 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | Ok(found_deps [INFO] [stdout] | ________^ [INFO] [stdout] 176 | | .into_iter() [INFO] [stdout] 177 | | .filter_map(|(_, val)| if val.rlib.exists() { Some(val) } else { None }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | .filter_map(|v| Fingerprint::from_path(v.ok()?.path()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:190:8 [INFO] [stdout] | [INFO] [stdout] 188 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> Result { [INFO] [stdout] 190 | Ok(cargo_metadata::MetadataCommand::new() [INFO] [stdout] | ________^ [INFO] [stdout] 191 | | .manifest_path(&path) [INFO] [stdout] 192 | | .exec()?) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:210:27 [INFO] [stdout] | [INFO] [stdout] 196 | fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | let path = path.as_ref().join("Cargo.toml"); [INFO] [stdout] 198 | let metadata = get_cargo_meta(&path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let workspace_members = metadata.workspace_members; [INFO] [stdout] 200 | let deps = metadata [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | dependencies: deps.map(|node| node.repr).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `skeptic` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:175:8 [INFO] [stdout] | [INFO] [stdout] 175 | Ok(found_deps [INFO] [stdout] | ________^ [INFO] [stdout] 176 | | .into_iter() [INFO] [stdout] 177 | | .filter_map(|(_, val)| if val.rlib.exists() { Some(val) } else { None }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |________________________________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:149:25 [INFO] [stdout] | [INFO] [stdout] 149 | .filter_map(|v| Fingerprint::from_path(v.ok()?.path()).ok()) [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:190:8 [INFO] [stdout] | [INFO] [stdout] 188 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 189 | ) -> Result { [INFO] [stdout] 190 | Ok(cargo_metadata::MetadataCommand::new() [INFO] [stdout] | ________^ [INFO] [stdout] 191 | | .manifest_path(&path) [INFO] [stdout] 192 | | .exec()?) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rt.rs:210:27 [INFO] [stdout] | [INFO] [stdout] 196 | fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | let path = path.as_ref().join("Cargo.toml"); [INFO] [stdout] 198 | let metadata = get_cargo_meta(&path)?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let workspace_members = metadata.workspace_members; [INFO] [stdout] 200 | let deps = metadata [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | dependencies: deps.map(|node| node.repr).collect(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `skeptic` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "4a44dc2385c655ac94ce5e27d282a0bb3bb0beed60159337bb7748375303089b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4a44dc2385c655ac94ce5e27d282a0bb3bb0beed60159337bb7748375303089b", kill_on_drop: false }` [INFO] [stdout] 4a44dc2385c655ac94ce5e27d282a0bb3bb0beed60159337bb7748375303089b