[INFO] fetching crate skeleton-cli 0.1.0... [INFO] checking skeleton-cli-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate skeleton-cli 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate skeleton-cli 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate skeleton-cli 0.1.0 [INFO] finished tweaking crates.io crate skeleton-cli 0.1.0 [INFO] tweaked toml for crates.io crate skeleton-cli 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] crate crates.io crate skeleton-cli 0.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2e7bf907cc8af8a2a55eb631cefd024c370b98cd890f3f12ed9bc39901a6b64c [INFO] running `Command { std: "docker" "start" "-a" "2e7bf907cc8af8a2a55eb631cefd024c370b98cd890f3f12ed9bc39901a6b64c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2e7bf907cc8af8a2a55eb631cefd024c370b98cd890f3f12ed9bc39901a6b64c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2e7bf907cc8af8a2a55eb631cefd024c370b98cd890f3f12ed9bc39901a6b64c", kill_on_drop: false }` [INFO] [stdout] 2e7bf907cc8af8a2a55eb631cefd024c370b98cd890f3f12ed9bc39901a6b64c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3e35130925e271d6715ec598ee203cefce7094b372d1c51ad10abbc17052523e [INFO] running `Command { std: "docker" "start" "-a" "3e35130925e271d6715ec598ee203cefce7094b372d1c51ad10abbc17052523e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.155 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling rustix v0.38.34 [INFO] [stderr] Checking anstyle-parse v0.2.4 [INFO] [stderr] Checking os_str_bytes v6.6.1 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking anstyle-query v1.1.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking is_terminal_polyfill v1.70.0 [INFO] [stderr] Checking anstyle v1.0.7 [INFO] [stderr] Checking colorchoice v1.0.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Compiling vte_generate_state_changes v0.1.2 [INFO] [stderr] Compiling syn v2.0.70 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking anstream v0.6.14 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking textwrap v0.16.1 [INFO] [stderr] Checking clap_lex v0.7.1 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking indexmap v2.2.6 [INFO] [stderr] Checking vte v0.11.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking fuzzy-matcher v0.3.7 [INFO] [stderr] Checking clap_builder v4.5.9 [INFO] [stderr] Checking defer-drop v1.3.0 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking beef v0.5.2 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking colored v2.1.0 [INFO] [stderr] Checking executable-path v1.0.0 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking timer v0.2.0 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.24.3 [INFO] [stderr] Checking nix v0.25.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stderr] Checking clap v3.2.25 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking dialoguer v0.10.4 [INFO] [stderr] Checking tempdir v0.3.7 [INFO] [stderr] Checking tuikit v0.5.0 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling clap_derive v4.5.8 [INFO] [stderr] Checking clap v4.5.9 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.11.2 [INFO] [stderr] Compiling derive_builder_macro v0.11.2 [INFO] [stderr] Checking derive_builder v0.11.2 [INFO] [stderr] Checking skim v0.10.4 [INFO] [stderr] Checking skeleton-cli v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | .try_for_each(|note| tx.send(Arc::new(note.to_owned())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:33:41 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(self.templates()?.iter().any(|t| t.name().unwrap() == name)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 55 | let mut variables = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Template { [INFO] [stdout] | ________^ [INFO] [stdout] 63 | | path, [INFO] [stdout] 64 | | content, [INFO] [stdout] 65 | | variables, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/search.rs:24:36 [INFO] [stdout] | [INFO] [stdout] 24 | .try_for_each(|note| tx.send(Arc::new(note.to_owned())))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:33:41 [INFO] [stdout] | [INFO] [stdout] 33 | Ok(self.templates()?.iter().any(|t| t.name().unwrap() == name)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:100:38 [INFO] [stdout] | [INFO] [stdout] 100 | assert!(templates.iter().any(|t| t.name().unwrap() == template_name)); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:129:17 [INFO] [stdout] | [INFO] [stdout] 129 | .find(|t| t.name().unwrap() == template_name) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/store.rs:157:17 [INFO] [stdout] | [INFO] [stdout] 157 | .find(|t| t.name().unwrap() == template_name) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/template.rs:62:8 [INFO] [stdout] | [INFO] [stdout] 55 | let mut variables = HashMap::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 62 | Ok(Template { [INFO] [stdout] | ________^ [INFO] [stdout] 63 | | path, [INFO] [stdout] 64 | | content, [INFO] [stdout] 65 | | variables, [INFO] [stdout] 66 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `skeleton-cli` (bin "sk") due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `skeleton-cli` (bin "sk" test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "3e35130925e271d6715ec598ee203cefce7094b372d1c51ad10abbc17052523e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3e35130925e271d6715ec598ee203cefce7094b372d1c51ad10abbc17052523e", kill_on_drop: false }` [INFO] [stdout] 3e35130925e271d6715ec598ee203cefce7094b372d1c51ad10abbc17052523e