[INFO] fetching crate sk-cbor 0.1.2... [INFO] checking sk-cbor-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sk-cbor 0.1.2 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate sk-cbor 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sk-cbor 0.1.2 [INFO] finished tweaking crates.io crate sk-cbor 0.1.2 [INFO] tweaked toml for crates.io crate sk-cbor 0.1.2 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate sk-cbor 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e2e70adde31b997626389b713f546e8bcdea517c81a907d05b2e71c5d749a6f3 [INFO] running `Command { std: "docker" "start" "-a" "e2e70adde31b997626389b713f546e8bcdea517c81a907d05b2e71c5d749a6f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e2e70adde31b997626389b713f546e8bcdea517c81a907d05b2e71c5d749a6f3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e2e70adde31b997626389b713f546e8bcdea517c81a907d05b2e71c5d749a6f3", kill_on_drop: false }` [INFO] [stdout] e2e70adde31b997626389b713f546e8bcdea517c81a907d05b2e71c5d749a6f3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 677a50939859f12fcc96fa84db037b2590859950a4bb5002ce9af335eea15265 [INFO] running `Command { std: "docker" "start" "-a" "677a50939859f12fcc96fa84db037b2590859950a4bb5002ce9af335eea15265", kill_on_drop: false }` [INFO] [stderr] Checking sk-cbor v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 261 | ( $vec:expr ) => {{ [INFO] [stdout] | _______________________^ [INFO] [stdout] 262 | | use $crate::values::IntoCborValue; [INFO] [stdout] 263 | | $crate::values::Value::Array($vec.into_iter().map(|x| x.into_cbor_value()).collect()) [INFO] [stdout] 264 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] ::: src/reader.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | let mut value_array = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(cbor_array_vec!(value_array)) [INFO] [stdout] | ---------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `cbor_array_vec` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:225:24 [INFO] [stdout] | [INFO] [stdout] 225 | ( $tree:expr ) => {{ [INFO] [stdout] | ________________________^ [INFO] [stdout] 226 | | $crate::values::Value::from($tree) [INFO] [stdout] 227 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] ::: src/reader.rs:185:17 [INFO] [stdout] | [INFO] [stdout] 185 | let mut value_map = Vec::<(Value, Value)>::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(cbor_map_collection!(value_map)) [INFO] [stdout] | ------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `cbor_map_collection` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 343 | $crate::values::Value::Tag($t, ::alloc::boxed::Box::new($x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reader.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | let inner_value = self.decode_complete_data_item(remaining_depth.map(|d| d - 1))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Ok(cbor_tagged!(tag_value, inner_value)) [INFO] [stdout] | ------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `cbor_tagged` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:249:14 [INFO] [stdout] | [INFO] [stdout] 248 | fn into_cbor_value_option(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Some(Value::from(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sk-cbor` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:261:23 [INFO] [stdout] | [INFO] [stdout] 261 | ( $vec:expr ) => {{ [INFO] [stdout] | _______________________^ [INFO] [stdout] 262 | | use $crate::values::IntoCborValue; [INFO] [stdout] 263 | | $crate::values::Value::Array($vec.into_iter().map(|x| x.into_cbor_value()).collect()) [INFO] [stdout] 264 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] ::: src/reader.rs:173:17 [INFO] [stdout] | [INFO] [stdout] 173 | let mut value_array = Vec::new(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | Ok(cbor_array_vec!(value_array)) [INFO] [stdout] | ---------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] = note: this error originates in the macro `cbor_array_vec` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:225:24 [INFO] [stdout] | [INFO] [stdout] 225 | ( $tree:expr ) => {{ [INFO] [stdout] | ________________________^ [INFO] [stdout] 226 | | $crate::values::Value::from($tree) [INFO] [stdout] 227 | | }}; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] ::: src/reader.rs:185:17 [INFO] [stdout] | [INFO] [stdout] 185 | let mut value_map = Vec::<(Value, Value)>::new(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 198 | Ok(cbor_map_collection!(value_map)) [INFO] [stdout] | ------------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `cbor_map_collection` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/macros.rs:343:9 [INFO] [stdout] | [INFO] [stdout] 343 | $crate::values::Value::Tag($t, ::alloc::boxed::Box::new($x)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] ::: src/reader.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | let inner_value = self.decode_complete_data_item(remaining_depth.map(|d| d - 1))?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 207 | Ok(cbor_tagged!(tag_value, inner_value)) [INFO] [stdout] | ------------------------------------ in this macro invocation [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `cbor_tagged` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/values.rs:249:14 [INFO] [stdout] | [INFO] [stdout] 248 | fn into_cbor_value_option(self) -> Option { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 249 | Some(Value::from(self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sk-cbor` (lib test) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "677a50939859f12fcc96fa84db037b2590859950a4bb5002ce9af335eea15265", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "677a50939859f12fcc96fa84db037b2590859950a4bb5002ce9af335eea15265", kill_on_drop: false }` [INFO] [stdout] 677a50939859f12fcc96fa84db037b2590859950a4bb5002ce9af335eea15265