[INFO] fetching crate situwaition 0.3.2... [INFO] checking situwaition-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate situwaition 0.3.2 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate situwaition 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate situwaition 0.3.2 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate situwaition 0.3.2 [INFO] tweaked toml for crates.io crate situwaition 0.3.2 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate situwaition 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 10ce8baf2c51ae115f79eb2949a9081a4b7f840d110c91b07c43deab14951330 [INFO] running `Command { std: "docker" "start" "-a" "10ce8baf2c51ae115f79eb2949a9081a4b7f840d110c91b07c43deab14951330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "10ce8baf2c51ae115f79eb2949a9081a4b7f840d110c91b07c43deab14951330", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "10ce8baf2c51ae115f79eb2949a9081a4b7f840d110c91b07c43deab14951330", kill_on_drop: false }` [INFO] [stdout] 10ce8baf2c51ae115f79eb2949a9081a4b7f840d110c91b07c43deab14951330 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2785475bdea1b86ac531aa03fb8caaa343340b1908e6f288a209a0d01895bb9e [INFO] running `Command { std: "docker" "start" "-a" "2785475bdea1b86ac531aa03fb8caaa343340b1908e6f288a209a0d01895bb9e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.64 [INFO] [stderr] Compiling unicode-ident v1.0.10 [INFO] [stderr] Compiling quote v1.0.29 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking value-bag v1.4.1 [INFO] [stderr] Checking pin-project-lite v0.2.10 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling io-lifetimes v1.0.11 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Checking log v0.4.19 [INFO] [stderr] Checking waker-fn v1.1.0 [INFO] [stderr] Checking parking v2.1.0 [INFO] [stderr] Checking concurrent-queue v2.2.0 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking async-lock v2.7.0 [INFO] [stderr] Compiling rustix v0.37.23 [INFO] [stderr] Compiling syn v2.0.25 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Checking async-task v4.4.0 [INFO] [stderr] Checking linux-raw-sys v0.3.8 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking atomic-waker v1.1.1 [INFO] [stderr] Compiling thiserror v1.0.43 [INFO] [stderr] Compiling anyhow v1.0.71 [INFO] [stderr] Compiling situwaition v0.3.2 (/opt/rustwide/workdir) [INFO] [stderr] Compiling tokio v1.29.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking async-executor v1.5.1 [INFO] [stderr] Checking blocking v1.3.1 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking kv-log-macro v1.0.7 [INFO] [stderr] Compiling thiserror-impl v1.0.43 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Checking async-global-executor v2.3.1 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling async-attributes v1.1.2 [INFO] [stderr] Checking async-std v1.12.0 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/mod.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 78 | factory: A, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | factory, [INFO] [stdout] 88 | | SituwaitionOpts { [INFO] [stdout] 89 | | timeout, [INFO] [stdout] 90 | | ..SituwaitionOpts::default() [INFO] [stdout] 91 | | }, [INFO] [stdout] 92 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/mod.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 98 | factory: A, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | factory, [INFO] [stdout] 108 | | SituwaitionOpts { [INFO] [stdout] 109 | | check_interval, [INFO] [stdout] 110 | | ..SituwaitionOpts::default() [INFO] [stdout] 111 | | }, [INFO] [stdout] 112 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:138:23 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn from_fn(check_fn: F) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | check_fn: Some(Box::new(check_fn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:146:23 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn with_opts(check_fn: F, opts: SituwaitionOpts) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | check_fn: Some(Box::new(check_fn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn with_timeout(check_fn: F, timeout: Duration) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 158 | | check_fn, [INFO] [stdout] 159 | | SituwaitionOpts { [INFO] [stdout] 160 | | timeout, [INFO] [stdout] 161 | | ..SituwaitionOpts::default() [INFO] [stdout] 162 | | }, [INFO] [stdout] 163 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 168 | check_fn: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | check_fn, [INFO] [stdout] 178 | | SituwaitionOpts { [INFO] [stdout] 179 | | check_interval, [INFO] [stdout] 180 | | ..SituwaitionOpts::default() [INFO] [stdout] 181 | | }, [INFO] [stdout] 182 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn wait_for(check_fn: F) -> Result> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | SyncWaiter::from_fn(check_fn).exec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `situwaition` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/mod.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 78 | factory: A, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 86 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | factory, [INFO] [stdout] 88 | | SituwaitionOpts { [INFO] [stdout] 89 | | timeout, [INFO] [stdout] 90 | | ..SituwaitionOpts::default() [INFO] [stdout] 91 | | }, [INFO] [stdout] 92 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/runtime/mod.rs:106:12 [INFO] [stdout] | [INFO] [stdout] 98 | factory: A, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 106 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 107 | | factory, [INFO] [stdout] 108 | | SituwaitionOpts { [INFO] [stdout] 109 | | check_interval, [INFO] [stdout] 110 | | ..SituwaitionOpts::default() [INFO] [stdout] 111 | | }, [INFO] [stdout] 112 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:138:23 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn from_fn(check_fn: F) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 138 | check_fn: Some(Box::new(check_fn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:146:23 [INFO] [stdout] | [INFO] [stdout] 143 | pub fn with_opts(check_fn: F, opts: SituwaitionOpts) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 146 | check_fn: Some(Box::new(check_fn)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 151 | pub fn with_timeout(check_fn: F, timeout: Duration) -> Result { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 157 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 158 | | check_fn, [INFO] [stdout] 159 | | SituwaitionOpts { [INFO] [stdout] 160 | | timeout, [INFO] [stdout] 161 | | ..SituwaitionOpts::default() [INFO] [stdout] 162 | | }, [INFO] [stdout] 163 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:176:12 [INFO] [stdout] | [INFO] [stdout] 168 | check_fn: F, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 176 | Ok(Self::with_opts( [INFO] [stdout] | ____________^ [INFO] [stdout] 177 | | check_fn, [INFO] [stdout] 178 | | SituwaitionOpts { [INFO] [stdout] 179 | | check_interval, [INFO] [stdout] 180 | | ..SituwaitionOpts::default() [INFO] [stdout] 181 | | }, [INFO] [stdout] 182 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:201:5 [INFO] [stdout] | [INFO] [stdout] 195 | pub fn wait_for(check_fn: F) -> Result> [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | SyncWaiter::from_fn(check_fn).exec() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:233:46 [INFO] [stdout] | [INFO] [stdout] 233 | || Err::<(), std::io::Error>(std::io::Error::new(ErrorKind::Other, "test")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sync.rs:264:50 [INFO] [stdout] | [INFO] [stdout] 264 | || Err::<(), std::io::Error>(std::io::Error::new(ErrorKind::Other, "test")), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 9 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `situwaition` (lib test) due to 10 previous errors [INFO] running `Command { std: "docker" "inspect" "2785475bdea1b86ac531aa03fb8caaa343340b1908e6f288a209a0d01895bb9e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2785475bdea1b86ac531aa03fb8caaa343340b1908e6f288a209a0d01895bb9e", kill_on_drop: false }` [INFO] [stdout] 2785475bdea1b86ac531aa03fb8caaa343340b1908e6f288a209a0d01895bb9e