[INFO] fetching crate site 0.8.0... [INFO] checking site-0.8.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate site 0.8.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate site 0.8.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate site 0.8.0 [INFO] finished tweaking crates.io crate site 0.8.0 [INFO] tweaked toml for crates.io crate site 0.8.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate site 0.8.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3f5bb1797bc1482625f7c0ebf530494e69a2fdee595554d21e2363c75d538bc5 [INFO] running `Command { std: "docker" "start" "-a" "3f5bb1797bc1482625f7c0ebf530494e69a2fdee595554d21e2363c75d538bc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3f5bb1797bc1482625f7c0ebf530494e69a2fdee595554d21e2363c75d538bc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3f5bb1797bc1482625f7c0ebf530494e69a2fdee595554d21e2363c75d538bc5", kill_on_drop: false }` [INFO] [stdout] 3f5bb1797bc1482625f7c0ebf530494e69a2fdee595554d21e2363c75d538bc5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 38cd84706365dc031f404225ec055ee0b4450fdfca35198c2ad063145b71968b [INFO] running `Command { std: "docker" "start" "-a" "38cd84706365dc031f404225ec055ee0b4450fdfca35198c2ad063145b71968b", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Compiling serde v1.0.204 [INFO] [stderr] Compiling rayon-core v1.12.1 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Compiling pulldown-cmark v0.11.0 [INFO] [stderr] Checking termcolor v1.4.1 [INFO] [stderr] Checking regex v1.10.5 [INFO] [stderr] Checking is-terminal v0.4.12 [INFO] [stderr] Checking memo-map v0.3.3 [INFO] [stderr] Checking clap_builder v4.5.13 [INFO] [stderr] Checking self_cell v1.0.4 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking glob v0.3.1 [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling serde_derive v1.0.204 [INFO] [stderr] Compiling clap_derive v4.5.13 [INFO] [stderr] Checking clap v4.5.13 [INFO] [stderr] Checking toml_datetime v0.6.8 [INFO] [stderr] Checking serde_spanned v0.6.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking minijinja v2.1.1 [INFO] [stderr] Checking toml_edit v0.22.20 [INFO] [stderr] Checking toml v0.8.19 [INFO] [stderr] Checking site v0.8.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:85:30 [INFO] [stdout] | [INFO] [stdout] 85 | LazyLock::new(|| Regex::new(r"^\n+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | static TITLE: LazyLock = LazyLock::new(|| Regex::new(r"^# +(.+?) *\n+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:115:30 [INFO] [stdout] | [INFO] [stdout] 115 | LazyLock::new(|| Regex::new(r"(.*\n*)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 273 | let context = self.context(config, articles); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let template = env.get_template(&format!("{}.jinja", self.template_name()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | / template [INFO] [stdout] 276 | | .render(&context) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:332:23 [INFO] [stdout] | [INFO] [stdout] 327 | article_regex: Option, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | root_dir: root_dir.canonicalize().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 355 | fn collect_markdown(&self, src_dir: impl AsRef) -> Result> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | / glob::glob(&format!("{}/**/*.md", src_dir.as_ref().display()))? [INFO] [stdout] 357 | | .filter_map(std::result::Result::ok) [INFO] [stdout] 358 | | .flat_map(|f| { [INFO] [stdout] 359 | | if let Some(ref regex) = self.article_regex { [INFO] [stdout] ... | [INFO] [stdout] 380 | | .collect::>>() [INFO] [stdout] 381 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:85:30 [INFO] [stdout] | [INFO] [stdout] 85 | LazyLock::new(|| Regex::new(r"^\n+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:87:58 [INFO] [stdout] | [INFO] [stdout] 87 | static TITLE: LazyLock = LazyLock::new(|| Regex::new(r"^# +(.+?) *\n+").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:115:30 [INFO] [stdout] | [INFO] [stdout] 115 | LazyLock::new(|| Regex::new(r"(.*\n*)").unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:275:9 [INFO] [stdout] | [INFO] [stdout] 273 | let context = self.context(config, articles); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 274 | let template = env.get_template(&format!("{}.jinja", self.template_name()))?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 275 | / template [INFO] [stdout] 276 | | .render(&context) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_____________________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `site` (lib) due to 7 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:332:23 [INFO] [stdout] | [INFO] [stdout] 327 | article_regex: Option, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | root_dir: root_dir.canonicalize().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/site.rs:356:9 [INFO] [stdout] | [INFO] [stdout] 355 | fn collect_markdown(&self, src_dir: impl AsRef) -> Result> { [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 356 | / glob::glob(&format!("{}/**/*.md", src_dir.as_ref().display()))? [INFO] [stdout] 357 | | .filter_map(std::result::Result::ok) [INFO] [stdout] 358 | | .flat_map(|f| { [INFO] [stdout] 359 | | if let Some(ref regex) = self.article_regex { [INFO] [stdout] ... | [INFO] [stdout] 380 | | .collect::>>() [INFO] [stdout] 381 | | .into_iter() [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `site` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "38cd84706365dc031f404225ec055ee0b4450fdfca35198c2ad063145b71968b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38cd84706365dc031f404225ec055ee0b4450fdfca35198c2ad063145b71968b", kill_on_drop: false }` [INFO] [stdout] 38cd84706365dc031f404225ec055ee0b4450fdfca35198c2ad063145b71968b