[INFO] fetching crate singleton-manager 0.1.4... [INFO] checking singleton-manager-0.1.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate singleton-manager 0.1.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate singleton-manager 0.1.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-1-tc2/source/rust-toolchain [INFO] started tweaking crates.io crate singleton-manager 0.1.4 [INFO] finished tweaking crates.io crate singleton-manager 0.1.4 [INFO] tweaked toml for crates.io crate singleton-manager 0.1.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9c6f4bf02a5b696a3492042c8cd1fcfd9d0d697a1c3b117b6cd434c0b00adc6a [INFO] running `Command { std: "docker" "start" "-a" "9c6f4bf02a5b696a3492042c8cd1fcfd9d0d697a1c3b117b6cd434c0b00adc6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9c6f4bf02a5b696a3492042c8cd1fcfd9d0d697a1c3b117b6cd434c0b00adc6a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9c6f4bf02a5b696a3492042c8cd1fcfd9d0d697a1c3b117b6cd434c0b00adc6a", kill_on_drop: false }` [INFO] [stdout] 9c6f4bf02a5b696a3492042c8cd1fcfd9d0d697a1c3b117b6cd434c0b00adc6a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6bfa4353bcc161a87299b39df267bfcf59a0bcd02731435e9a6eae141c656fed [INFO] running `Command { std: "docker" "start" "-a" "6bfa4353bcc161a87299b39df267bfcf59a0bcd02731435e9a6eae141c656fed", kill_on_drop: false }` [INFO] [stderr] Checking singleton-manager v0.1.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::ops::Deref` [INFO] [stdout] --> src/lib.rs:434:9 [INFO] [stdout] | [INFO] [stdout] 434 | use std::ops::Deref; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:310:49 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn set(&self, service_name: &str, service: T) -> Result<&'static mut T> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | sm().store_alias(service_name).and_then(|id| { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 311 | | sm().singleton_set(id, Box::new(service)) [INFO] [stdout] 312 | | .and_then(|service_box| { [INFO] [stdout] 313 | | service_box.downcast_mut::().ok_or_else(|| { [INFO] [stdout] ... | [INFO] [stdout] 316 | | }) [INFO] [stdout] 317 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:36 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn set(&self, service_name: &str, service: T) -> Result<&'static mut T> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | sm().store_alias(service_name).and_then(|id| { [INFO] [stdout] 311 | sm().singleton_set(id, Box::new(service)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:326:23 [INFO] [stdout] | [INFO] [stdout] 323 | factory: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | .and_then(|id| sm().singleton_factory_set(&id, Box::new(factory))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:326:60 [INFO] [stdout] | [INFO] [stdout] 323 | factory: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | .and_then(|id| sm().singleton_factory_set(&id, Box::new(factory))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `singleton-manager` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:310:49 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn set(&self, service_name: &str, service: T) -> Result<&'static mut T> { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | sm().store_alias(service_name).and_then(|id| { [INFO] [stdout] | _________________________________________________^ [INFO] [stdout] 311 | | sm().singleton_set(id, Box::new(service)) [INFO] [stdout] 312 | | .and_then(|service_box| { [INFO] [stdout] 313 | | service_box.downcast_mut::().ok_or_else(|| { [INFO] [stdout] ... | [INFO] [stdout] 316 | | }) [INFO] [stdout] 317 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:311:36 [INFO] [stdout] | [INFO] [stdout] 309 | pub fn set(&self, service_name: &str, service: T) -> Result<&'static mut T> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | sm().store_alias(service_name).and_then(|id| { [INFO] [stdout] 311 | sm().singleton_set(id, Box::new(service)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:326:23 [INFO] [stdout] | [INFO] [stdout] 323 | factory: F, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | .and_then(|id| sm().singleton_factory_set(&id, Box::new(factory))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:326:60 [INFO] [stdout] | [INFO] [stdout] 323 | factory: F, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 326 | .and_then(|id| sm().singleton_factory_set(&id, Box::new(factory))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `singleton-manager` (lib test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "6bfa4353bcc161a87299b39df267bfcf59a0bcd02731435e9a6eae141c656fed", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6bfa4353bcc161a87299b39df267bfcf59a0bcd02731435e9a6eae141c656fed", kill_on_drop: false }` [INFO] [stdout] 6bfa4353bcc161a87299b39df267bfcf59a0bcd02731435e9a6eae141c656fed