[INFO] fetching crate sine_cache 0.2.0... [INFO] checking sine_cache-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sine_cache 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate sine_cache 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sine_cache 0.2.0 [INFO] finished tweaking crates.io crate sine_cache 0.2.0 [INFO] tweaked toml for crates.io crate sine_cache 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 59 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 32d4a8741df785ac67111170dd47c4ca4bc9a0420a9bbce3e9aa2b7ce0a4dc7b [INFO] running `Command { std: "docker" "start" "-a" "32d4a8741df785ac67111170dd47c4ca4bc9a0420a9bbce3e9aa2b7ce0a4dc7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "32d4a8741df785ac67111170dd47c4ca4bc9a0420a9bbce3e9aa2b7ce0a4dc7b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "32d4a8741df785ac67111170dd47c4ca4bc9a0420a9bbce3e9aa2b7ce0a4dc7b", kill_on_drop: false }` [INFO] [stdout] 32d4a8741df785ac67111170dd47c4ca4bc9a0420a9bbce3e9aa2b7ce0a4dc7b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 21b94ab52b6f5cdc2521d83891b144fcb278795f7154be9ebd60a92cb72a9867 [INFO] running `Command { std: "docker" "start" "-a" "21b94ab52b6f5cdc2521d83891b144fcb278795f7154be9ebd60a92cb72a9867", kill_on_drop: false }` [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking sine_cache v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `eviction_policies::lru::LRU` [INFO] [stdout] --> src/eviction_policies/tests/lru.rs:3:14 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{ eviction_policies::lru::LRU}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::eviction_policies::common::EvictionPolicy` [INFO] [stdout] --> src/eviction_policies/tests/lru.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::eviction_policies::common::EvictionPolicy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `eviction_policies::lfu::LFU` [INFO] [stdout] --> src/eviction_policies/tests/lfu.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{eviction_policies::lfu::LFU}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::eviction_policies::common::EvictionPolicy` [INFO] [stdout] --> src/eviction_policies/tests/lfu.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::eviction_policies::common::EvictionPolicy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `eviction_policies::fifo::FIFO` [INFO] [stdout] --> src/eviction_policies/tests/fifo.rs:3:13 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{eviction_policies::fifo::FIFO}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `crate::eviction_policies::common::EvictionPolicy` [INFO] [stdout] --> src/eviction_policies/tests/fifo.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use crate::eviction_policies::common::EvictionPolicy; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `AOFRecord`, `AOFSubscriber`, `AOF`, `Operation`, and `cache_events::CacheEventSubscriber` [INFO] [stdout] --> src/tests/test_aof.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | aof::{AOFSubscriber, AOF}, cache_events::CacheEventSubscriber, common::{AOFRecord, Operation} [INFO] [stdout] | ^^^^^^^^^^^^^ ^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ ^^^^^^^^^ ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::distributions::WeightedIndex` [INFO] [stdout] --> src/tests/test_aof.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use rand::distributions::WeightedIndex; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rand::prelude::*` [INFO] [stdout] --> src/tests/test_aof.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use rand::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AOFSubscriber` [INFO] [stdout] --> src/tests/test_aof.rs:2:11 [INFO] [stdout] | [INFO] [stdout] 2 | aof::{AOFSubscriber, AOF}, cache_events::CacheEventSubscriber, common::{AOFRecord, Operation} [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/eviction_policies/lru.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | let mut current = node.as_ptr(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/eviction_policies/noevicton.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 19 | fn on_get(&mut self, key: &K) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/eviction_policies/noevicton.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | fn on_set(&mut self, key: K) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/eviction_policies/noevicton.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | fn remove(&mut self, key: K) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(config: CacheSyncConfig) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let max_size = config.get_config().max_size; [INFO] [stdout] 40 | let policy_type = config.get_policy_type(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Cache { [INFO] [stdout] 42 | cache: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(config: CacheSyncConfig) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let max_size = config.get_config().max_size; [INFO] [stdout] 40 | let policy_type = config.get_policy_type(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | eviction_policy: policy_type.create_policy() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_events.rs:53:77 [INFO] [stdout] | [INFO] [stdout] 49 | let aof_subscriber = Arc::new(AOFSubscriber::new(filedir, cache_name, flush_time).await); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | tokio::spawn(async move {periodic_flush(aof_subscriber.clone()).await}); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sine_cache` (lib) due to 4 previous errors; 13 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/eviction_policies/lru.rs:104:13 [INFO] [stdout] | [INFO] [stdout] 104 | let mut current = node.as_ptr(); [INFO] [stdout] | ----^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/eviction_policies/noevicton.rs:19:26 [INFO] [stdout] | [INFO] [stdout] 19 | fn on_get(&mut self, key: &K) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/eviction_policies/noevicton.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | fn on_set(&mut self, key: K) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `key` [INFO] [stdout] --> src/eviction_policies/noevicton.rs:32:26 [INFO] [stdout] | [INFO] [stdout] 32 | fn remove(&mut self, key: K) { [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_key` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:42:20 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(config: CacheSyncConfig) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let max_size = config.get_config().max_size; [INFO] [stdout] 40 | let policy_type = config.get_policy_type(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | Cache { [INFO] [stdout] 42 | cache: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache.rs:44:30 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new(config: CacheSyncConfig) -> Self { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 39 | let max_size = config.get_config().max_size; [INFO] [stdout] 40 | let policy_type = config.get_policy_type(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 44 | eviction_policy: policy_type.create_policy() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cache_events.rs:53:77 [INFO] [stdout] | [INFO] [stdout] 49 | let aof_subscriber = Arc::new(AOFSubscriber::new(filedir, cache_name, flush_time).await); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 53 | tokio::spawn(async move {periodic_flush(aof_subscriber.clone()).await}); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 5 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sine_cache` (lib test) due to 4 previous errors; 5 warnings emitted [INFO] running `Command { std: "docker" "inspect" "21b94ab52b6f5cdc2521d83891b144fcb278795f7154be9ebd60a92cb72a9867", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21b94ab52b6f5cdc2521d83891b144fcb278795f7154be9ebd60a92cb72a9867", kill_on_drop: false }` [INFO] [stdout] 21b94ab52b6f5cdc2521d83891b144fcb278795f7154be9ebd60a92cb72a9867