[INFO] fetching crate simple_modbus 0.1.1... [INFO] checking simple_modbus-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate simple_modbus 0.1.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate simple_modbus 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate simple_modbus 0.1.1 [INFO] finished tweaking crates.io crate simple_modbus 0.1.1 [INFO] tweaked toml for crates.io crate simple_modbus 0.1.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 48 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding env_logger v0.9.3 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5baa50e014599e4a0c9df58bf834e9486a5f128603db5427e0e55d910e5754de [INFO] running `Command { std: "docker" "start" "-a" "5baa50e014599e4a0c9df58bf834e9486a5f128603db5427e0e55d910e5754de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5baa50e014599e4a0c9df58bf834e9486a5f128603db5427e0e55d910e5754de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5baa50e014599e4a0c9df58bf834e9486a5f128603db5427e0e55d910e5754de", kill_on_drop: false }` [INFO] [stdout] 5baa50e014599e4a0c9df58bf834e9486a5f128603db5427e0e55d910e5754de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 79871f95e4eeab7d68198483bdfbff8696a89100df6b1c31f4ac54e0f20279d2 [INFO] running `Command { std: "docker" "start" "-a" "79871f95e4eeab7d68198483bdfbff8696a89100df6b1c31f4ac54e0f20279d2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling pkg-config v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Compiling libudev-sys v0.1.4 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking libudev v0.3.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking unescaper v0.1.5 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking serialport v4.5.0 [INFO] [stderr] Checking simple_modbus v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Instant` [INFO] [stdout] --> src/lib.rs:6:27 [INFO] [stdout] | [INFO] [stdout] 6 | use std::time::{Duration, Instant}; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking env_logger v0.9.3 [INFO] [stdout] warning: method `code` is never used [INFO] [stdout] --> src/lib.rs:314:8 [INFO] [stdout] | [INFO] [stdout] 313 | impl Coil { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] 314 | fn code(self) -> u16 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:48:12 [INFO] [stdout] | [INFO] [stdout] 47 | pub fn new(stream: Box) -> Result { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 48 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 49 | | stream, [INFO] [stdout] 50 | | need_reply: true, [INFO] [stdout] 51 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 89 | fn get_reply_data(&self, mut reply: Bytes) -> Result { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 101 | Ok(reply.split_to(len as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:159:29 [INFO] [stdout] | [INFO] [stdout] 157 | let (req, mut reply) = Self::build_buffer(fun)?; [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 158 | self.transfer(&req, &mut reply, false)?; [INFO] [stdout] 159 | self.get_reply_data(reply.freeze()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:238:12 [INFO] [stdout] | [INFO] [stdout] 169 | let (req, reply) = match fun { [INFO] [stdout] | --- ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 172 | let mut req = BytesMut::with_capacity(6 + 2); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | let reply = BytesMut::from(&reply[..]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let mut req = BytesMut::with_capacity(6 + 2 + 1 + byte_cnt as usize); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 206 | let reply = BytesMut::from(&reply[..]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 211 | let mut req = BytesMut::with_capacity(6 + 2); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | let reply = BytesMut::from(&reply[..]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | let req = BytesMut::from(&req[..]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 225 | let reply = BytesMut::from(&res[..]); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 238 | Ok((req.freeze(), reply)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serial.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 18 | let inner_device = serialport::new(port, baud_rate) [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 23 | | inner: inner_device, [INFO] [stdout] 24 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_modbus` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "79871f95e4eeab7d68198483bdfbff8696a89100df6b1c31f4ac54e0f20279d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "79871f95e4eeab7d68198483bdfbff8696a89100df6b1c31f4ac54e0f20279d2", kill_on_drop: false }` [INFO] [stdout] 79871f95e4eeab7d68198483bdfbff8696a89100df6b1c31f4ac54e0f20279d2