[INFO] fetching crate simple_ml 0.3.2... [INFO] checking simple_ml-0.3.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate simple_ml 0.3.2 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate simple_ml 0.3.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate simple_ml 0.3.2 [INFO] finished tweaking crates.io crate simple_ml 0.3.2 [INFO] tweaked toml for crates.io crate simple_ml 0.3.2 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate simple_ml 0.3.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a06b0b254e994b781dd57a3a746e1c3153acc0c89d0b3d01d203c882085ca93b [INFO] running `Command { std: "docker" "start" "-a" "a06b0b254e994b781dd57a3a746e1c3153acc0c89d0b3d01d203c882085ca93b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a06b0b254e994b781dd57a3a746e1c3153acc0c89d0b3d01d203c882085ca93b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a06b0b254e994b781dd57a3a746e1c3153acc0c89d0b3d01d203c882085ca93b", kill_on_drop: false }` [INFO] [stdout] a06b0b254e994b781dd57a3a746e1c3153acc0c89d0b3d01d203c882085ca93b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fcfbbe9a542c96c318ffdb50a18b251e4e707667815e419f81782e588f1d60b [INFO] running `Command { std: "docker" "start" "-a" "3fcfbbe9a542c96c318ffdb50a18b251e4e707667815e419f81782e588f1d60b", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.70 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Checking libmath v0.2.1 [INFO] [stderr] Checking simple_ml v0.3.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:1858:13 [INFO] [stdout] | [INFO] [stdout] 1858 | (a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64)) [INFO] [stdout] | ^ [INFO] [stdout] 1859 | * (a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64)))) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1858 ~ a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64)) [INFO] [stdout] 1859 ~ * (a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:3774:9 [INFO] [stdout] | [INFO] [stdout] 3774 | (actual / larger as f64) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 3774 - (actual / larger as f64) [INFO] [stdout] 3774 + actual / larger as f64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:1858:13 [INFO] [stdout] | [INFO] [stdout] 1858 | (a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64)) [INFO] [stdout] | ^ [INFO] [stdout] 1859 | * (a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64)))) [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 1858 ~ a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64)) [INFO] [stdout] 1859 ~ * (a - (actual.iter().fold(0., |a, b| a + b) / (actual.len() as f64))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/lib.rs:3774:9 [INFO] [stdout] | [INFO] [stdout] 3774 | (actual / larger as f64) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 3774 - (actual / larger as f64) [INFO] [stdout] 3774 + actual / larger as f64 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `new_mean` is never read [INFO] [stdout] --> src/lib.rs:877:17 [INFO] [stdout] | [INFO] [stdout] 877 | let mut new_mean: Vec> = vec![]; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `new_mean` is never read [INFO] [stdout] --> src/lib.rs:877:17 [INFO] [stdout] | [INFO] [stdout] 877 | let mut new_mean: Vec> = vec![]; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/lib.rs:496:13 [INFO] [stdout] | [INFO] [stdout] 496 | let X = [&b0_vec[..], &x[..]].concat(); // [1,1,1...,1,1,1]+X [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1218:24 [INFO] [stdout] | [INFO] [stdout] 1218 | .map(|x| (*x - mu.to_string().parse().unwrap()) * (*x - mu.to_string().parse().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1218:65 [INFO] [stdout] | [INFO] [stdout] 1218 | .map(|x| (*x - mu.to_string().parse().unwrap()) * (*x - mu.to_string().parse().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_ml` (lib) due to 3 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable `X` should have a snake case name [INFO] [stdout] --> src/lib.rs:496:13 [INFO] [stdout] | [INFO] [stdout] 496 | let X = [&b0_vec[..], &x[..]].concat(); // [1,1,1...,1,1,1]+X [INFO] [stdout] | ^ help: convert the identifier to snake case (notice the capitalization): `x` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1218:24 [INFO] [stdout] | [INFO] [stdout] 1218 | .map(|x| (*x - mu.to_string().parse().unwrap()) * (*x - mu.to_string().parse().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1218:65 [INFO] [stdout] | [INFO] [stdout] 1218 | .map(|x| (*x - mu.to_string().parse().unwrap()) * (*x - mu.to_string().parse().unwrap())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple_ml` (lib test) due to 3 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "3fcfbbe9a542c96c318ffdb50a18b251e4e707667815e419f81782e588f1d60b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fcfbbe9a542c96c318ffdb50a18b251e4e707667815e419f81782e588f1d60b", kill_on_drop: false }` [INFO] [stdout] 3fcfbbe9a542c96c318ffdb50a18b251e4e707667815e419f81782e588f1d60b