[INFO] fetching crate simple-raft 0.2.0... [INFO] checking simple-raft-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate simple-raft 0.2.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate simple-raft 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate simple-raft 0.2.0 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate simple-raft 0.2.0 [INFO] tweaked toml for crates.io crate simple-raft 0.2.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] crate crates.io crate simple-raft 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 7ec16c5e14e86d3ea421b34804c566fcf97a1dac10c866fb8ff87150e89242bf [INFO] running `Command { std: "docker" "start" "-a" "7ec16c5e14e86d3ea421b34804c566fcf97a1dac10c866fb8ff87150e89242bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "7ec16c5e14e86d3ea421b34804c566fcf97a1dac10c866fb8ff87150e89242bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "7ec16c5e14e86d3ea421b34804c566fcf97a1dac10c866fb8ff87150e89242bf", kill_on_drop: false }` [INFO] [stdout] 7ec16c5e14e86d3ea421b34804c566fcf97a1dac10c866fb8ff87150e89242bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 46aa22eaa00c305cbe89ea7f22ee1d9ff4fc929991e9d3ff3cbfe12e09d26804 [INFO] running `Command { std: "docker" "start" "-a" "46aa22eaa00c305cbe89ea7f22ee1d9ff4fc929991e9d3ff3cbfe12e09d26804", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `env_logger` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling syn v1.0.77 [INFO] [stderr] Compiling anyhow v1.0.44 [INFO] [stderr] Compiling either v1.6.1 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking bytes v1.1.0 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Compiling itertools v0.9.0 [INFO] [stderr] Checking env_logger v0.8.4 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Compiling prost-derive v0.7.0 [INFO] [stderr] Compiling derive_more v0.99.16 [INFO] [stderr] Checking prost v0.7.0 [INFO] [stderr] Checking simple-raft v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `test` [INFO] [stdout] --> src/log.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 25 | #[cfg(any(feature = "test", test))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `prost` [INFO] [stdout] = help: consider adding `test` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `format` and `vec` [INFO] [stdout] --> src/prelude.rs:18:17 [INFO] [stdout] | [INFO] [stdout] 18 | pub use alloc::{format, vec}; [INFO] [stdout] | ^^^^^^ ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Box` [INFO] [stdout] --> src/prelude.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | pub use alloc::boxed::{Box}; [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `String` [INFO] [stdout] --> src/prelude.rs:21:25 [INFO] [stdout] | [INFO] [stdout] 21 | pub use alloc::string::{String, ToString}; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:134:27 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(node_id: NodeId, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | mut peers: BTreeSet, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | log: Log, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | mut random: Random, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 134 | log: RaftLogState::new(log), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:136:27 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(node_id: NodeId, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | mut peers: BTreeSet, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | log: Log, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | mut random: Random, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 136 | voted_for: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:137:27 [INFO] [stdout] | [INFO] [stdout] 121 | pub fn new(node_id: NodeId, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | mut peers: BTreeSet, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | log: Log, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | mut random: Random, [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 137 | leadership: Follower(FollowerState { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 138 | | leader: None, [INFO] [stdout] 139 | | election_ticks: random_election_ticks, [INFO] [stdout] 140 | | random_election_ticks, [INFO] [stdout] 141 | | }), [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:265:85 [INFO] [stdout] | [INFO] [stdout] 264 | let from = peer_node_id; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 265 | vote_request.map(|message| SendableRaftMessage { message, dest: RaftMessageDestination::To(from) }) [INFO] [stdout] | ------- ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:313:27 [INFO] [stdout] | [INFO] [stdout] 311 | self.request_vote().map(|message| SendableRaftMessage { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 312 | message, [INFO] [stdout] 313 | dest: RaftMessageDestination::Broadcast, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core.rs:558:14 [INFO] [stdout] | [INFO] [stdout] 514 | from: NodeId) [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 552 | let message = RaftMessage { // /\ Reply([ [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 558 | Some(SendableRaftMessage { message, dest: RaftMessageDestination::To(from) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for a method [INFO] [stdout] --> src/message.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 65 | #[cfg_attr(feature = "prost", derive(prost::Oneof))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/lib.rs:120:9 [INFO] [stdout] | [INFO] [stdout] 120 | #![warn(missing_docs)] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] = note: this warning originates in the derive macro `prost::Oneof` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: missing documentation for an associated function [INFO] [stdout] --> src/message.rs:65:38 [INFO] [stdout] | [INFO] [stdout] 65 | #[cfg_attr(feature = "prost", derive(prost::Oneof))] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the derive macro `prost::Oneof` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:118:20 [INFO] [stdout] | [INFO] [stdout] 111 | node_id: NodeId, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 112 | peers: BTreeSet, [INFO] [stdout] | ------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | log: Log, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 114 | random: Random, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | state: RaftState::new( [INFO] [stdout] | ____________________^ [INFO] [stdout] 119 | | node_id, [INFO] [stdout] 120 | | peers, [INFO] [stdout] 121 | | log, [INFO] [stdout] 122 | | random, [INFO] [stdout] 123 | | config, [INFO] [stdout] 124 | | ), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:141:12 [INFO] [stdout] | [INFO] [stdout] 139 | pub fn append>(&mut self, data: T) -> Result> + '_, AppendError [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:201:9 [INFO] [stdout] | [INFO] [stdout] 197 | message: RaftMessage, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | from: NodeId, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) -> impl Iterator> + '_ { [INFO] [stdout] 200 | let message = self.state.receive(message, from); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | message.into_iter().chain(self.append_entries()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:201:35 [INFO] [stdout] | [INFO] [stdout] 197 | message: RaftMessage, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | from: NodeId, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | ) -> impl Iterator> + '_ { [INFO] [stdout] 200 | let message = self.state.receive(message, from); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 201 | message.into_iter().chain(self.append_entries()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:237:9 [INFO] [stdout] | [INFO] [stdout] 236 | let message = self.state.timer_tick(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | message.into_iter().chain(self.append_entries()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/node.rs:237:35 [INFO] [stdout] | [INFO] [stdout] 236 | let message = self.state.timer_tick(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 237 | message.into_iter().chain(self.append_entries()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 12 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-raft` (lib) due to 13 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "46aa22eaa00c305cbe89ea7f22ee1d9ff4fc929991e9d3ff3cbfe12e09d26804", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "46aa22eaa00c305cbe89ea7f22ee1d9ff4fc929991e9d3ff3cbfe12e09d26804", kill_on_drop: false }` [INFO] [stdout] 46aa22eaa00c305cbe89ea7f22ee1d9ff4fc929991e9d3ff3cbfe12e09d26804