[INFO] fetching crate simple-git 0.2.12... [INFO] checking simple-git-0.2.12 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate simple-git 0.2.12 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate simple-git 0.2.12 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate simple-git 0.2.12 [INFO] finished tweaking crates.io crate simple-git 0.2.12 [INFO] tweaked toml for crates.io crate simple-git 0.2.12 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 260 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding core-foundation v0.9.4 (latest: v0.10.0) [INFO] [stderr] Adding foreign-types v0.3.2 (latest: v0.5.0) [INFO] [stderr] Adding foreign-types-shared v0.1.1 (latest: v0.3.1) [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding hermit-abi v0.3.9 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding prodash v28.0.0 (latest: v29.0.0) [INFO] [stderr] Adding tower v0.4.13 (latest: v0.5.0) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2cb249f4ac054698a88fad777acb90011206fd7a1932ed68cac89245908314f8 [INFO] running `Command { std: "docker" "start" "-a" "2cb249f4ac054698a88fad777acb90011206fd7a1932ed68cac89245908314f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2cb249f4ac054698a88fad777acb90011206fd7a1932ed68cac89245908314f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cb249f4ac054698a88fad777acb90011206fd7a1932ed68cac89245908314f8", kill_on_drop: false }` [INFO] [stdout] 2cb249f4ac054698a88fad777acb90011206fd7a1932ed68cac89245908314f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 665f524bc84099ea3a93ee818c1459fdb52966af3336fb93827143d5955835fb [INFO] running `Command { std: "docker" "start" "-a" "665f524bc84099ea3a93ee818c1459fdb52966af3336fb93827143d5955835fb", kill_on_drop: false }` [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking gix-trace v0.1.9 [INFO] [stderr] Checking faster-hex v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking human_format v1.1.0 [INFO] [stderr] Checking sha1_smol v1.0.1 [INFO] [stderr] Checking gix-utils v0.1.12 [INFO] [stderr] Checking flate2 v1.0.33 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking jiff v0.1.12 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking winnow v0.6.18 [INFO] [stderr] Checking walkdir v2.5.0 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking memmap2 v0.9.4 [INFO] [stderr] Checking gix-hash v0.14.2 [INFO] [stderr] Checking prodash v28.0.0 [INFO] [stderr] Checking gix-chunk v0.4.8 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking unicode-bom v2.0.3 [INFO] [stderr] Checking static_assertions v1.1.0 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking kstring v2.0.2 [INFO] [stderr] Checking gix-sec v0.10.8 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking tower-layer v0.3.3 [INFO] [stderr] Checking sync_wrapper v1.0.1 [INFO] [stderr] Checking gix-bitmap v0.2.11 [INFO] [stderr] Checking filetime v0.2.25 [INFO] [stderr] Checking arrayvec v0.7.6 [INFO] [stderr] Checking clru v0.6.2 [INFO] [stderr] Compiling maybe-async v0.2.10 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking io-close v0.3.7 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Compiling derive_destructure2 v0.1.3 [INFO] [stderr] Checking compact_str v0.8.0 [INFO] [stderr] Checking uluru v3.1.0 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking gix-hashtable v0.5.2 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking bstr v1.10.0 [INFO] [stderr] Checking gix-features v0.38.2 [INFO] [stderr] Checking gix-fs v0.11.3 [INFO] [stderr] Checking gix-path v0.10.10 [INFO] [stderr] Checking gix-validate v0.9.0 [INFO] [stderr] Checking gix-quote v0.4.12 [INFO] [stderr] Checking gix-commitgraph v0.24.3 [INFO] [stderr] Checking gix-packetline v0.17.6 [INFO] [stderr] Checking gix-packetline-blocking v0.17.5 [INFO] [stderr] Checking gix-glob v0.16.5 [INFO] [stderr] Checking gix-config-value v0.14.8 [INFO] [stderr] Checking gix-command v0.3.9 [INFO] [stderr] Checking gix-url v0.27.5 [INFO] [stderr] Checking gix-attributes v0.22.5 [INFO] [stderr] Checking gix-ignore v0.11.4 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking gix-prompt v0.8.7 [INFO] [stderr] Checking gix-pathspec v0.7.7 [INFO] [stderr] Checking gix-credentials v0.24.5 [INFO] [stderr] Checking gix-tempfile v14.0.2 [INFO] [stderr] Checking gix-lock v14.0.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Checking tokio-util v0.7.11 [INFO] [stderr] Checking tower v0.4.13 [INFO] [stderr] Checking gix-date v0.9.0 [INFO] [stderr] Checking gix-actor v0.32.0 [INFO] [stderr] Checking gix-object v0.44.0 [INFO] [stderr] Checking h2 v0.4.6 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking gix-revwalk v0.15.0 [INFO] [stderr] Checking gix-ref v0.47.0 [INFO] [stderr] Checking gix-filter v0.13.0 [INFO] [stderr] Checking gix-pack v0.53.0 [INFO] [stderr] Checking gix-diff v0.46.0 [INFO] [stderr] Checking gix-traverse v0.41.0 [INFO] [stderr] Checking gix-revision v0.29.0 [INFO] [stderr] Checking gix-negotiate v0.15.0 [INFO] [stderr] Checking gix-refspec v0.25.0 [INFO] [stderr] Checking gix-index v0.35.0 [INFO] [stderr] Checking gix-config v0.40.0 [INFO] [stderr] Checking gix-discover v0.35.0 [INFO] [stderr] Checking gix-odb v0.63.0 [INFO] [stderr] Checking gix-worktree v0.36.0 [INFO] [stderr] Checking gix-worktree-state v0.13.0 [INFO] [stderr] Checking hyper v1.4.1 [INFO] [stderr] Checking gix-submodule v0.14.0 [INFO] [stderr] Checking hyper-util v0.1.7 [INFO] [stderr] Checking reqwest v0.12.7 [INFO] [stderr] Checking gix-transport v0.42.3 [INFO] [stderr] Checking gix-protocol v0.45.3 [INFO] [stderr] Checking gix v0.66.0 [INFO] [stderr] Checking simple-git v0.2.12 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 68 | cancellation_token: Option, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Self( [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | Self::prepare_fetch(url, path, create::Kind::Bare)? [INFO] [stdout] 74 | | .fetch_only( [INFO] [stdout] 75 | | &mut TracingProgress::new("Cloning bare"), [INFO] [stdout] ... | [INFO] [stdout] 83 | | .into(), [INFO] [stdout] 84 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 94 | cancellation_token: Option, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let mut progress = TracingProgress::new("Cloning with worktree"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | Ok(Self( [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | Self::prepare_fetch(url, path, create::Kind::WithWorktree)? [INFO] [stdout] 102 | | .fetch_then_checkout(&mut progress, &AtomicBool::new(false)) [INFO] [stdout] 103 | | .map_err(GitErrorInner::from)? [INFO] [stdout] ... | [INFO] [stdout] 114 | | .into(), [INFO] [stdout] 115 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 32 | let trigger = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | name: CompactString::new(name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 32 | let trigger = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | step: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 32 | let trigger = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | unit: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:150:19 [INFO] [stdout] | [INFO] [stdout] 146 | fn add_child_with_id(&mut self, name: impl Into, id: Id) -> Self::SubProgress { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | step: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 146 | fn add_child_with_id(&mut self, name: impl Into, id: Id) -> Self::SubProgress { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | unit: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 146 | fn add_child_with_id(&mut self, name: impl Into, id: Id) -> Self::SubProgress { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | trigger: Arc::clone(&self.trigger), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cancellation_token.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn disarm(self) -> GitCancellationToken { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.destructure().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:31:33 [INFO] [stdout] | [INFO] [stdout] 30 | fn from(e: clone::Error) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self::PrepareFetchError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(e: clone::fetch::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self::FetchError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 42 | fn from(e: clone::checkout::main_worktree::Error) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Self::CheckOutError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 48 | fn from(e: gix::reference::head_commit::Error) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self::HeadCommit(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 54 | fn from(e: gix::object::commit::Error) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Self::GetTreeOfCommit(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 60 | fn from(e: gix::object::find::existing::Error) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self::ObjectLookup(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 68 | cancellation_token: Option, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Self( [INFO] [stdout] | ____________^ [INFO] [stdout] 73 | | Self::prepare_fetch(url, path, create::Kind::Bare)? [INFO] [stdout] 74 | | .fetch_only( [INFO] [stdout] 75 | | &mut TracingProgress::new("Cloning bare"), [INFO] [stdout] ... | [INFO] [stdout] 83 | | .into(), [INFO] [stdout] 84 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:100:12 [INFO] [stdout] | [INFO] [stdout] 94 | cancellation_token: Option, [INFO] [stdout] | ------------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | let mut progress = TracingProgress::new("Cloning with worktree"); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 99 | [INFO] [stdout] 100 | Ok(Self( [INFO] [stdout] | ____________^ [INFO] [stdout] 101 | | Self::prepare_fetch(url, path, create::Kind::WithWorktree)? [INFO] [stdout] 102 | | .fetch_then_checkout(&mut progress, &AtomicBool::new(false)) [INFO] [stdout] 103 | | .map_err(GitErrorInner::from)? [INFO] [stdout] ... | [INFO] [stdout] 114 | | .into(), [INFO] [stdout] 115 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:47:19 [INFO] [stdout] | [INFO] [stdout] 32 | let trigger = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 47 | name: CompactString::new(name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:50:19 [INFO] [stdout] | [INFO] [stdout] 32 | let trigger = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | step: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:51:19 [INFO] [stdout] | [INFO] [stdout] 32 | let trigger = Arc::new(AtomicBool::new(true)); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | unit: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:150:19 [INFO] [stdout] | [INFO] [stdout] 146 | fn add_child_with_id(&mut self, name: impl Into, id: Id) -> Self::SubProgress { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 150 | step: Arc::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:152:19 [INFO] [stdout] | [INFO] [stdout] 146 | fn add_child_with_id(&mut self, name: impl Into, id: Id) -> Self::SubProgress { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 152 | unit: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/progress_tracing.rs:153:22 [INFO] [stdout] | [INFO] [stdout] 146 | fn add_child_with_id(&mut self, name: impl Into, id: Id) -> Self::SubProgress { [INFO] [stdout] | ----------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 153 | trigger: Arc::clone(&self.trigger), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cancellation_token.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 41 | pub fn disarm(self) -> GitCancellationToken { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 42 | self.destructure().0 [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:31:33 [INFO] [stdout] | [INFO] [stdout] 30 | fn from(e: clone::Error) -> Self { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 31 | Self::PrepareFetchError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:37:26 [INFO] [stdout] | [INFO] [stdout] 36 | fn from(e: clone::fetch::Error) -> Self { [INFO] [stdout] | ---------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 37 | Self::FetchError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:43:29 [INFO] [stdout] | [INFO] [stdout] 42 | fn from(e: clone::checkout::main_worktree::Error) -> Self { [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 43 | Self::CheckOutError(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:49:26 [INFO] [stdout] | [INFO] [stdout] 48 | fn from(e: gix::reference::head_commit::Error) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 49 | Self::HeadCommit(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:55:31 [INFO] [stdout] | [INFO] [stdout] 54 | fn from(e: gix::object::commit::Error) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 55 | Self::GetTreeOfCommit(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:61:28 [INFO] [stdout] | [INFO] [stdout] 60 | fn from(e: gix::object::find::existing::Error) -> Self { [INFO] [stdout] | ------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | Self::ObjectLookup(Box::new(e)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-git` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `simple-git` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "665f524bc84099ea3a93ee818c1459fdb52966af3336fb93827143d5955835fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "665f524bc84099ea3a93ee818c1459fdb52966af3336fb93827143d5955835fb", kill_on_drop: false }` [INFO] [stdout] 665f524bc84099ea3a93ee818c1459fdb52966af3336fb93827143d5955835fb