[INFO] fetching crate similari 0.26.2... [INFO] checking similari-0.26.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate similari 0.26.2 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate similari 0.26.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] removed /workspace/builds/worker-4-tc2/source/.cargo/config [INFO] started tweaking crates.io crate similari 0.26.2 [INFO] finished tweaking crates.io crate similari 0.26.2 [INFO] tweaked toml for crates.io crate similari 0.26.2 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate similari 0.26.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 1f7fa43ec1cb3629adf484813db5ffb9f451a6617473bec5cf757bcf022f0d50 [INFO] running `Command { std: "docker" "start" "-a" "1f7fa43ec1cb3629adf484813db5ffb9f451a6617473bec5cf757bcf022f0d50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "1f7fa43ec1cb3629adf484813db5ffb9f451a6617473bec5cf757bcf022f0d50", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1f7fa43ec1cb3629adf484813db5ffb9f451a6617473bec5cf757bcf022f0d50", kill_on_drop: false }` [INFO] [stdout] 1f7fa43ec1cb3629adf484813db5ffb9f451a6617473bec5cf757bcf022f0d50 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 201bde8f37bc1d28e7480af740a4affa4d4237ff821d0182ec97e1dbe6710fa7 [INFO] running `Command { std: "docker" "start" "-a" "201bde8f37bc1d28e7480af740a4affa4d4237ff821d0182ec97e1dbe6710fa7", kill_on_drop: false }` [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.139 [INFO] [stderr] Compiling libm v0.2.2 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling target-lexicon v0.12.4 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Compiling proc-macro2 v1.0.40 [INFO] [stderr] Compiling quote v1.0.20 [INFO] [stderr] Compiling unicode-ident v1.0.1 [INFO] [stderr] Compiling syn v1.0.98 [INFO] [stderr] Compiling lock_api v0.4.7 [INFO] [stderr] Compiling once_cell v1.17.1 [INFO] [stderr] Compiling crossbeam-utils v0.8.10 [INFO] [stderr] Compiling semver v1.0.12 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Compiling crossbeam-epoch v0.9.9 [INFO] [stderr] Checking smallvec v1.9.0 [INFO] [stderr] Checking bytemuck v1.10.0 [INFO] [stderr] Compiling io-lifetimes v1.0.6 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Checking safe_arch v0.6.0 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Compiling parking_lot_core v0.9.3 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Compiling rustix v0.36.9 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling indexmap v1.9.2 [INFO] [stderr] Compiling memoffset v0.8.0 [INFO] [stderr] Compiling crossbeam-queue v0.3.5 [INFO] [stderr] Checking spin v0.9.4 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking linux-raw-sys v0.1.4 [INFO] [stderr] Compiling heapless v0.7.15 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Compiling thiserror v1.0.39 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Checking crossbeam-channel v0.5.5 [INFO] [stderr] Checking crossbeam-deque v0.8.1 [INFO] [stderr] Checking regex-syntax v0.6.27 [INFO] [stderr] Checking aho-corasick v0.7.18 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Compiling pyo3-build-config v0.18.1 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Compiling paste v1.0.7 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking wide v0.7.4 [INFO] [stderr] Compiling anyhow v1.0.58 [INFO] [stderr] Checking geographiclib-rs v0.2.1 [INFO] [stderr] Checking matrixmultiply v0.3.2 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking rustc-hash v1.1.0 [INFO] [stderr] Checking termcolor v1.2.0 [INFO] [stderr] Checking robust v0.2.3 [INFO] [stderr] Compiling indoc v1.0.7 [INFO] [stderr] Checking unindent v0.1.10 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking num_cpus v1.15.0 [INFO] [stderr] Checking crossbeam v0.8.1 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rstar v0.9.3 [INFO] [stderr] Checking num-complex v0.4.2 [INFO] [stderr] Checking float_next_after v0.1.5 [INFO] [stderr] Checking integer-sqrt v0.1.5 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling pyo3-ffi v0.18.1 [INFO] [stderr] Compiling pyo3 v0.18.1 [INFO] [stderr] Compiling similari v0.26.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking regex v1.6.0 [INFO] [stderr] Checking geo-types v0.7.8 [INFO] [stderr] Checking simba v0.8.0 [INFO] [stderr] Checking ultraviolet v0.9.0 [INFO] [stderr] Checking geo v0.23.0 [INFO] [stderr] Checking is-terminal v0.4.4 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Compiling pyo3-macros-backend v0.18.1 [INFO] [stderr] Compiling thiserror-impl v1.0.39 [INFO] [stderr] Compiling nalgebra-macros v0.2.0 [INFO] [stderr] Checking pathfinding v4.2.1 [INFO] [stderr] Compiling pyo3-macros v0.18.1 [INFO] [stderr] Checking nalgebra v0.32.2 [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/trackers/tracker_api.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut obj = self.get_auto_waste_obj_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/track/store.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | MergeResult(Result<()>), [INFO] [stdout] | ----------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Results` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 66 | MergeResult(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/utils/point.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Point2D(f32, f32); [INFO] [stdout] | ------- ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track.rs:629:30 [INFO] [stdout] | [INFO] [stdout] 622 | let (attribute_metric, feature_distance) = self.metric.metric( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Some(ObservationMetricOk { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 630 | | from: self.track_id, [INFO] [stdout] 631 | | to: other.track_id, [INFO] [stdout] 632 | | attribute_metric, [INFO] [stdout] 633 | | feature_distance, [INFO] [stdout] 634 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:295:51 [INFO] [stdout] | [INFO] [stdout] 295 | ... .map(|x| (x.track_id, x.get_attributes().baked(&x.observations))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:333:24 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn new(metric: M, default_attributes: TA, notifier: N, shards: usize) -> Self { [INFO] [stdout] | --------- ---------------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let stores = Arc::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let my_stores = stores.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | executors: { [INFO] [stdout] | ________________________^ [INFO] [stdout] 334 | | (0..shards) [INFO] [stdout] 335 | | .map(|s| { [INFO] [stdout] 336 | | let (commands_sender, commands_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | .collect() [INFO] [stdout] 344 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:321:37 [INFO] [stdout] | [INFO] [stdout] 321 | .map(|_| Mutex::new(HashMap::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 431 | tracks: Vec>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | let (results_ok_sender, results_ok_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | let (results_err_sender, results_err_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | TrackDistanceOk::new(count, results_ok_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 431 | tracks: Vec>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | let (results_ok_sender, results_ok_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | let (results_err_sender, results_err_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | TrackDistanceErr::new(count, results_err_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:597:15 [INFO] [stdout] | [INFO] [stdout] 592 | let mut src = self.fetch_tracks(&[src_id]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 596 | let src = src.pop().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 597 | match self.merge_external(dest_id, &src, classes, merge_history) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:659:12 [INFO] [stdout] | [INFO] [stdout] 628 | src: Track, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 632 | let (results_sender, results_receiver) = crossbeam::channel::bounded(1); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | let command = Commands::Merge( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 648 | let res = cmd.send(command); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | Ok(FutureMergeResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 660 | | _sender: results_sender, [INFO] [stdout] 661 | | receiver: results_receiver, [INFO] [stdout] 662 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/builder.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn build(self) -> TrackStore { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | TrackStore::new( [INFO] [stdout] 96 | self.metric.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/builder.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn build(self) -> TrackStore { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | self.default_attributes.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/builder.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn build(self) -> TrackStore { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | self.notifier.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/track_distance.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 150 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | current_chunk: Vec::default().into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/track_distance.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 166 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | current_chunk: Vec::default().into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort.rs:128:15 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn new(opts: Arc) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/simple_api.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 203 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | [INFO] [stdout] 205 | / store [INFO] [stdout] 206 | | .lookup(SortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/sort_py.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | let (batch, result) = PredictionBatchRequest::new(); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | result: Some(result), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:208:22 [INFO] [stdout] | [INFO] [stdout] 170 | let opts = Arc::new(SortAttributesOptions::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let store = Arc::new(RwLock::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let wasted_store = RwLock::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let track_id = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | [INFO] [stdout] 195 | let voting_threads = (0..voting_shards) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | monitor: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 197 | let (tx, rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | let thread_store = store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let thread_track_id = track_id.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | spawn(move || voting_thread(thread_store, rx, method, thread_track_id)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 295 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | [INFO] [stdout] 297 | / store [INFO] [stdout] 298 | | .lookup(SortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:468:9 [INFO] [stdout] | [INFO] [stdout] 466 | fn predict_py(&mut self, mut batch: PySortPredictionBatchRequest) -> PredictionBatchResult { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | self.predict(batch.batch); [INFO] [stdout] 468 | batch.result.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/track_attributes.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(opts: Arc) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/simple_api.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 240 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | [INFO] [stdout] 242 | / store [INFO] [stdout] 243 | | .lookup(VisualSortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/visual_sort_py.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | let (batch, result) = PredictionBatchRequest::new(); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | result: Some(result), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/batch_api.rs:204:22 [INFO] [stdout] | [INFO] [stdout] 166 | let (track_opts, metric) = opts.clone().build(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let track_opts = Arc::new(track_opts); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let metric_opts = metric.opts.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let store = Arc::new(RwLock::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let wasted_store = RwLock::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let track_id = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | [INFO] [stdout] 187 | let voting_threads = (0..voting_shards) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | monitor: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/batch_api.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 189 | let (tx, rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let thread_store = store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let thread_track_id = track_id.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let thread_metric_opts = metric_opts.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | / spawn(move || { [INFO] [stdout] 197 | | voting_thread(thread_store, rx, thread_metric_opts, thread_track_id) [INFO] [stdout] 198 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/batch_api.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 328 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | [INFO] [stdout] 330 | / store [INFO] [stdout] 331 | | .lookup(VisualSortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/batch.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 84 | let (sender, receiver) = crossbeam::channel::bounded(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let batch_size = Arc::new(Mutex::new(0)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ( [INFO] [stdout] 87 | / Self { [INFO] [stdout] 88 | | batch: BatchRecords::default(), [INFO] [stdout] 89 | | sender, [INFO] [stdout] 90 | | batch_size: batch_size.clone(), [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/batch.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 84 | let (sender, receiver) = crossbeam::channel::bounded(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let batch_size = Arc::new(Mutex::new(0)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / PredictionBatchResult { [INFO] [stdout] 93 | | receiver, [INFO] [stdout] 94 | | batch_size, [INFO] [stdout] 95 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/tracker_api.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 71 | let tracks = self.get_main_store_mut().find_usable(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | self.get_main_store_mut().fetch_tracks(&wasted) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/tracker_api.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 92 | let tracks = self.get_wasted_store_mut().find_usable(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | self.get_wasted_store_mut().fetch_tracks(&wasted) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/trackers/tracker_api.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | let mut obj = self.get_auto_waste_obj_mut(); [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 30 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `similari` (lib) due to 31 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> src/track/store.rs:66:17 [INFO] [stdout] | [INFO] [stdout] 66 | MergeResult(Result<()>), [INFO] [stdout] | ----------- ^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `Results` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 66 | MergeResult(()), [INFO] [stdout] | ~~ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `0` and `1` are never read [INFO] [stdout] --> src/utils/point.rs:1:20 [INFO] [stdout] | [INFO] [stdout] 1 | pub struct Point2D(f32, f32); [INFO] [stdout] | ------- ^^^ ^^^ [INFO] [stdout] | | [INFO] [stdout] | fields in this struct [INFO] [stdout] | [INFO] [stdout] = help: consider removing these fields [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track.rs:629:30 [INFO] [stdout] | [INFO] [stdout] 622 | let (attribute_metric, feature_distance) = self.metric.metric( [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 629 | Some(ObservationMetricOk { [INFO] [stdout] | ______________________________^ [INFO] [stdout] 630 | | from: self.track_id, [INFO] [stdout] 631 | | to: other.track_id, [INFO] [stdout] 632 | | attribute_metric, [INFO] [stdout] 633 | | feature_distance, [INFO] [stdout] 634 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:295:51 [INFO] [stdout] | [INFO] [stdout] 295 | ... .map(|x| (x.track_id, x.get_attributes().baked(&x.observations))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:333:24 [INFO] [stdout] | [INFO] [stdout] 318 | pub fn new(metric: M, default_attributes: TA, notifier: N, shards: usize) -> Self { [INFO] [stdout] | --------- ---------------------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 319 | let stores = Arc::new( [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | let my_stores = stores.clone(); [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | executors: { [INFO] [stdout] | ________________________^ [INFO] [stdout] 334 | | (0..shards) [INFO] [stdout] 335 | | .map(|s| { [INFO] [stdout] 336 | | let (commands_sender, commands_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] ... | [INFO] [stdout] 343 | | .collect() [INFO] [stdout] 344 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:321:37 [INFO] [stdout] | [INFO] [stdout] 321 | .map(|_| Mutex::new(HashMap::default())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:457:13 [INFO] [stdout] | [INFO] [stdout] 431 | tracks: Vec>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | let (results_ok_sender, results_ok_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | let (results_err_sender, results_err_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | TrackDistanceOk::new(count, results_ok_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:458:13 [INFO] [stdout] | [INFO] [stdout] 431 | tracks: Vec>, [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 437 | let (results_ok_sender, results_ok_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ----------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 438 | let (results_err_sender, results_err_receiver) = crossbeam::channel::unbounded(); [INFO] [stdout] | ------------------ -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 458 | TrackDistanceErr::new(count, results_err_receiver), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:597:15 [INFO] [stdout] | [INFO] [stdout] 592 | let mut src = self.fetch_tracks(&[src_id]); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 596 | let src = src.pop().unwrap(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 597 | match self.merge_external(dest_id, &src, classes, merge_history) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store.rs:659:12 [INFO] [stdout] | [INFO] [stdout] 628 | src: Track, [INFO] [stdout] | ------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 632 | let (results_sender, results_receiver) = crossbeam::channel::bounded(1); [INFO] [stdout] | -------------- ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 636 | let command = Commands::Merge( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 648 | let res = cmd.send(command); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | Ok(FutureMergeResponse { [INFO] [stdout] | ____________^ [INFO] [stdout] 660 | | _sender: results_sender, [INFO] [stdout] 661 | | receiver: results_receiver, [INFO] [stdout] 662 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/builder.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn build(self) -> TrackStore { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 95 | TrackStore::new( [INFO] [stdout] 96 | self.metric.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/builder.rs:97:13 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn build(self) -> TrackStore { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 97 | self.default_attributes.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/builder.rs:98:13 [INFO] [stdout] | [INFO] [stdout] 94 | pub fn build(self) -> TrackStore { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 98 | self.notifier.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/track_distance.rs:154:28 [INFO] [stdout] | [INFO] [stdout] 150 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 154 | current_chunk: Vec::default().into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/track/store/track_distance.rs:170:28 [INFO] [stdout] | [INFO] [stdout] 166 | fn into_iter(self) -> Self::IntoIter { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | current_chunk: Vec::default().into_iter(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort.rs:128:15 [INFO] [stdout] | [INFO] [stdout] 125 | pub fn new(opts: Arc) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 128 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/simple_api.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 203 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | [INFO] [stdout] 205 | / store [INFO] [stdout] 206 | | .lookup(SortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/sort_py.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | let (batch, result) = PredictionBatchRequest::new(); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | result: Some(result), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:208:22 [INFO] [stdout] | [INFO] [stdout] 170 | let opts = Arc::new(SortAttributesOptions::new( [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let store = Arc::new(RwLock::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let wasted_store = RwLock::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | let track_id = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 194 | [INFO] [stdout] 195 | let voting_threads = (0..voting_shards) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 208 | monitor: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:202:21 [INFO] [stdout] | [INFO] [stdout] 197 | let (tx, rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | let thread_store = store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 199 | let thread_track_id = track_id.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | spawn(move || voting_thread(thread_store, rx, method, thread_track_id)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:297:9 [INFO] [stdout] | [INFO] [stdout] 295 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 296 | [INFO] [stdout] 297 | / store [INFO] [stdout] 298 | | .lookup(SortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/sort/batch_api.rs:468:9 [INFO] [stdout] | [INFO] [stdout] 466 | fn predict_py(&mut self, mut batch: PySortPredictionBatchRequest) -> PredictionBatchResult { [INFO] [stdout] | --------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 467 | self.predict(batch.batch); [INFO] [stdout] 468 | batch.result.take().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/metric.rs:644:9 [INFO] [stdout] | [INFO] [stdout] 642 | metric: VisualMetric, [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 643 | ) -> TrackStore { [INFO] [stdout] 644 | / TrackStoreBuilder::default() [INFO] [stdout] 645 | | .metric(metric) [INFO] [stdout] 646 | | .notifier(NoopNotifier) [INFO] [stdout] 647 | | .default_attributes(default_attrs()) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/track_attributes.rs:69:15 [INFO] [stdout] | [INFO] [stdout] 66 | pub fn new(opts: Arc) -> Self { [INFO] [stdout] | -------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/simple_api.rs:242:9 [INFO] [stdout] | [INFO] [stdout] 240 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 241 | [INFO] [stdout] 242 | / store [INFO] [stdout] 243 | | .lookup(VisualSortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/visual_sort_py.rs:20:21 [INFO] [stdout] | [INFO] [stdout] 17 | let (batch, result) = PredictionBatchRequest::new(); [INFO] [stdout] | ----- ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | result: Some(result), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/batch_api.rs:204:22 [INFO] [stdout] | [INFO] [stdout] 166 | let (track_opts, metric) = opts.clone().build(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 167 | let track_opts = Arc::new(track_opts); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 168 | let metric_opts = metric.opts.clone(); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 169 | let store = Arc::new(RwLock::new( [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let wasted_store = RwLock::new( [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 185 | let track_id = Arc::new(RwLock::new(0)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 186 | [INFO] [stdout] 187 | let voting_threads = (0..voting_shards) [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | monitor: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/batch_api.rs:196:21 [INFO] [stdout] | [INFO] [stdout] 189 | let (tx, rx) = crossbeam::channel::unbounded(); [INFO] [stdout] | -- -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 190 | let thread_store = store.clone(); [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 191 | let thread_track_id = track_id.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 192 | let thread_metric_opts = metric_opts.clone(); [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | / spawn(move || { [INFO] [stdout] 197 | | voting_thread(thread_store, rx, thread_metric_opts, thread_track_id) [INFO] [stdout] 198 | | }), [INFO] [stdout] | |______________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/visual_sort/batch_api.rs:330:9 [INFO] [stdout] | [INFO] [stdout] 328 | let store = self.store.read().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 329 | [INFO] [stdout] 330 | / store [INFO] [stdout] 331 | | .lookup(VisualSortLookup::IdleLookup(scene_id)) [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/batch.rs:87:13 [INFO] [stdout] | [INFO] [stdout] 84 | let (sender, receiver) = crossbeam::channel::bounded(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let batch_size = Arc::new(Mutex::new(0)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | ( [INFO] [stdout] 87 | / Self { [INFO] [stdout] 88 | | batch: BatchRecords::default(), [INFO] [stdout] 89 | | sender, [INFO] [stdout] 90 | | batch_size: batch_size.clone(), [INFO] [stdout] 91 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/batch.rs:92:13 [INFO] [stdout] | [INFO] [stdout] 84 | let (sender, receiver) = crossbeam::channel::bounded(1); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | let batch_size = Arc::new(Mutex::new(0)); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | / PredictionBatchResult { [INFO] [stdout] 93 | | receiver, [INFO] [stdout] 94 | | batch_size, [INFO] [stdout] 95 | | }, [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `std::mem::drop` with a reference instead of an owned value does nothing [INFO] [stdout] --> src/trackers/batch.rs:116:9 [INFO] [stdout] | [INFO] [stdout] 116 | drop(batch); [INFO] [stdout] | ^^^^^-----^ [INFO] [stdout] | | [INFO] [stdout] | argument has type `&HashMap>` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dropping_references)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the expression or result [INFO] [stdout] | [INFO] [stdout] 116 - drop(batch); [INFO] [stdout] 116 + let _ = batch; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/tracker_api.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 71 | let tracks = self.get_main_store_mut().find_usable(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 78 | self.get_main_store_mut().fetch_tracks(&wasted) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/trackers/tracker_api.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 92 | let tracks = self.get_wasted_store_mut().find_usable(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 99 | self.get_wasted_store_mut().fetch_tracks(&wasted) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 31 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `similari` (lib test) due to 32 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "201bde8f37bc1d28e7480af740a4affa4d4237ff821d0182ec97e1dbe6710fa7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "201bde8f37bc1d28e7480af740a4affa4d4237ff821d0182ec97e1dbe6710fa7", kill_on_drop: false }` [INFO] [stdout] 201bde8f37bc1d28e7480af740a4affa4d4237ff821d0182ec97e1dbe6710fa7