[INFO] fetching crate sigio 0.1.0... [INFO] checking sigio-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sigio 0.1.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate sigio 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sigio 0.1.0 [INFO] finished tweaking crates.io crate sigio 0.1.0 [INFO] tweaked toml for crates.io crate sigio 0.1.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 69 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding matchers v0.1.0 (latest: v0.2.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding nu-ansi-term v0.46.0 (latest: v0.50.1) [INFO] [stderr] Adding regex-automata v0.1.10 (latest: v0.4.7) [INFO] [stderr] Adding regex-syntax v0.6.29 (latest: v0.8.4) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b40820fd5f26e6e848c1c97a055abfbd3b9e58d05f1630bbd314053588ceefd7 [INFO] running `Command { std: "docker" "start" "-a" "b40820fd5f26e6e848c1c97a055abfbd3b9e58d05f1630bbd314053588ceefd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b40820fd5f26e6e848c1c97a055abfbd3b9e58d05f1630bbd314053588ceefd7", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b40820fd5f26e6e848c1c97a055abfbd3b9e58d05f1630bbd314053588ceefd7", kill_on_drop: false }` [INFO] [stdout] b40820fd5f26e6e848c1c97a055abfbd3b9e58d05f1630bbd314053588ceefd7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bcb6a057642fdc876a96de3d3a4c9223010c6751db8df5c101d7c8cc49cdde68 [INFO] running `Command { std: "docker" "start" "-a" "bcb6a057642fdc876a96de3d3a4c9223010c6751db8df5c101d7c8cc49cdde68", kill_on_drop: false }` [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Checking anstyle v1.0.8 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Compiling cfg_aliases v0.2.1 [INFO] [stderr] Checking anstyle-query v1.1.1 [INFO] [stderr] Checking colorchoice v1.0.2 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking bitflags v2.6.0 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking env_filter v0.1.2 [INFO] [stderr] Compiling nix v0.29.0 [INFO] [stderr] Checking anstyle-parse v0.2.5 [INFO] [stderr] Checking anstream v0.6.15 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling test-log-macros v0.2.16 [INFO] [stderr] Checking test-log v0.2.16 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking sigio v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::pin::Pin` [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | use std::pin::Pin; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `futures-io` [INFO] [stdout] --> src/compat/mod.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(feature = "futures-io")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `tokio` [INFO] [stdout] = help: consider adding `futures-io` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::task::Waker` [INFO] [stdout] --> src/compat/tokio.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::task::Waker; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncRead` [INFO] [stdout] --> src/compat/tokio.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | use tokio::io::{ReadBuf, AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/convert.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `libc::*` [INFO] [stdout] --> src/lib.rs:161:43 [INFO] [stdout] | [INFO] [stdout] 161 | c_err(unsafe { libc::fcntl(fd, { use libc::*; $op }, $($args),*) }) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | fcntl!(F_SETSIG, signo)?; [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `fcntl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::pin::Pin` [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | use std::pin::Pin; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `futures-io` [INFO] [stdout] --> src/compat/mod.rs:3:7 [INFO] [stdout] | [INFO] [stdout] 3 | #[cfg(feature = "futures-io")] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `default` and `tokio` [INFO] [stdout] = help: consider adding `futures-io` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::task::Waker` [INFO] [stdout] --> src/compat/tokio.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use std::task::Waker; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `AsyncRead` [INFO] [stdout] --> src/compat/tokio.rs:6:26 [INFO] [stdout] | [INFO] [stdout] 6 | use tokio::io::{ReadBuf, AsyncRead, AsyncWrite}; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/convert.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `libc::*` [INFO] [stdout] --> src/lib.rs:161:43 [INFO] [stdout] | [INFO] [stdout] 161 | c_err(unsafe { libc::fcntl(fd, { use libc::*; $op }, $($args),*) }) [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 172 | fcntl!(F_SETSIG, signo)?; [INFO] [stdout] | ----------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `fcntl` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/compat/tokio.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | ctx: &mut Context<'_> [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/compat/tokio.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | ctx: &mut Context<'_> [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `from_fd` is never used [INFO] [stdout] --> src/lib.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 150 | impl File { [INFO] [stdout] | --------- associated function in this implementation [INFO] [stdout] 151 | /// may cause unexpected results if fd has unusual flags set [INFO] [stdout] 152 | fn from_fd(fd: FD) -> io::Result { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | .for_each(|(_, v)| v.drain(..).for_each(Waker::wake)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:6 [INFO] [stdout] | [INFO] [stdout] 175 | Ok(File{ fd, _unsync_marker: UnsafeCell::new(()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn open(filepath: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Self::from_std(StdFile::open(filepath)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sigio` (lib) due to 4 previous errors; 9 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/compat/tokio.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | ctx: &mut Context<'_> [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `ctx` [INFO] [stdout] --> src/compat/tokio.rs:43:9 [INFO] [stdout] | [INFO] [stdout] 43 | ctx: &mut Context<'_> [INFO] [stdout] | ^^^ help: if this is intentional, prefix it with an underscore: `_ctx` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `read_start` [INFO] [stdout] --> src/lib.rs:275:8 [INFO] [stdout] | [INFO] [stdout] 275 | let read_start = Instant::now(); [INFO] [stdout] | ^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_read_start` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `read_end` [INFO] [stdout] --> src/lib.rs:277:8 [INFO] [stdout] | [INFO] [stdout] 277 | let read_end = Instant::now(); [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_read_end` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `nw` [INFO] [stdout] --> src/lib.rs:307:8 [INFO] [stdout] | [INFO] [stdout] 307 | let (nw, nr) = tokio::try_join!( [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_nw` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:85:25 [INFO] [stdout] | [INFO] [stdout] 85 | .for_each(|(_, v)| v.drain(..).for_each(Waker::wake)), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:175:6 [INFO] [stdout] | [INFO] [stdout] 175 | Ok(File{ fd, _unsync_marker: UnsafeCell::new(()) }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 182 | pub fn open(filepath: impl AsRef) -> io::Result { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 183 | Self::from_std(StdFile::open(filepath)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sigio` (lib test) due to 4 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bcb6a057642fdc876a96de3d3a4c9223010c6751db8df5c101d7c8cc49cdde68", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bcb6a057642fdc876a96de3d3a4c9223010c6751db8df5c101d7c8cc49cdde68", kill_on_drop: false }` [INFO] [stdout] bcb6a057642fdc876a96de3d3a4c9223010c6751db8df5c101d7c8cc49cdde68