[INFO] fetching crate shunting 0.1.2... [INFO] checking shunting-0.1.2 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shunting 0.1.2 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate shunting 0.1.2 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shunting 0.1.2 [INFO] finished tweaking crates.io crate shunting 0.1.2 [INFO] tweaked toml for crates.io crate shunting 0.1.2 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate shunting 0.1.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e9d1d8d5e7ddbad988b172770c9a4f01a956fc23d94b947b8bed9692248f18bf [INFO] running `Command { std: "docker" "start" "-a" "e9d1d8d5e7ddbad988b172770c9a4f01a956fc23d94b947b8bed9692248f18bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e9d1d8d5e7ddbad988b172770c9a4f01a956fc23d94b947b8bed9692248f18bf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9d1d8d5e7ddbad988b172770c9a4f01a956fc23d94b947b8bed9692248f18bf", kill_on_drop: false }` [INFO] [stdout] e9d1d8d5e7ddbad988b172770c9a4f01a956fc23d94b947b8bed9692248f18bf [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9533920feb38cd18cabba708652ed75d440802ee7d3b4277dd8feeadccb6c247 [INFO] running `Command { std: "docker" "start" "-a" "9533920feb38cd18cabba708652ed75d440802ee7d3b4277dd8feeadccb6c247", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.121 [INFO] [stderr] Compiling libm v0.2.2 [INFO] [stderr] Compiling io-lifetimes v0.6.1 [INFO] [stderr] Compiling rustix v0.34.0 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling memoffset v0.6.5 [INFO] [stderr] Checking smallvec v1.8.0 [INFO] [stderr] Checking linux-raw-sys v0.0.42 [INFO] [stderr] Compiling log v0.4.16 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking unicode-segmentation v1.9.0 [INFO] [stderr] Checking lexers v0.1.4 [INFO] [stderr] Checking home v0.5.3 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Checking getrandom v0.2.5 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.23.1 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking fd-lock v3.0.5 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking shunting v0.1.2 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpneval.rs:68:21 [INFO] [stdout] | [INFO] [stdout] 65 | let mut cx = HashMap::new(); [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | MathContext(Rc::new(RefCell::new(cx))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpneval.rs:115:36 [INFO] [stdout] | [INFO] [stdout] 115 | ... |_| Ok(build_rv(fname, &args)?.eval()))?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpneval.rs:195:12 [INFO] [stdout] | [INFO] [stdout] 124 | let mut stack = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 195 | Ok(stack.pop().ok_or("Failed to compile RPNExpr")?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpneval.rs:179:28 [INFO] [stdout] | [INFO] [stdout] 174 | let args: Vec<_> = stack.split_off(stack.len() - arity); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 179 | Ok(if let Ok(rv) = build_rv(&fname, &args) { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 180 | | MathOp::RandVar(rv) [INFO] [stdout] 181 | | } else { [INFO] [stdout] 182 | | MathOp::Number(eval_fn(&fname, &args)?) [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/rpneval.rs:186:57 [INFO] [stdout] | [INFO] [stdout] 177 | let eval = move || -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 186 | MathOp::Dynamic(Rc::new(move || eval().map(|v| v.eval()))) [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shunting` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "9533920feb38cd18cabba708652ed75d440802ee7d3b4277dd8feeadccb6c247", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9533920feb38cd18cabba708652ed75d440802ee7d3b4277dd8feeadccb6c247", kill_on_drop: false }` [INFO] [stdout] 9533920feb38cd18cabba708652ed75d440802ee7d3b4277dd8feeadccb6c247