[INFO] fetching crate shrs_job 0.0.6... [INFO] checking shrs_job-0.0.6 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shrs_job 0.0.6 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate shrs_job 0.0.6 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shrs_job 0.0.6 [INFO] finished tweaking crates.io crate shrs_job 0.0.6 [INFO] tweaked toml for crates.io crate shrs_job 0.0.6 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 14 packages to latest compatible versions [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding nix v0.26.4 (latest: v0.29.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 49e0e1c6a030731d7338a158830687963f5312f48c8c757d32ef250b57563734 [INFO] running `Command { std: "docker" "start" "-a" "49e0e1c6a030731d7338a158830687963f5312f48c8c757d32ef250b57563734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "49e0e1c6a030731d7338a158830687963f5312f48c8c757d32ef250b57563734", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "49e0e1c6a030731d7338a158830687963f5312f48c8c757d32ef250b57563734", kill_on_drop: false }` [INFO] [stdout] 49e0e1c6a030731d7338a158830687963f5312f48c8c757d32ef250b57563734 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fd2e6c51ef8ae4f9543abba9696c80a452ba2ce0f8a5b36464eb0a9d3c9e43a [INFO] running `Command { std: "docker" "start" "-a" "3fd2e6c51ef8ae4f9543abba9696c80a452ba2ce0f8a5b36464eb0a9d3c9e43a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking shrs_job v0.0.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: struct `BuiltinProcess` is never constructed [INFO] [stdout] --> src/process.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | struct BuiltinProcess { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:333:8 [INFO] [stdout] | [INFO] [stdout] 192 | program: S1, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | args: &[S2], [INFO] [stdout] 194 | stdin: Stdin, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | stdout: Output, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | stderr: Output, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut command = Command::new(OsStr::new(program.as_ref())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let child = match command.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 334 | | Box::new(ExternalProcess::new(program, args, child)), [INFO] [stdout] 335 | | Some(pgid), [INFO] [stdout] 336 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BuiltinProcess` is never constructed [INFO] [stdout] --> src/process.rs:60:8 [INFO] [stdout] | [INFO] [stdout] 60 | struct BuiltinProcess { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shrs_job` (lib test) due to 2 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/process.rs:333:8 [INFO] [stdout] | [INFO] [stdout] 192 | program: S1, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | args: &[S2], [INFO] [stdout] 194 | stdin: Stdin, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 195 | stdout: Output, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 196 | stderr: Output, [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 210 | let mut command = Command::new(OsStr::new(program.as_ref())); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 305 | let child = match command.spawn() { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(child) => child, [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 307 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 333 | Ok(( [INFO] [stdout] | ________^ [INFO] [stdout] 334 | | Box::new(ExternalProcess::new(program, args, child)), [INFO] [stdout] 335 | | Some(pgid), [INFO] [stdout] 336 | | )) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shrs_job` (lib) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "3fd2e6c51ef8ae4f9543abba9696c80a452ba2ce0f8a5b36464eb0a9d3c9e43a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fd2e6c51ef8ae4f9543abba9696c80a452ba2ce0f8a5b36464eb0a9d3c9e43a", kill_on_drop: false }` [INFO] [stdout] 3fd2e6c51ef8ae4f9543abba9696c80a452ba2ce0f8a5b36464eb0a9d3c9e43a