[INFO] fetching crate shotwellvfs 0.1.0... [INFO] checking shotwellvfs-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shotwellvfs 0.1.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate shotwellvfs 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shotwellvfs 0.1.0 [INFO] finished tweaking crates.io crate shotwellvfs 0.1.0 [INFO] tweaked toml for crates.io crate shotwellvfs 0.1.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 35 packages to latest compatible versions [INFO] [stderr] Adding aho-corasick v0.6.10 (latest: v1.1.3) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding clap v2.34.0 (latest: v4.5.16) [INFO] [stderr] Adding env_logger v0.4.3 (latest: v0.11.5) [INFO] [stderr] Adding hermit-abi v0.1.19 (latest: v0.4.0) [INFO] [stderr] Adding log v0.3.9 (latest: v0.4.22) [INFO] [stderr] Adding regex v0.2.11 (latest: v1.10.6) [INFO] [stderr] Adding regex-syntax v0.5.6 (latest: v0.8.4) [INFO] [stderr] Adding sqlite v0.23.9 (latest: v0.36.1) [INFO] [stderr] Adding sqlite3-src v0.2.12 (latest: v0.6.1) [INFO] [stderr] Adding sqlite3-sys v0.12.0 (latest: v0.17.0) [INFO] [stderr] Adding strsim v0.8.0 (latest: v0.11.1) [INFO] [stderr] Adding textwrap v0.11.0 (latest: v0.16.1) [INFO] [stderr] Adding thread_local v0.3.6 (latest: v1.1.8) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding ucd-util v0.1.10 (latest: v0.2.1) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e680a89e5d581fd84d6aad8acf48111043a1a24f87a068d29a3cf2a100030593 [INFO] running `Command { std: "docker" "start" "-a" "e680a89e5d581fd84d6aad8acf48111043a1a24f87a068d29a3cf2a100030593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e680a89e5d581fd84d6aad8acf48111043a1a24f87a068d29a3cf2a100030593", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e680a89e5d581fd84d6aad8acf48111043a1a24f87a068d29a3cf2a100030593", kill_on_drop: false }` [INFO] [stdout] e680a89e5d581fd84d6aad8acf48111043a1a24f87a068d29a3cf2a100030593 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b9f16b5fd583ab3ea3c3759656e71cf645b9fa1cf6dd30f45d1a1dce3e9bbad9 [INFO] running `Command { std: "docker" "start" "-a" "b9f16b5fd583ab3ea3c3759656e71cf645b9fa1cf6dd30f45d1a1dce3e9bbad9", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking thread-scoped v1.0.2 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Compiling fuse v0.3.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling sqlite3-src v0.2.12 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking sqlite3-sys v0.12.0 [INFO] [stderr] Checking sqlite v0.23.9 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking shotwellvfs v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/main.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | let mut path = std::env::home_dir().unwrap_or_else(|| panic!("Cannot find user home dir and no --db argument specified")); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::env::home_dir`: This function's behavior may be unexpected on Windows. Consider using a crate from crates.io instead. [INFO] [stdout] --> src/main.rs:33:38 [INFO] [stdout] | [INFO] [stdout] 33 | let mut path = std::env::home_dir().unwrap_or_else(|| panic!("Cannot find user home dir and no --db argument specified")); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fuse_interface.rs:120:43 [INFO] [stdout] | [INFO] [stdout] 120 | fn getattr_tag(&mut self, inode: u64, mut reply: ReplyAttr) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fuse_interface.rs:131:45 [INFO] [stdout] | [INFO] [stdout] 131 | fn getattr_photo(&mut self, inode: u64, mut reply: ReplyAttr) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `VideoKind` is never constructed [INFO] [stdout] --> src/fuse_interface.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 25 | enum FileId { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 28 | VideoKind(u64), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuse_interface.rs:104:19 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new>(path: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | ShotwellVFS { [INFO] [stdout] 104 | conn: sqlite::open(path).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fuse_interface.rs:120:43 [INFO] [stdout] | [INFO] [stdout] 120 | fn getattr_tag(&mut self, inode: u64, mut reply: ReplyAttr) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/fuse_interface.rs:131:45 [INFO] [stdout] | [INFO] [stdout] 131 | fn getattr_photo(&mut self, inode: u64, mut reply: ReplyAttr) { [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shotwellvfs` (bin "shotwellvfs" test) due to 2 previous errors; 4 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `VideoKind` is never constructed [INFO] [stdout] --> src/fuse_interface.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 25 | enum FileId { [INFO] [stdout] | ------ variant in this enum [INFO] [stdout] ... [INFO] [stdout] 28 | VideoKind(u64), [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/fuse_interface.rs:104:19 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn new>(path: T) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | ShotwellVFS { [INFO] [stdout] 104 | conn: sqlite::open(path).unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shotwellvfs` (bin "shotwellvfs") due to 2 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "b9f16b5fd583ab3ea3c3759656e71cf645b9fa1cf6dd30f45d1a1dce3e9bbad9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b9f16b5fd583ab3ea3c3759656e71cf645b9fa1cf6dd30f45d1a1dce3e9bbad9", kill_on_drop: false }` [INFO] [stdout] b9f16b5fd583ab3ea3c3759656e71cf645b9fa1cf6dd30f45d1a1dce3e9bbad9