[INFO] fetching crate shi 0.1.5... [INFO] checking shi-0.1.5 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shi 0.1.5 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate shi 0.1.5 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shi 0.1.5 [INFO] finished tweaking crates.io crate shi 0.1.5 [INFO] tweaked toml for crates.io crate shi 0.1.5 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate shi 0.1.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcde1945022434632719cd6dfc7c90260dca043c6959da82affcf9b6ff696f64 [INFO] running `Command { std: "docker" "start" "-a" "fcde1945022434632719cd6dfc7c90260dca043c6959da82affcf9b6ff696f64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcde1945022434632719cd6dfc7c90260dca043c6959da82affcf9b6ff696f64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcde1945022434632719cd6dfc7c90260dca043c6959da82affcf9b6ff696f64", kill_on_drop: false }` [INFO] [stdout] fcde1945022434632719cd6dfc7c90260dca043c6959da82affcf9b6ff696f64 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c51781237061c5fd27617e99857d208087937c881c89d54796cd71aa6e2d7b2e [INFO] running `Command { std: "docker" "start" "-a" "c51781237061c5fd27617e99857d208087937c881c89d54796cd71aa6e2d7b2e", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling unicode-xid v0.2.1 [INFO] [stderr] Compiling syn v1.0.55 [INFO] [stderr] Compiling bitflags v1.2.1 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Compiling anyhow v1.0.40 [INFO] [stderr] Checking difference v2.0.0 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking pretty_assertions v0.6.1 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking dirs-sys-next v0.1.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking nix v0.19.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking colored v2.0.0 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking rustyline v7.1.0 [INFO] [stderr] Compiling thiserror-impl v1.0.24 [INFO] [stderr] Compiling rustyline-derive v0.4.0 [INFO] [stderr] Checking thiserror v1.0.24 [INFO] [stderr] Checking shi v0.1.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: multiple lines skipped by escaped newline [INFO] [stdout] --> src/command/help.rs:339:85 [INFO] [stdout] | [INFO] [stdout] 339 | command failed to parse: \'DNE\' is not a recognized command.\n\n\t \ [INFO] [stdout] | _____________________________________________________________________________________^ [INFO] [stdout] ... | [INFO] [stdout] 342 | | => expected one of \'leaf\' or \'foo\'.\n\n\ [INFO] [stdout] | |____________________^ skipping everything up to and including this point [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple lines skipped by escaped newline [INFO] [stdout] --> src/command/help.rs:342:64 [INFO] [stdout] | [INFO] [stdout] 342 | => expected one of \'leaf\' or \'foo\'.\n\n\ [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] ... | [INFO] [stdout] 345 | | Run \'helptree\' for more info on the entire command tree.\n\ [INFO] [stdout] | |________________^ skipping everything up to and including this point [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple lines skipped by escaped newline [INFO] [stdout] --> src/command/help.rs:339:85 [INFO] [stdout] | [INFO] [stdout] 339 | command failed to parse: \'DNE\' is not a recognized command.\n\n\t \ [INFO] [stdout] | _____________________________________________________________________________________^ [INFO] [stdout] ... | [INFO] [stdout] 342 | | => expected one of \'leaf\' or \'foo\'.\n\n\ [INFO] [stdout] | |____________________^ skipping everything up to and including this point [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple lines skipped by escaped newline [INFO] [stdout] --> src/command/help.rs:342:64 [INFO] [stdout] | [INFO] [stdout] 342 | => expected one of \'leaf\' or \'foo\'.\n\n\ [INFO] [stdout] | ________________________________________________________________^ [INFO] [stdout] ... | [INFO] [stdout] 345 | | Run \'helptree\' for more info on the entire command tree.\n\ [INFO] [stdout] | |________________^ skipping everything up to and including this point [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/command/help.rs:179:19 [INFO] [stdout] | [INFO] [stdout] 179 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/command/help.rs:184:19 [INFO] [stdout] | [INFO] [stdout] 184 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/command_set.rs:158:19 [INFO] [stdout] | [INFO] [stdout] 158 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/command_set.rs:163:19 [INFO] [stdout] | [INFO] [stdout] 163 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/parser.rs:328:19 [INFO] [stdout] | [INFO] [stdout] 328 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `tarpaulin_include` [INFO] [stdout] --> src/parser.rs:368:19 [INFO] [stdout] | [INFO] [stdout] 368 | #[cfg(not(tarpaulin_include))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(tarpaulin_include)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(tarpaulin_include)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/exit.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct ExitCommand<'a, S> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 12 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ExitCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/help.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct HelpCommand<'a, S> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 17 | // TODO: Not sure if we need this crap. [INFO] [stdout] 18 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HelpCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/helptree.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct HelpTreeCommand<'a, S> { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 35 | // TODO: Not sure if we need this crap. [INFO] [stdout] 36 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HelpTreeCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/history.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HistoryCommand<'a, S> { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 16 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HistoryCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `quotation` is never read [INFO] [stdout] --> src/tokenizer.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct QuotePair { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | quotation: char, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QuotePair` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/mod.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new_leaf(child_cmd: C) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Self::Leaf(Box::new(child_cmd)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/mod.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new_parent(name: &'a str, sub_cmds: Vec>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Self::Parent(ParentCommand::new(name, sub_cmds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/basic.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(name: &'a str, exec: F) -> BasicCommand<'a, S> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | exec: Rc::new(exec), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/basic.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new_with_help(name: &'a str, help: &'a str, exec: F) -> BasicCommand<'a, S> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | exec: Rc::new(exec), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readline.rs:118:24 [INFO] [stdout] | [INFO] [stdout] 114 | cmds: Rc>>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | builtins: Rc>>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | completer: ExecCompleter::new(parser, cmds, builtins), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 51 | let cmds = Rc::new(RefCell::new(CommandSet::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let builtins = Rc::new(Shell::build_builtins()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | rl: Readline::new(Parser::new(), cmds.clone(), builtins.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new_with_state(prompt: &'a str, state: S) -> Shell [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let cmds = Rc::new(RefCell::new(CommandSet::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let builtins = Rc::new(Shell::build_builtins()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | rl: Readline::new(Parser::new(), cmds.clone(), builtins.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 7 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shi` (lib) due to 8 previous errors; 7 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/exit.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct ExitCommand<'a, S> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 12 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ExitCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/help.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 16 | pub struct HelpCommand<'a, S> { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] 17 | // TODO: Not sure if we need this crap. [INFO] [stdout] 18 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HelpCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/helptree.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 34 | pub struct HelpTreeCommand<'a, S> { [INFO] [stdout] | --------------- field in this struct [INFO] [stdout] 35 | // TODO: Not sure if we need this crap. [INFO] [stdout] 36 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HelpTreeCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `phantom` is never read [INFO] [stdout] --> src/command/history.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 15 | pub struct HistoryCommand<'a, S> { [INFO] [stdout] | -------------- field in this struct [INFO] [stdout] 16 | phantom: &'a PhantomData, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HistoryCommand` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `quotation` is never read [INFO] [stdout] --> src/tokenizer.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 36 | struct QuotePair { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 39 | quotation: char, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `QuotePair` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/mod.rs:59:20 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new_leaf(child_cmd: C) -> Self [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 59 | Self::Leaf(Box::new(child_cmd)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/mod.rs:64:22 [INFO] [stdout] | [INFO] [stdout] 63 | pub fn new_parent(name: &'a str, sub_cmds: Vec>) -> Self { [INFO] [stdout] | ----------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Self::Parent(ParentCommand::new(name, sub_cmds)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/basic.rs:28:19 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(name: &'a str, exec: F) -> BasicCommand<'a, S> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | exec: Rc::new(exec), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/command/basic.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 38 | pub fn new_with_help(name: &'a str, help: &'a str, exec: F) -> BasicCommand<'a, S> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | exec: Rc::new(exec), [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/readline.rs:118:24 [INFO] [stdout] | [INFO] [stdout] 114 | cmds: Rc>>, [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 115 | builtins: Rc>>, [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 118 | completer: ExecCompleter::new(parser, cmds, builtins), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:55:17 [INFO] [stdout] | [INFO] [stdout] 51 | let cmds = Rc::new(RefCell::new(CommandSet::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 52 | let builtins = Rc::new(Shell::build_builtins()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | rl: Readline::new(Parser::new(), cmds.clone(), builtins.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/shell.rs:94:17 [INFO] [stdout] | [INFO] [stdout] 86 | pub fn new_with_state(prompt: &'a str, state: S) -> Shell [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 90 | let cmds = Rc::new(RefCell::new(CommandSet::new())); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | let builtins = Rc::new(Shell::build_builtins()); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | rl: Readline::new(Parser::new(), cmds.clone(), builtins.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 13 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shi` (lib test) due to 8 previous errors; 13 warnings emitted [INFO] running `Command { std: "docker" "inspect" "c51781237061c5fd27617e99857d208087937c881c89d54796cd71aa6e2d7b2e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c51781237061c5fd27617e99857d208087937c881c89d54796cd71aa6e2d7b2e", kill_on_drop: false }` [INFO] [stdout] c51781237061c5fd27617e99857d208087937c881c89d54796cd71aa6e2d7b2e