[INFO] fetching crate shellac-server 0.3.1... [INFO] checking shellac-server-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shellac-server 0.3.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate shellac-server 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shellac-server 0.3.1 [INFO] finished tweaking crates.io crate shellac-server 0.3.1 [INFO] tweaked toml for crates.io crate shellac-server 0.3.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate shellac-server 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a231397595351a87f439fa32f3fda5b0c97d8e87f20e43d3b7fa761c2ca727c5 [INFO] running `Command { std: "docker" "start" "-a" "a231397595351a87f439fa32f3fda5b0c97d8e87f20e43d3b7fa761c2ca727c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a231397595351a87f439fa32f3fda5b0c97d8e87f20e43d3b7fa761c2ca727c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a231397595351a87f439fa32f3fda5b0c97d8e87f20e43d3b7fa761c2ca727c5", kill_on_drop: false }` [INFO] [stdout] a231397595351a87f439fa32f3fda5b0c97d8e87f20e43d3b7fa761c2ca727c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 74078d1936590fdd87c0ef8aa9682fcffbea922f6ae57b3dcb5fb8ce8e2d1e04 [INFO] running `Command { std: "docker" "start" "-a" "74078d1936590fdd87c0ef8aa9682fcffbea922f6ae57b3dcb5fb8ce8e2d1e04", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.1 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Compiling syn v1.0.5 [INFO] [stderr] Compiling unicode-xid v0.1.0 [INFO] [stderr] Compiling libc v0.2.62 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling serde v1.0.99 [INFO] [stderr] Compiling bitflags v1.1.0 [INFO] [stderr] Compiling capnp v0.10.3 [INFO] [stderr] Checking unicode-width v0.1.6 [INFO] [stderr] Compiling unicode-segmentation v1.3.0 [INFO] [stderr] Compiling byteorder v1.3.2 [INFO] [stderr] Checking ansi_term v0.11.0 [INFO] [stderr] Checking vec_map v0.8.1 [INFO] [stderr] Checking either v1.5.2 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking linked-hash-map v0.5.2 [INFO] [stderr] Checking unreachable v1.0.0 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking hashbrown v0.5.0 [INFO] [stderr] Checking regex-syntax v0.6.11 [INFO] [stderr] Checking yaml-rust v0.4.3 [INFO] [stderr] Checking dtoa v0.4.4 [INFO] [stderr] Checking ascii v0.9.3 [INFO] [stderr] Checking itertools v0.8.0 [INFO] [stderr] Compiling heck v0.3.1 [INFO] [stderr] Checking lru v0.1.17 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Checking aho-corasick v0.7.6 [INFO] [stderr] Checking combine v3.8.1 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling capnpc v0.10.1 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Checking regex v1.2.1 [INFO] [stderr] Compiling structopt-derive v0.2.18 [INFO] [stderr] Compiling shellac-codec v0.2.0 [INFO] [stderr] Compiling serde_derive v1.0.99 [INFO] [stderr] Checking structopt v0.2.18 [INFO] [stderr] Checking serde_yaml v0.8.9 [INFO] [stderr] Checking shellac-server v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `debug`, `verbose`, `fallback`, and `shellcomp` are never read [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | struct Opts { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | debug: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | verbose: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fallback: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | shellcomp: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | .find_map(|folder| File::open(folder.join(&file_name).with_extension("shellac")).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 63 | fn from(cause: Errors) -> Self { [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Error::Parsing(cause.map_range(ToOwned::to_owned)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 199 | .map(move |(name, _, reference, _, desc, _, sentinel)| { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | completion::Choice::new(desc, reference.map(|(_, _, _, r)| O::from(r)), sentinel), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 270 | let mut steps = resolve(steps, 0, &def.sections, keys.as_slice())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(Self { num_counters: def.counters, descriptions, steps, definitions: def.definitions }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shellac-server` (bin "shellac-server") due to 5 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `debug`, `verbose`, `fallback`, and `shellcomp` are never read [INFO] [stdout] --> src/main.rs:30:5 [INFO] [stdout] | [INFO] [stdout] 27 | struct Opts { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 30 | debug: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 34 | verbose: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 38 | fallback: Vec, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 42 | shellcomp: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opts` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/main.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | .find_map(|folder| File::open(folder.join(&file_name).with_extension("shellac")).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:64:24 [INFO] [stdout] | [INFO] [stdout] 63 | fn from(cause: Errors) -> Self { [INFO] [stdout] | ----------------------------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 64 | Error::Parsing(cause.map_range(ToOwned::to_owned)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:202:17 [INFO] [stdout] | [INFO] [stdout] 199 | .map(move |(name, _, reference, _, desc, _, sentinel)| { [INFO] [stdout] | ------------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 202 | completion::Choice::new(desc, reference.map(|(_, _, _, r)| O::from(r)), sentinel), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser.rs:273:12 [INFO] [stdout] | [INFO] [stdout] 270 | let mut steps = resolve(steps, 0, &def.sections, keys.as_slice())?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 273 | Ok(Self { num_counters: def.counters, descriptions, steps, definitions: def.definitions }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shellac-server` (bin "shellac-server" test) due to 5 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "74078d1936590fdd87c0ef8aa9682fcffbea922f6ae57b3dcb5fb8ce8e2d1e04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74078d1936590fdd87c0ef8aa9682fcffbea922f6ae57b3dcb5fb8ce8e2d1e04", kill_on_drop: false }` [INFO] [stdout] 74078d1936590fdd87c0ef8aa9682fcffbea922f6ae57b3dcb5fb8ce8e2d1e04