[INFO] fetching crate sharedlib 7.0.0... [INFO] checking sharedlib-7.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sharedlib 7.0.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate sharedlib 7.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sharedlib 7.0.0 [INFO] finished tweaking crates.io crate sharedlib 7.0.0 [INFO] tweaked toml for crates.io crate sharedlib 7.0.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding error-chain v0.9.0 (latest: v0.12.4) [INFO] [stderr] Adding lazy_static v0.2.11 (latest: v1.5.0) [INFO] [stderr] Adding winapi v0.2.8 (latest: v0.3.9) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83aef01d64c42ee2509186194e990838eaf8eab4ee7624e8ce54201834bc18f5 [INFO] running `Command { std: "docker" "start" "-a" "83aef01d64c42ee2509186194e990838eaf8eab4ee7624e8ce54201834bc18f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83aef01d64c42ee2509186194e990838eaf8eab4ee7624e8ce54201834bc18f5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83aef01d64c42ee2509186194e990838eaf8eab4ee7624e8ce54201834bc18f5", kill_on_drop: false }` [INFO] [stdout] 83aef01d64c42ee2509186194e990838eaf8eab4ee7624e8ce54201834bc18f5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] da97b32300336c1be4971b12a7bd801e94d024181bbb828d52afcd5be8f3c478 [INFO] running `Command { std: "docker" "start" "-a" "da97b32300336c1be4971b12a7bd801e94d024181bbb828d52afcd5be8f3c478", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling winapi-build v0.1.1 [INFO] [stderr] Compiling sharedlib v7.0.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking winapi v0.2.8 [INFO] [stderr] Checking error-chain v0.9.0 [INFO] [stdout] warning: unexpected `cfg` condition value: `bitrig` [INFO] [stdout] --> build.rs:14:11 [INFO] [stdout] | [INFO] [stdout] 14 | target_os="bitrig", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `target_os` are: `aix`, `android`, `cuda`, `dragonfly`, `emscripten`, `espidf`, `freebsd`, `fuchsia`, `haiku`, `hermit`, `horizon`, `hurd`, `illumos`, `ios`, `l4re`, `linux`, `macos`, `netbsd`, `none`, `nto`, `nuttx`, `openbsd`, `psp`, `redox`, `solaris`, `solid_asp3`, `teeos`, `trusty`, `tvos`, `uefi`, `unknown`, `visionos`, `vita`, `vxworks`, and `wasi` and 4 more [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling kernel32-sys v0.2.2 [INFO] [stdout] warning: 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | let inner = try!(LibUnsafe::new(path_to_lib)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | let symbol_ptr = try!(self.inner.find_data::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | let func = try!(self.inner.find_func::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_tracked.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | let lib_unsafe = try!(LibUnsafe::new(path_to_lib)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_tracked.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 96 | let symbol_ptr = try!(lib.find_data::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_tracked.rs:150:20 [INFO] [stdout] | [INFO] [stdout] 150 | let func = try!(lib.find_func::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_unsafe.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | let inner = try!(InnerLib::new(path_to_lib)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_unsafe.rs:132:33 [INFO] [stdout] | [INFO] [stdout] 132 | Some(symbol) => try!(self.inner.find::(symbol)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_unsafe.rs:133:25 [INFO] [stdout] | [INFO] [stdout] 133 | None => try!(self.inner.find::(symbol)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib.rs:36:21 [INFO] [stdout] | [INFO] [stdout] 36 | let inner = try!(LibUnsafe::new(path_to_lib)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib.rs:83:26 [INFO] [stdout] | [INFO] [stdout] 83 | let symbol_ptr = try!(self.inner.find_data::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib.rs:129:20 [INFO] [stdout] | [INFO] [stdout] 129 | let func = try!(self.inner.find_func::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_tracked.rs:39:26 [INFO] [stdout] | [INFO] [stdout] 39 | let lib_unsafe = try!(LibUnsafe::new(path_to_lib)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_tracked.rs:96:26 [INFO] [stdout] | [INFO] [stdout] 96 | let symbol_ptr = try!(lib.find_data::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_tracked.rs:150:20 [INFO] [stdout] | [INFO] [stdout] 150 | let func = try!(lib.find_func::(symbol)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_unsafe.rs:37:21 [INFO] [stdout] | [INFO] [stdout] 37 | let inner = try!(InnerLib::new(path_to_lib)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_unsafe.rs:132:33 [INFO] [stdout] | [INFO] [stdout] 132 | Some(symbol) => try!(self.inner.find::(symbol)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lib_impl/lib_unsafe.rs:133:25 [INFO] [stdout] | [INFO] [stdout] 133 | None => try!(self.inner.find::(symbol)), [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/util/error_mutex.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref ERROR_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stdout] 5 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/util/error_mutex.rs:3:1 [INFO] [stdout] | [INFO] [stdout] 3 | / lazy_static! { [INFO] [stdout] 4 | | pub static ref ERROR_MUTEX: Mutex<()> = Mutex::new(()); [INFO] [stdout] 5 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/unix/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub unsafe fn new(path_to_lib: TPath) -> Result [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | / util::error_guard( [INFO] [stdout] 26 | | || { [INFO] [stdout] 27 | | let result = external::dlopen(path_to_lib_c_str, RTLD_LAZY); [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | ).ok_or_dlerror("dlopen") [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/unix/lib.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub unsafe fn find(&self, symbol_str: TStr) -> Result<*const T> [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | / util::error_guard( [INFO] [stdout] 52 | | || { [INFO] [stdout] 53 | | let symbol = external::dlsym(self.handle, symbol); [INFO] [stdout] 54 | | if symbol.is_null() { [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | ).ok_or_dlerror("dlsym") [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 10 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/unix/lib.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 17 | pub unsafe fn new(path_to_lib: TPath) -> Result [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 25 | / util::error_guard( [INFO] [stdout] 26 | | || { [INFO] [stdout] 27 | | let result = external::dlopen(path_to_lib_c_str, RTLD_LAZY); [INFO] [stdout] ... | [INFO] [stdout] 38 | | } [INFO] [stdout] 39 | | ).ok_or_dlerror("dlopen") [INFO] [stdout] | |_________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/os/unix/lib.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 45 | pub unsafe fn find(&self, symbol_str: TStr) -> Result<*const T> [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 51 | / util::error_guard( [INFO] [stdout] 52 | | || { [INFO] [stdout] 53 | | let symbol = external::dlsym(self.handle, symbol); [INFO] [stdout] 54 | | if symbol.is_null() { [INFO] [stdout] ... | [INFO] [stdout] 59 | | } [INFO] [stdout] 60 | | ).ok_or_dlerror("dlsym") [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sharedlib` (lib) due to 3 previous errors; 10 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: unused return value of `std::mem::replace` that must be used [INFO] [stdout] --> src/test/shared.rs:51:9 [INFO] [stdout] | [INFO] [stdout] 51 | mem::replace(dll._func.borrow_mut().deref_mut(), Some(add_u32s)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 51 | let _ = mem::replace(dll._func.borrow_mut().deref_mut(), Some(add_u32s)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors; 11 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sharedlib` (lib test) due to 3 previous errors; 11 warnings emitted [INFO] running `Command { std: "docker" "inspect" "da97b32300336c1be4971b12a7bd801e94d024181bbb828d52afcd5be8f3c478", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "da97b32300336c1be4971b12a7bd801e94d024181bbb828d52afcd5be8f3c478", kill_on_drop: false }` [INFO] [stdout] da97b32300336c1be4971b12a7bd801e94d024181bbb828d52afcd5be8f3c478