[INFO] fetching crate shapemaker 1.1.0... [INFO] checking shapemaker-1.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shapemaker 1.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate shapemaker 1.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shapemaker 1.1.0 [INFO] finished tweaking crates.io crate shapemaker 1.1.0 [INFO] tweaked toml for crates.io crate shapemaker 1.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate shapemaker 1.1.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a41527f7d0dcac43c3e37d1e7fde510f925eaabf8d194300840e9e20c56aa0de [INFO] running `Command { std: "docker" "start" "-a" "a41527f7d0dcac43c3e37d1e7fde510f925eaabf8d194300840e9e20c56aa0de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a41527f7d0dcac43c3e37d1e7fde510f925eaabf8d194300840e9e20c56aa0de", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a41527f7d0dcac43c3e37d1e7fde510f925eaabf8d194300840e9e20c56aa0de", kill_on_drop: false }` [INFO] [stdout] a41527f7d0dcac43c3e37d1e7fde510f925eaabf8d194300840e9e20c56aa0de [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 580b0825a5be2a85816b9ea359fe9821e6a92dbf4f7ca8b6b6fed6d49768aa1d [INFO] running `Command { std: "docker" "start" "-a" "580b0825a5be2a85816b9ea359fe9821e6a92dbf4f7ca8b6b6fed6d49768aa1d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.81 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling libc v0.2.154 [INFO] [stderr] Compiling thiserror v1.0.59 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.92 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling log v0.4.21 [INFO] [stderr] Compiling bumpalo v3.16.0 [INFO] [stderr] Compiling serde v1.0.200 [INFO] [stderr] Compiling memchr v2.7.2 [INFO] [stderr] Compiling ucd-trie v0.1.6 [INFO] [stderr] Compiling wasm-bindgen v0.2.92 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling serde_json v1.0.116 [INFO] [stderr] Checking either v1.11.0 [INFO] [stderr] Compiling portable-atomic v1.6.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking ppv-lite86 v0.2.17 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling anyhow v1.0.82 [INFO] [stderr] Checking unicode-width v0.1.12 [INFO] [stderr] Checking ryu v1.0.17 [INFO] [stderr] Checking ascii v1.1.0 [INFO] [stderr] Checking httpdate v1.0.3 [INFO] [stderr] Checking chunked_transfer v1.5.0 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking half v1.8.3 [INFO] [stderr] Checking strsim v0.10.0 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking hound v3.5.1 [INFO] [stderr] Checking svg v0.17.0 [INFO] [stderr] Checking rust-analyzer v0.0.1 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking tiny_http v0.12.0 [INFO] [stderr] Checking getrandom v0.2.14 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Compiling quote v1.0.36 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking indicatif v0.17.8 [INFO] [stderr] Compiling syn v2.0.60 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking nanoid v0.4.0 [INFO] [stderr] Checking chrono-human-duration v0.1.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking midly v0.5.3 [INFO] [stderr] Compiling wasm-bindgen-backend v0.2.92 [INFO] [stderr] Compiling thiserror-impl v1.0.59 [INFO] [stderr] Compiling serde_derive v1.0.200 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.92 [INFO] [stderr] Compiling pest v2.7.10 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.92 [INFO] [stderr] Checking js-sys v0.3.69 [INFO] [stderr] Compiling pest_meta v2.7.10 [INFO] [stderr] Compiling pest_generator v2.7.10 [INFO] [stderr] Compiling pest_derive v2.7.10 [INFO] [stderr] Checking web-sys v0.3.69 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking docopt v1.1.1 [INFO] [stderr] Checking handlebars v5.1.2 [INFO] [stderr] Checking shapemaker v1.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'µ' [INFO] [stdout] --> src/midi.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | fn tempo_to_bpm(µs_per_beat: f32) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] = note: `#[warn(uncommon_codepoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'µ' [INFO] [stdout] --> src/midi.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | let delta_µs = now.tempo * delta as f32 / now.ticks_per_beat as f32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Context`, `LaterHookCondition`, and `RenderFunction` [INFO] [stdout] --> src/animation.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{Canvas, Context, LaterHookCondition, RenderFunction}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `console_log` [INFO] [stdout] --> src/web.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | macro_rules! console_log { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Add`, `Div`, `Range`, and `Sub` [INFO] [stdout] --> src/lib.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | use std::ops::{Add, Div, Range, Sub}; [INFO] [stdout] | ^^^ ^^^ ^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'µ' [INFO] [stdout] --> src/midi.rs:117:17 [INFO] [stdout] | [INFO] [stdout] 117 | fn tempo_to_bpm(µs_per_beat: f32) -> usize { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] = note: `#[warn(uncommon_codepoints)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: identifier contains a non normalized (NFKC) character: 'µ' [INFO] [stdout] --> src/midi.rs:213:13 [INFO] [stdout] | [INFO] [stdout] 213 | let delta_µs = now.tempo * delta as f32 / now.ticks_per_beat as f32; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this character is included in the Not_NFKC Unicode general security profile [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Context`, `LaterHookCondition`, and `RenderFunction` [INFO] [stdout] --> src/animation.rs:3:21 [INFO] [stdout] | [INFO] [stdout] 3 | use crate::{Canvas, Context, LaterHookCondition, RenderFunction}; [INFO] [stdout] | ^^^^^^^ ^^^^^^^^^^^^^^^^^^ ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `console_log` [INFO] [stdout] --> src/web.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 36 | macro_rules! console_log { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Add`, `Div`, `Range`, and `Sub` [INFO] [stdout] --> src/lib.rs:36:16 [INFO] [stdout] | [INFO] [stdout] 36 | use std::ops::{Add, Div, Range, Sub}; [INFO] [stdout] | ^^^ ^^^ ^^^^^ ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `spacing` [INFO] [stdout] --> src/fill.rs:75:51 [INFO] [stdout] | [INFO] [stdout] 75 | if let Fill::Hatched(color, _, thickness, spacing) = self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_spacing` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `spacing` [INFO] [stdout] --> src/fill.rs:75:51 [INFO] [stdout] | [INFO] [stdout] 75 | if let Fill::Hatched(color, _, thickness, spacing) = self { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_spacing` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opacity` [INFO] [stdout] --> src/web.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn render_image(opacity: f32, color: Color) -> Result<(), JsValue> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_opacity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/web.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn render_image(opacity: f32, color: Color) -> Result<(), JsValue> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `opacity` [INFO] [stdout] --> src/web.rs:42:21 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn render_image(opacity: f32, color: Color) -> Result<(), JsValue> { [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_opacity` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `color` [INFO] [stdout] --> src/web.rs:42:35 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn render_image(opacity: f32, color: Color) -> Result<(), JsValue> { [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_color` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spinner` is never read [INFO] [stdout] --> src/lib.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 188 | struct SpinState { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 189 | pub spinner: ProgressBar, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PATTERN_SIZE` is never used [INFO] [stdout] --> src/fill.rs:20:7 [INFO] [stdout] | [INFO] [stdout] 20 | const PATTERN_SIZE: usize = 8; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_kick_channel` is never used [INFO] [stdout] --> src/midi.rs:21:4 [INFO] [stdout] | [INFO] [stdout] 21 | fn is_kick_channel(name: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | std::fs::create_dir_all(&to); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 94 | let _ = std::fs::create_dir_all(&to); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | fs::write(to.join(name), format!("{:?}", stem)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 96 | let _ = fs::write(to.join(name), format!("{:?}", stem)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:31 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn start_animation(&mut self, duration: usize, animation: Animation) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | self.later_hooks.push(LaterHook { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 170 | | once: false, [INFO] [stdout] 171 | | when: Box::new(move |_, ctx, _| ms_range.contains(&ctx.ms)), [INFO] [stdout] 172 | | render_function: Box::new(move |canvas, ms| { [INFO] [stdout] ... | [INFO] [stdout] 175 | | }), [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:22 [INFO] [stdout] | [INFO] [stdout] 196 | let spinner = ProgressBar::new(0).with_style( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let thread_spinner = spinner.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let finished = Arc::new(Mutex::new(false)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let thread_finished = Arc::clone(&finished); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let spinner_thread = thread::spawn(move || { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | spinner: spinner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/animation.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(name: N, f: &'static AnimationUpdateFunction) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | update: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 42 | objects: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:44:36 [INFO] [stdout] | [INFO] [stdout] 44 | _render_cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 213 | let mut objects: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | _render_cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:270:28 [INFO] [stdout] | [INFO] [stdout] 249 | let mut objects: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | _render_cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:444:15 [INFO] [stdout] | [INFO] [stdout] 432 | let mut spawned = std::process::Command::new("magick") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | match spawned.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 522 | let mut svg = svg::Document::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | let mut defs = svg::node::element::Definitions::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | / svg.add(defs) [INFO] [stdout] 554 | | .set( [INFO] [stdout] 555 | | "viewBox", [INFO] [stdout] 556 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 563 | | .set("width", self.width()) [INFO] [stdout] 564 | | .set("height", self.height()) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn color(self, fill: Fill) -> ColoredObject { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | ColoredObject::from((self, Some(fill))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn filter(self, filter: Filter) -> ColoredObject { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ColoredObject::from((self, None)).filter(filter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 210 | let group = svg::node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | [INFO] [stdout] 212 | let rendered = match self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | group.set("data-object", id).add(rendered).set("style", css) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preview.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | let hbs = Handlebars::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / hbs.render_template( [INFO] [stdout] 22 | | &template, [INFO] [stdout] 23 | | &json!({ [INFO] [stdout] 24 | | "frames":frames, [INFO] [stdout] ... | [INFO] [stdout] 30 | | }), [INFO] [stdout] 31 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/preview.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | fs::write(output_file, contents); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 52 | let _ = fs::write(output_file, contents); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/preview.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / request.respond(tiny_http::Response::from_string(contents).with_header( [INFO] [stdout] 83 | | tiny_http::Header { [INFO] [stdout] 84 | | field: "Access-Control-Allow-Origin".parse().unwrap(), [INFO] [stdout] 85 | | value: "*".parse().unwrap(), [INFO] [stdout] 86 | | }, [INFO] [stdout] 87 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = request.respond(tiny_http::Response::from_string(contents).with_header( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 115 | let mut command = std::process::Command::new("ffmpeg"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | match command.output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn init(self, render_function: &'static RenderFunction) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 181 | | when: Box::new(move |_, context, _, _| context.frame == 0), [INFO] [stdout] 182 | | render_function: Box::new(render_function), [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:191:24 [INFO] [stdout] | [INFO] [stdout] 187 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 192 | | when: Box::new(move |_, context, _, _| context.marker() == marker_text), [INFO] [stdout] 193 | | render_function: Box::new(render_function), [INFO] [stdout] 194 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:198:24 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn each_beat(self, render_function: &'static RenderFunction) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 199 | | when: Box::new( [INFO] [stdout] 200 | | move |_, context, previous_rendered_beat, previous_rendered_frame| { [INFO] [stdout] 201 | | previous_rendered_frame != context.frame [INFO] [stdout] ... | [INFO] [stdout] 205 | | render_function: Box::new(render_function), [INFO] [stdout] 206 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:224:24 [INFO] [stdout] | [INFO] [stdout] 210 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 225 | | when: Box::new(move |_, context, _, _| context.beat_fractional % beats < 0.01), [INFO] [stdout] 226 | | render_function: Box::new(render_function), [INFO] [stdout] 227 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 241 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 246 | | when: Box::new(move |_, context, _, previous_rendered_frame| { [INFO] [stdout] 247 | | context.frame != previous_rendered_frame && context.frame % n == 0 [INFO] [stdout] 248 | | }), [INFO] [stdout] 249 | | render_function: Box::new(render_function), [INFO] [stdout] 250 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 255 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | / self.with_hook(Hook { [INFO] [stdout] 262 | | when: Box::new(move |_, context, _, _| { [INFO] [stdout] 263 | | context.stem(stem_name).amplitude_relative() > threshold [INFO] [stdout] 264 | | }), [INFO] [stdout] 265 | | render_function: Box::new(above_amplitude), [INFO] [stdout] 266 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:267:20 [INFO] [stdout] | [INFO] [stdout] 255 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | .with_hook(Hook { [INFO] [stdout] | ____________________^ [INFO] [stdout] 268 | | when: Box::new(move |_, context, _, _| { [INFO] [stdout] 269 | | context.stem(stem_name).amplitude_relative() <= threshold [INFO] [stdout] 270 | | }), [INFO] [stdout] 271 | | render_function: Box::new(below_amplitude), [INFO] [stdout] 272 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:281:24 [INFO] [stdout] | [INFO] [stdout] 277 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 282 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 283 | | stems [INFO] [stdout] 284 | | .split(',') [INFO] [stdout] ... | [INFO] [stdout] 288 | | render_function: Box::new(render_function), [INFO] [stdout] 289 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:298:24 [INFO] [stdout] | [INFO] [stdout] 294 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 299 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 300 | | stems [INFO] [stdout] 301 | | .split(',') [INFO] [stdout] ... | [INFO] [stdout] 305 | | render_function: Box::new(render_function), [INFO] [stdout] 306 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 311 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | / self.with_hook(Hook { [INFO] [stdout] 322 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 323 | | stems [INFO] [stdout] 324 | | .split(',') [INFO] [stdout] ... | [INFO] [stdout] 330 | | }), [INFO] [stdout] 331 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:332:20 [INFO] [stdout] | [INFO] [stdout] 311 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | .with_hook(Hook { [INFO] [stdout] | ____________________^ [INFO] [stdout] 333 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 334 | | stems.split(',').any(|stem_name| { [INFO] [stdout] 335 | | ctx.stem(stem_name).amplitude_relative() < cutoff_amplitude [INFO] [stdout] ... | [INFO] [stdout] 339 | | render_function: Box::new(move |canvas, _| canvas.remove_object(object_name)), [INFO] [stdout] 340 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | canvas.add_object(layer_name, object_name, object, fill); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 329 | let _ = canvas.add_object(layer_name, object_name, object, fill); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:348:24 [INFO] [stdout] | [INFO] [stdout] 344 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 349 | | when: Box::new(move |_, context, _, _| context.frame == frame), [INFO] [stdout] 350 | | render_function: Box::new(render_function), [INFO] [stdout] 351 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:359:24 [INFO] [stdout] | [INFO] [stdout] 355 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 360 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 361 | | ctx.ms >= ctx.duration_ms().max(seconds * 1000) - seconds * 1000 [INFO] [stdout] 362 | | }), [INFO] [stdout] 363 | | render_function: Box::new(render_function), [INFO] [stdout] 364 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:617:9 [INFO] [stdout] | [INFO] [stdout] 617 | remove_dir_all(self.frames_output_directory); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 617 | let _ = remove_dir_all(self.frames_output_directory); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:641:13 [INFO] [stdout] | [INFO] [stdout] 641 | / std::fs::write( [INFO] [stdout] 642 | | format!("{}/{}.svg", self.frames_output_directory, no), [INFO] [stdout] 643 | | &frame, [INFO] [stdout] 644 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 641 | let _ = std::fs::write( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:660:29 [INFO] [stdout] | [INFO] [stdout] 660 | / ... Video::::build_frame( [INFO] [stdout] 661 | | ... frame_svg.clone(), [INFO] [stdout] 662 | | ... *frame_no, [INFO] [stdout] 663 | | ... total_frames, [INFO] [stdout] ... | [INFO] [stdout] 666 | | ... resolution, [INFO] [stdout] 667 | | ... ); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 660 | let _ = Video::::build_frame( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/web.rs:12:66 [INFO] [stdout] | [INFO] [stdout] 12 | static WEB_CANVAS: Lazy> = Lazy::new(|| Mutex::new(Canvas::default_settings())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/web.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 183 | let window = web_sys::window().expect_throw("no global `window` exists"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | / window [INFO] [stdout] 185 | | .document() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `spinner` is never read [INFO] [stdout] --> src/lib.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 188 | struct SpinState { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] 189 | pub spinner: ProgressBar, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `main` is never used [INFO] [stdout] --> src/lib.rs:225:4 [INFO] [stdout] | [INFO] [stdout] 225 | fn main() {} [INFO] [stdout] | ^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `PATTERN_SIZE` is never used [INFO] [stdout] --> src/fill.rs:20:7 [INFO] [stdout] | [INFO] [stdout] 20 | const PATTERN_SIZE: usize = 8; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `is_kick_channel` is never used [INFO] [stdout] --> src/midi.rs:21:4 [INFO] [stdout] | [INFO] [stdout] 21 | fn is_kick_channel(name: &str) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:94:9 [INFO] [stdout] | [INFO] [stdout] 94 | std::fs::create_dir_all(&to); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] = note: `#[warn(unused_must_use)]` on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 94 | let _ = std::fs::create_dir_all(&to); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/lib.rs:96:13 [INFO] [stdout] | [INFO] [stdout] 96 | fs::write(to.join(name), format!("{:?}", stem)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 96 | let _ = fs::write(to.join(name), format!("{:?}", stem)); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:169:31 [INFO] [stdout] | [INFO] [stdout] 165 | pub fn start_animation(&mut self, duration: usize, animation: Animation) { [INFO] [stdout] | -------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 169 | self.later_hooks.push(LaterHook { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 170 | | once: false, [INFO] [stdout] 171 | | when: Box::new(move |_, ctx, _| ms_range.contains(&ctx.ms)), [INFO] [stdout] 172 | | render_function: Box::new(move |canvas, ms| { [INFO] [stdout] ... | [INFO] [stdout] 175 | | }), [INFO] [stdout] 176 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:213:22 [INFO] [stdout] | [INFO] [stdout] 196 | let spinner = ProgressBar::new(0).with_style( [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 201 | let thread_spinner = spinner.clone(); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 202 | let finished = Arc::new(Mutex::new(false)); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 203 | let thread_finished = Arc::clone(&finished); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 204 | let spinner_thread = thread::spawn(move || { [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | spinner: spinner.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/animation.rs:32:21 [INFO] [stdout] | [INFO] [stdout] 26 | pub fn new(name: N, f: &'static AnimationUpdateFunction) -> Self [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 32 | update: Box::new(f), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:42:30 [INFO] [stdout] | [INFO] [stdout] 42 | objects: HashMap::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:44:36 [INFO] [stdout] | [INFO] [stdout] 44 | _render_cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:235:28 [INFO] [stdout] | [INFO] [stdout] 213 | let mut objects: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 235 | _render_cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:270:28 [INFO] [stdout] | [INFO] [stdout] 249 | let mut objects: HashMap = HashMap::new(); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 270 | _render_cache: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:444:15 [INFO] [stdout] | [INFO] [stdout] 432 | let mut spawned = std::process::Command::new("magick") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 444 | match spawned.wait_with_output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/canvas.rs:553:9 [INFO] [stdout] | [INFO] [stdout] 522 | let mut svg = svg::Document::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 542 | let mut defs = svg::node::element::Definitions::new(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 553 | / svg.add(defs) [INFO] [stdout] 554 | | .set( [INFO] [stdout] 555 | | "viewBox", [INFO] [stdout] 556 | | format!( [INFO] [stdout] ... | [INFO] [stdout] 563 | | .set("width", self.width()) [INFO] [stdout] 564 | | .set("height", self.height()) [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects.rs:30:29 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn color(self, fill: Fill) -> ColoredObject { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 30 | ColoredObject::from((self, Some(fill))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn filter(self, filter: Filter) -> ColoredObject { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 34 | ColoredObject::from((self, None)).filter(filter) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/objects.rs:236:9 [INFO] [stdout] | [INFO] [stdout] 210 | let group = svg::node::element::Group::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 211 | [INFO] [stdout] 212 | let rendered = match self { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 236 | group.set("data-object", id).add(rendered).set("style", css) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/preview.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 20 | let hbs = Handlebars::new(); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | / hbs.render_template( [INFO] [stdout] 22 | | &template, [INFO] [stdout] 23 | | &json!({ [INFO] [stdout] 24 | | "frames":frames, [INFO] [stdout] ... | [INFO] [stdout] 30 | | }), [INFO] [stdout] 31 | | ) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/preview.rs:52:5 [INFO] [stdout] | [INFO] [stdout] 52 | fs::write(output_file, contents); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 52 | let _ = fs::write(output_file, contents); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 29 previous errors; 19 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/preview.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | / request.respond(tiny_http::Response::from_string(contents).with_header( [INFO] [stdout] 83 | | tiny_http::Header { [INFO] [stdout] 84 | | field: "Access-Control-Allow-Origin".parse().unwrap(), [INFO] [stdout] 85 | | value: "*".parse().unwrap(), [INFO] [stdout] 86 | | }, [INFO] [stdout] 87 | | )); [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 82 | let _ = request.respond(tiny_http::Response::from_string(contents).with_header( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 115 | let mut command = std::process::Command::new("ffmpeg"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 142 | match command.output() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 179 | pub fn init(self, render_function: &'static RenderFunction) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 181 | | when: Box::new(move |_, context, _, _| context.frame == 0), [INFO] [stdout] 182 | | render_function: Box::new(render_function), [INFO] [stdout] 183 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:191:24 [INFO] [stdout] | [INFO] [stdout] 187 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 191 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 192 | | when: Box::new(move |_, context, _, _| context.marker() == marker_text), [INFO] [stdout] 193 | | render_function: Box::new(render_function), [INFO] [stdout] 194 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:198:24 [INFO] [stdout] | [INFO] [stdout] 197 | pub fn each_beat(self, render_function: &'static RenderFunction) -> Self { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 198 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 199 | | when: Box::new( [INFO] [stdout] 200 | | move |_, context, previous_rendered_beat, previous_rendered_frame| { [INFO] [stdout] 201 | | previous_rendered_frame != context.frame [INFO] [stdout] ... | [INFO] [stdout] 205 | | render_function: Box::new(render_function), [INFO] [stdout] 206 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:224:24 [INFO] [stdout] | [INFO] [stdout] 210 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 224 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 225 | | when: Box::new(move |_, context, _, _| context.beat_fractional % beats < 0.01), [INFO] [stdout] 226 | | render_function: Box::new(render_function), [INFO] [stdout] 227 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:245:24 [INFO] [stdout] | [INFO] [stdout] 241 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 245 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 246 | | when: Box::new(move |_, context, _, previous_rendered_frame| { [INFO] [stdout] 247 | | context.frame != previous_rendered_frame && context.frame % n == 0 [INFO] [stdout] 248 | | }), [INFO] [stdout] 249 | | render_function: Box::new(render_function), [INFO] [stdout] 250 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:261:9 [INFO] [stdout] | [INFO] [stdout] 255 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | / self.with_hook(Hook { [INFO] [stdout] 262 | | when: Box::new(move |_, context, _, _| { [INFO] [stdout] 263 | | context.stem(stem_name).amplitude_relative() > threshold [INFO] [stdout] 264 | | }), [INFO] [stdout] 265 | | render_function: Box::new(above_amplitude), [INFO] [stdout] 266 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:267:20 [INFO] [stdout] | [INFO] [stdout] 255 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 267 | .with_hook(Hook { [INFO] [stdout] | ____________________^ [INFO] [stdout] 268 | | when: Box::new(move |_, context, _, _| { [INFO] [stdout] 269 | | context.stem(stem_name).amplitude_relative() <= threshold [INFO] [stdout] 270 | | }), [INFO] [stdout] 271 | | render_function: Box::new(below_amplitude), [INFO] [stdout] 272 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:281:24 [INFO] [stdout] | [INFO] [stdout] 277 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 281 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 282 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 283 | | stems [INFO] [stdout] 284 | | .split(',') [INFO] [stdout] ... | [INFO] [stdout] 288 | | render_function: Box::new(render_function), [INFO] [stdout] 289 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:298:24 [INFO] [stdout] | [INFO] [stdout] 294 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 298 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 299 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 300 | | stems [INFO] [stdout] 301 | | .split(',') [INFO] [stdout] ... | [INFO] [stdout] 305 | | render_function: Box::new(render_function), [INFO] [stdout] 306 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:321:9 [INFO] [stdout] | [INFO] [stdout] 311 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 321 | / self.with_hook(Hook { [INFO] [stdout] 322 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 323 | | stems [INFO] [stdout] 324 | | .split(',') [INFO] [stdout] ... | [INFO] [stdout] 330 | | }), [INFO] [stdout] 331 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:332:20 [INFO] [stdout] | [INFO] [stdout] 311 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 332 | .with_hook(Hook { [INFO] [stdout] | ____________________^ [INFO] [stdout] 333 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 334 | | stems.split(',').any(|stem_name| { [INFO] [stdout] 335 | | ctx.stem(stem_name).amplitude_relative() < cutoff_amplitude [INFO] [stdout] ... | [INFO] [stdout] 339 | | render_function: Box::new(move |canvas, _| canvas.remove_object(object_name)), [INFO] [stdout] 340 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:329:17 [INFO] [stdout] | [INFO] [stdout] 329 | canvas.add_object(layer_name, object_name, object, fill); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 329 | let _ = canvas.add_object(layer_name, object_name, object, fill); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:348:24 [INFO] [stdout] | [INFO] [stdout] 344 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 348 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 349 | | when: Box::new(move |_, context, _, _| context.frame == frame), [INFO] [stdout] 350 | | render_function: Box::new(render_function), [INFO] [stdout] 351 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/video.rs:359:24 [INFO] [stdout] | [INFO] [stdout] 355 | self, [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 359 | self.with_hook(Hook { [INFO] [stdout] | ________________________^ [INFO] [stdout] 360 | | when: Box::new(move |_, ctx, _, _| { [INFO] [stdout] 361 | | ctx.ms >= ctx.duration_ms().max(seconds * 1000) - seconds * 1000 [INFO] [stdout] 362 | | }), [INFO] [stdout] 363 | | render_function: Box::new(render_function), [INFO] [stdout] 364 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:617:9 [INFO] [stdout] | [INFO] [stdout] 617 | remove_dir_all(self.frames_output_directory); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 617 | let _ = remove_dir_all(self.frames_output_directory); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:641:13 [INFO] [stdout] | [INFO] [stdout] 641 | / std::fs::write( [INFO] [stdout] 642 | | format!("{}/{}.svg", self.frames_output_directory, no), [INFO] [stdout] 643 | | &frame, [INFO] [stdout] 644 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 641 | let _ = std::fs::write( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `Result` that must be used [INFO] [stdout] --> src/video.rs:660:29 [INFO] [stdout] | [INFO] [stdout] 660 | / ... Video::::build_frame( [INFO] [stdout] 661 | | ... frame_svg.clone(), [INFO] [stdout] 662 | | ... *frame_no, [INFO] [stdout] 663 | | ... total_frames, [INFO] [stdout] ... | [INFO] [stdout] 666 | | ... resolution, [INFO] [stdout] 667 | | ... ); [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 660 | let _ = Video::::build_frame( [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/web.rs:12:66 [INFO] [stdout] | [INFO] [stdout] 12 | static WEB_CANVAS: Lazy> = Lazy::new(|| Mutex::new(Canvas::default_settings())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/web.rs:184:5 [INFO] [stdout] | [INFO] [stdout] 183 | let window = web_sys::window().expect_throw("no global `window` exists"); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 184 | / window [INFO] [stdout] 185 | | .document() [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shapemaker` (lib test) due to 30 previous errors; 19 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: aborting due to 29 previous errors; 20 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shapemaker` (lib) due to 30 previous errors; 20 warnings emitted [INFO] running `Command { std: "docker" "inspect" "580b0825a5be2a85816b9ea359fe9821e6a92dbf4f7ca8b6b6fed6d49768aa1d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "580b0825a5be2a85816b9ea359fe9821e6a92dbf4f7ca8b6b6fed6d49768aa1d", kill_on_drop: false }` [INFO] [stdout] 580b0825a5be2a85816b9ea359fe9821e6a92dbf4f7ca8b6b6fed6d49768aa1d