[INFO] fetching crate shapefile 0.6.0... [INFO] checking shapefile-0.6.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shapefile 0.6.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate shapefile 0.6.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shapefile 0.6.0 [INFO] finished tweaking crates.io crate shapefile 0.6.0 [INFO] tweaked toml for crates.io crate shapefile 0.6.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 19 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5faa306c8777b974ed4d52c7f86bc4bd1ca72000829440e49bc5e98ecf111043 [INFO] running `Command { std: "docker" "start" "-a" "5faa306c8777b974ed4d52c7f86bc4bd1ca72000829440e49bc5e98ecf111043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5faa306c8777b974ed4d52c7f86bc4bd1ca72000829440e49bc5e98ecf111043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5faa306c8777b974ed4d52c7f86bc4bd1ca72000829440e49bc5e98ecf111043", kill_on_drop: false }` [INFO] [stdout] 5faa306c8777b974ed4d52c7f86bc4bd1ca72000829440e49bc5e98ecf111043 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e1f7dd442846f46bac3ad085dd80f77b8d7cce1e62644b8fdb40350c35e74364 [INFO] running `Command { std: "docker" "start" "-a" "e1f7dd442846f46bac3ad085dd80f77b8d7cce1e62644b8fdb40350c35e74364", kill_on_drop: false }` [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking dbase v0.5.0 [INFO] [stderr] Checking shapefile v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 108 | let shape = S::read_from(&mut source, record_size)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok((hdr, shape)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:182:14 [INFO] [stdout] | [INFO] [stdout] 172 | let shape = match self.shape_iter.next()? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Err(e) => return Some(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Ok(shp) => shp, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let record = match self.record_iter.next()? { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | Err(e) => return Some(Err(Error::DbaseError(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Ok(rcd) => rcd, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Some(Ok((shape, record))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn new(mut source: T) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 221 | | source, [INFO] [stdout] 222 | | header, [INFO] [stdout] 223 | | shapes_index: None, [INFO] [stdout] 224 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn with_shx(mut source: T, shx_source: ShxSource) -> Result [INFO] [stdout] | ------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 251 | | source, [INFO] [stdout] 252 | | header, [INFO] [stdout] 253 | | shapes_index, [INFO] [stdout] 254 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:665:5 [INFO] [stdout] | [INFO] [stdout] 663 | path: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 664 | ) -> Result, Error> { [INFO] [stdout] 665 | Reader::from_path(path).and_then(|mut rdr| rdr.read_as::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:687:5 [INFO] [stdout] | [INFO] [stdout] 686 | pub fn read_shapes_as, S: ReadableShape>(path: T) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 687 | ShapeReader::from_path(path).and_then(|rdr| rdr.read_as::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut bbox = GenericBBox::::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let parts = Vec::>::with_capacity(num_parts as usize); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 198 | | num_points, [INFO] [stdout] 199 | | num_parts, [INFO] [stdout] 200 | | parts_array, [INFO] [stdout] ... | [INFO] [stdout] 203 | | bbox, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 351 | pub(crate) fn write_point_shape(self) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | / self.write_bbox_xy() [INFO] [stdout] 353 | | .and_then(|wrt| wrt.write_num_parts()) [INFO] [stdout] 354 | | .and_then(|wrt| wrt.write_num_points()) [INFO] [stdout] 355 | | .and_then(|wrt| wrt.write_parts_array()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 365 | pub(crate) fn write_point_m_shape(self) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | / self.write_bbox_xy() [INFO] [stdout] 367 | | .and_then(|wrt| wrt.write_num_parts()) [INFO] [stdout] 368 | | .and_then(|wrt| wrt.write_num_points()) [INFO] [stdout] 369 | | .and_then(|wrt| wrt.write_parts_array()) [INFO] [stdout] 370 | | .and_then(|wrt| wrt.write_xy()) [INFO] [stdout] 371 | | .and_then(|wrt| wrt.write_bbox_m_range()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 381 | pub(crate) fn write_point_z_shape(self) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | / self.write_bbox_xy() [INFO] [stdout] 383 | | .and_then(|wrt| wrt.write_num_parts()) [INFO] [stdout] 384 | | .and_then(|wrt| wrt.write_num_points()) [INFO] [stdout] 385 | | .and_then(|wrt| wrt.write_parts_array()) [INFO] [stdout] ... | [INFO] [stdout] 388 | | .and_then(|wrt| wrt.write_zs()) [INFO] [stdout] 389 | | .and_then(|wrt| wrt.write_bbox_m_range()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new(shp_dest: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | shx_dest: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn with_shx(shp_dest: T, shx_dest: T) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | shx_dest: Some(shx_dest), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let shp_file = BufWriter::new(File::create(shp_path)?); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let shx_file = BufWriter::new(File::create(shx_path)?); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | [INFO] [stdout] 233 | Ok(Self::with_shx(shp_file, shx_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 339 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | table_builder: TableWriterBuilder, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | ) -> Result { [INFO] [stdout] 342 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 343 | | shape_writer: ShapeWriter::from_path(path.as_ref())?, [INFO] [stdout] 344 | | dbase_writer: table_builder [INFO] [stdout] 345 | | .build_with_file_dest(path.as_ref().with_extension("dbf"))?, [INFO] [stdout] 346 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 350 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | table_info: dbase::TableInfo, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | ) -> Result { [INFO] [stdout] 353 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 354 | | shape_writer: ShapeWriter::from_path(path.as_ref())?, [INFO] [stdout] 355 | | dbase_writer: dbase::TableWriterBuilder::from_table_info(table_info) [INFO] [stdout] 356 | | .build_with_file_dest(path.as_ref().with_extension("dbf"))?, [INFO] [stdout] 357 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shapefile` (lib) due to 16 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:109:8 [INFO] [stdout] | [INFO] [stdout] 108 | let shape = S::read_from(&mut source, record_size)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 109 | Ok((hdr, shape)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:182:14 [INFO] [stdout] | [INFO] [stdout] 172 | let shape = match self.shape_iter.next()? { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 173 | Err(e) => return Some(Err(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 174 | Ok(shp) => shp, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let record = match self.record_iter.next()? { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | Err(e) => return Some(Err(Error::DbaseError(e))), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 179 | Ok(rcd) => rcd, [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 182 | Some(Ok((shape, record))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:220:12 [INFO] [stdout] | [INFO] [stdout] 217 | pub fn new(mut source: T) -> Result { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 220 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 221 | | source, [INFO] [stdout] 222 | | header, [INFO] [stdout] 223 | | shapes_index: None, [INFO] [stdout] 224 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:250:12 [INFO] [stdout] | [INFO] [stdout] 243 | pub fn with_shx(mut source: T, shx_source: ShxSource) -> Result [INFO] [stdout] | ------------- --------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 250 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 251 | | source, [INFO] [stdout] 252 | | header, [INFO] [stdout] 253 | | shapes_index, [INFO] [stdout] 254 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:665:5 [INFO] [stdout] | [INFO] [stdout] 663 | path: T, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 664 | ) -> Result, Error> { [INFO] [stdout] 665 | Reader::from_path(path).and_then(|mut rdr| rdr.read_as::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/reader.rs:687:5 [INFO] [stdout] | [INFO] [stdout] 686 | pub fn read_shapes_as, S: ReadableShape>(path: T) -> Result, Error> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 687 | ShapeReader::from_path(path).and_then(|rdr| rdr.read_as::()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:197:12 [INFO] [stdout] | [INFO] [stdout] 191 | let mut bbox = GenericBBox::::default(); [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | let parts = Vec::>::with_capacity(num_parts as usize); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 197 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 198 | | num_points, [INFO] [stdout] 199 | | num_parts, [INFO] [stdout] 200 | | parts_array, [INFO] [stdout] ... | [INFO] [stdout] 203 | | bbox, [INFO] [stdout] 204 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:352:9 [INFO] [stdout] | [INFO] [stdout] 351 | pub(crate) fn write_point_shape(self) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | / self.write_bbox_xy() [INFO] [stdout] 353 | | .and_then(|wrt| wrt.write_num_parts()) [INFO] [stdout] 354 | | .and_then(|wrt| wrt.write_num_points()) [INFO] [stdout] 355 | | .and_then(|wrt| wrt.write_parts_array()) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:366:9 [INFO] [stdout] | [INFO] [stdout] 365 | pub(crate) fn write_point_m_shape(self) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | / self.write_bbox_xy() [INFO] [stdout] 367 | | .and_then(|wrt| wrt.write_num_parts()) [INFO] [stdout] 368 | | .and_then(|wrt| wrt.write_num_points()) [INFO] [stdout] 369 | | .and_then(|wrt| wrt.write_parts_array()) [INFO] [stdout] 370 | | .and_then(|wrt| wrt.write_xy()) [INFO] [stdout] 371 | | .and_then(|wrt| wrt.write_bbox_m_range()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/record/io.rs:382:9 [INFO] [stdout] | [INFO] [stdout] 381 | pub(crate) fn write_point_z_shape(self) -> std::io::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 382 | / self.write_bbox_xy() [INFO] [stdout] 383 | | .and_then(|wrt| wrt.write_num_parts()) [INFO] [stdout] 384 | | .and_then(|wrt| wrt.write_num_points()) [INFO] [stdout] 385 | | .and_then(|wrt| wrt.write_parts_array()) [INFO] [stdout] ... | [INFO] [stdout] 388 | | .and_then(|wrt| wrt.write_zs()) [INFO] [stdout] 389 | | .and_then(|wrt| wrt.write_bbox_m_range()) [INFO] [stdout] | |_____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:61:23 [INFO] [stdout] | [INFO] [stdout] 58 | pub fn new(shp_dest: T) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 61 | shx_dest: None, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:70:23 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn with_shx(shp_dest: T, shx_dest: T) -> Self { [INFO] [stdout] | ----------- ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 70 | shx_dest: Some(shx_dest), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:233:12 [INFO] [stdout] | [INFO] [stdout] 226 | pub fn from_path>(path: P) -> Result { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let shp_file = BufWriter::new(File::create(shp_path)?); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 231 | let shx_file = BufWriter::new(File::create(shx_path)?); [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 232 | [INFO] [stdout] 233 | Ok(Self::with_shx(shp_file, shx_file)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:342:12 [INFO] [stdout] | [INFO] [stdout] 339 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 340 | table_builder: TableWriterBuilder, [INFO] [stdout] | --------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 341 | ) -> Result { [INFO] [stdout] 342 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 343 | | shape_writer: ShapeWriter::from_path(path.as_ref())?, [INFO] [stdout] 344 | | dbase_writer: table_builder [INFO] [stdout] 345 | | .build_with_file_dest(path.as_ref().with_extension("dbf"))?, [INFO] [stdout] 346 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/writer.rs:353:12 [INFO] [stdout] | [INFO] [stdout] 350 | path: P, [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 351 | table_info: dbase::TableInfo, [INFO] [stdout] | ---------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 352 | ) -> Result { [INFO] [stdout] 353 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 354 | | shape_writer: ShapeWriter::from_path(path.as_ref())?, [INFO] [stdout] 355 | | dbase_writer: dbase::TableWriterBuilder::from_table_info(table_info) [INFO] [stdout] 356 | | .build_with_file_dest(path.as_ref().with_extension("dbf"))?, [INFO] [stdout] 357 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shapefile` (lib test) due to 16 previous errors [INFO] running `Command { std: "docker" "inspect" "e1f7dd442846f46bac3ad085dd80f77b8d7cce1e62644b8fdb40350c35e74364", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1f7dd442846f46bac3ad085dd80f77b8d7cce1e62644b8fdb40350c35e74364", kill_on_drop: false }` [INFO] [stdout] e1f7dd442846f46bac3ad085dd80f77b8d7cce1e62644b8fdb40350c35e74364