[INFO] fetching crate shale 0.1.9... [INFO] checking shale-0.1.9 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shale 0.1.9 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate shale 0.1.9 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shale 0.1.9 [INFO] finished tweaking crates.io crate shale 0.1.9 [INFO] tweaked toml for crates.io crate shale 0.1.9 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 33 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 033823889b94216f6060a8d220f56e14d8348875a3a2b4418d45f2e4d9bb6242 [INFO] running `Command { std: "docker" "start" "-a" "033823889b94216f6060a8d220f56e14d8348875a3a2b4418d45f2e4d9bb6242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "033823889b94216f6060a8d220f56e14d8348875a3a2b4418d45f2e4d9bb6242", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "033823889b94216f6060a8d220f56e14d8348875a3a2b4418d45f2e4d9bb6242", kill_on_drop: false }` [INFO] [stdout] 033823889b94216f6060a8d220f56e14d8348875a3a2b4418d45f2e4d9bb6242 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 76a58c37093514adc6163de3b661f83d4c4171994c29ac784e8256f023972fda [INFO] running `Command { std: "docker" "start" "-a" "76a58c37093514adc6163de3b661f83d4c4171994c29ac784e8256f023972fda", kill_on_drop: false }` [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking ahash v0.8.11 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking lru v0.12.4 [INFO] [stderr] Checking shale v0.1.9 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:12 [INFO] [stdout] | [INFO] [stdout] 331 | let decoded = T::hydrate(offset, space)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 333 | | offset, [INFO] [stdout] 334 | | decoded, [INFO] [stdout] 335 | | mem: space.get_shared().ok_or(ShaleError::LinearMemStoreError)?, [INFO] [stdout] 336 | | len_limit, [INFO] [stdout] 337 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:12 [INFO] [stdout] | [INFO] [stdout] 342 | offset: u64, len_limit: u64, decoded: T, space: &dyn MemStore, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | ) -> Result { [INFO] [stdout] 344 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 345 | | offset, [INFO] [stdout] 346 | | decoded, [INFO] [stdout] 347 | | mem: space.get_shared().ok_or(ShaleError::LinearMemStoreError)?, [INFO] [stdout] 348 | | len_limit, [INFO] [stdout] 349 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 365 | store: &dyn MemStore, addr: u64, len_limit: u64, decoded: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | ) -> Result, ShaleError> { [INFO] [stdout] 367 | Ok(Obj::from_typed_view(Box::new(Self::from_hydrated( [INFO] [stdout] | ____________^ [INFO] [stdout] 368 | | addr, len_limit, decoded, store, [INFO] [stdout] 369 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:332:12 [INFO] [stdout] | [INFO] [stdout] 331 | let decoded = T::hydrate(offset, space)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 332 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 333 | | offset, [INFO] [stdout] 334 | | decoded, [INFO] [stdout] 335 | | mem: space.get_shared().ok_or(ShaleError::LinearMemStoreError)?, [INFO] [stdout] 336 | | len_limit, [INFO] [stdout] 337 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 375 | offset: u64, len_limit: u64, decoded: T, space: &dyn MemStore, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | ) -> Result { [INFO] [stdout] 377 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 378 | | offset, [INFO] [stdout] 379 | | decoded, [INFO] [stdout] 380 | | mem: space.get_shared().ok_or(ShaleError::LinearMemStoreError)?, [INFO] [stdout] 381 | | len_limit, [INFO] [stdout] 382 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:344:12 [INFO] [stdout] | [INFO] [stdout] 342 | offset: u64, len_limit: u64, decoded: T, space: &dyn MemStore, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | ) -> Result { [INFO] [stdout] 344 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 345 | | offset, [INFO] [stdout] 346 | | decoded, [INFO] [stdout] 347 | | mem: space.get_shared().ok_or(ShaleError::LinearMemStoreError)?, [INFO] [stdout] 348 | | len_limit, [INFO] [stdout] 349 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:367:12 [INFO] [stdout] | [INFO] [stdout] 365 | store: &dyn MemStore, addr: u64, len_limit: u64, decoded: T, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 366 | ) -> Result, ShaleError> { [INFO] [stdout] 367 | Ok(Obj::from_typed_view(Box::new(Self::from_hydrated( [INFO] [stdout] | ____________^ [INFO] [stdout] 368 | | addr, len_limit, decoded, store, [INFO] [stdout] 369 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 386 | s: &Obj, offset: u64, length: u64, decoded: U, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let r = Box::new(MummyObj::new_from_slice( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | Ok(Obj { [INFO] [stdout] | ____________^ [INFO] [stdout] 399 | | value: r, [INFO] [stdout] 400 | | dirty: None, [INFO] [stdout] 401 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:377:12 [INFO] [stdout] | [INFO] [stdout] 375 | offset: u64, len_limit: u64, decoded: T, space: &dyn MemStore, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 376 | ) -> Result { [INFO] [stdout] 377 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 378 | | offset, [INFO] [stdout] 379 | | decoded, [INFO] [stdout] 380 | | mem: space.get_shared().ok_or(ShaleError::LinearMemStoreError)?, [INFO] [stdout] 381 | | len_limit, [INFO] [stdout] 382 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:398:12 [INFO] [stdout] | [INFO] [stdout] 386 | s: &Obj, offset: u64, length: u64, decoded: U, [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 392 | let r = Box::new(MummyObj::new_from_slice( [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 398 | Ok(Obj { [INFO] [stdout] | ____________^ [INFO] [stdout] 399 | | value: r, [INFO] [stdout] 400 | | dirty: None, [INFO] [stdout] 401 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:554:20 [INFO] [stdout] | [INFO] [stdout] 550 | pub fn put(&self, inner: Obj) -> ObjRef { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 554 | inner: Some(inner), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 550 | pub fn put(&self, inner: Obj) -> ObjRef { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 555 | cache: Self(self.0.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:554:20 [INFO] [stdout] | [INFO] [stdout] 550 | pub fn put(&self, inner: Obj) -> ObjRef { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 554 | inner: Some(inner), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compact.rs:627:12 [INFO] [stdout] | [INFO] [stdout] 625 | let h = [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 626 | inner.get_header(ObjPtr::new(ptr.addr() - CompactHeader::MSIZE))?; [INFO] [stdout] 627 | Ok(inner [INFO] [stdout] | ____________^ [INFO] [stdout] 628 | | .obj_cache [INFO] [stdout] 629 | | .put(inner.get_data_ref(ptr, h.payload_size)?)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:555:20 [INFO] [stdout] | [INFO] [stdout] 550 | pub fn put(&self, inner: Obj) -> ObjRef { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 555 | cache: Self(self.0.clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/compact.rs:627:12 [INFO] [stdout] | [INFO] [stdout] 625 | let h = [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 626 | inner.get_header(ObjPtr::new(ptr.addr() - CompactHeader::MSIZE))?; [INFO] [stdout] 627 | Ok(inner [INFO] [stdout] | ____________^ [INFO] [stdout] 628 | | .obj_cache [INFO] [stdout] 629 | | .put(inner.get_data_ref(ptr, h.payload_size)?)) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |__________________________________________________________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 8 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shale` (lib test) due to 9 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `shale` (lib) due to 9 previous errors [INFO] running `Command { std: "docker" "inspect" "76a58c37093514adc6163de3b661f83d4c4171994c29ac784e8256f023972fda", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "76a58c37093514adc6163de3b661f83d4c4171994c29ac784e8256f023972fda", kill_on_drop: false }` [INFO] [stdout] 76a58c37093514adc6163de3b661f83d4c4171994c29ac784e8256f023972fda