[INFO] fetching crate shalc 0.1.0... [INFO] checking shalc-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shalc 0.1.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate shalc 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shalc 0.1.0 [INFO] finished tweaking crates.io crate shalc 0.1.0 [INFO] tweaked toml for crates.io crate shalc 0.1.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 7 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 74f45aacbe55ad1ded2dca090437a0c2681e9ccdbbb0179785cc005a677b08dd [INFO] running `Command { std: "docker" "start" "-a" "74f45aacbe55ad1ded2dca090437a0c2681e9ccdbbb0179785cc005a677b08dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "74f45aacbe55ad1ded2dca090437a0c2681e9ccdbbb0179785cc005a677b08dd", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "74f45aacbe55ad1ded2dca090437a0c2681e9ccdbbb0179785cc005a677b08dd", kill_on_drop: false }` [INFO] [stdout] 74f45aacbe55ad1ded2dca090437a0c2681e9ccdbbb0179785cc005a677b08dd [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cbf1376803989fa13031e5e461f31b60c27b80bc83ef098e383c09835815b2ab [INFO] running `Command { std: "docker" "start" "-a" "cbf1376803989fa13031e5e461f31b60c27b80bc83ef098e383c09835815b2ab", kill_on_drop: false }` [INFO] [stderr] Compiling slog v2.7.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking slog-scope v4.4.0 [INFO] [stderr] Checking slog-stdlog v4.1.1 [INFO] [stderr] Checking shalc v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused variable: `prev_local_calcs` [INFO] [stdout] --> src/lib.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | prev_local_calcs: &mut Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_prev_local_calcs` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `local_calcs` [INFO] [stdout] --> src/lib.rs:378:30 [INFO] [stdout] | [INFO] [stdout] 378 | fn update(&mut self, local_calcs: &mut Option) -> calculation::State { [INFO] [stdout] | ^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_local_calcs` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn start(mut self) -> JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | trace!(self.logger, "Shalc starting"); [INFO] [stdout] 171 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 172 | | trace!(self.logger, "calculation thread spawned"); [INFO] [stdout] 173 | | let mut local_calcs = None; [INFO] [stdout] 174 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shalc` (lib test) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:171:23 [INFO] [stdout] | [INFO] [stdout] 169 | pub fn start(mut self) -> JoinHandle<()> { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 170 | trace!(self.logger, "Shalc starting"); [INFO] [stdout] 171 | thread::spawn(move || { [INFO] [stdout] | _______________________^ [INFO] [stdout] 172 | | trace!(self.logger, "calculation thread spawned"); [INFO] [stdout] 173 | | let mut local_calcs = None; [INFO] [stdout] 174 | | loop { [INFO] [stdout] ... | [INFO] [stdout] 189 | | } [INFO] [stdout] 190 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shalc` (lib) due to 2 previous errors [INFO] running `Command { std: "docker" "inspect" "cbf1376803989fa13031e5e461f31b60c27b80bc83ef098e383c09835815b2ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cbf1376803989fa13031e5e461f31b60c27b80bc83ef098e383c09835815b2ab", kill_on_drop: false }` [INFO] [stdout] cbf1376803989fa13031e5e461f31b60c27b80bc83ef098e383c09835815b2ab