[INFO] fetching crate shai 0.2.0... [INFO] checking shai-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate shai 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate shai 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate shai 0.2.0 [INFO] finished tweaking crates.io crate shai 0.2.0 [INFO] tweaked toml for crates.io crate shai 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate shai 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f5c389523c40cb055523cd5e22654c7e36075adac6c8fbda7d4382e75e06992 [INFO] running `Command { std: "docker" "start" "-a" "9f5c389523c40cb055523cd5e22654c7e36075adac6c8fbda7d4382e75e06992", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f5c389523c40cb055523cd5e22654c7e36075adac6c8fbda7d4382e75e06992", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f5c389523c40cb055523cd5e22654c7e36075adac6c8fbda7d4382e75e06992", kill_on_drop: false }` [INFO] [stdout] 9f5c389523c40cb055523cd5e22654c7e36075adac6c8fbda7d4382e75e06992 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2b757a2a635735a62e8fb29aa499c859fa9afb257524645c04e7325011242be3 [INFO] running `Command { std: "docker" "start" "-a" "2b757a2a635735a62e8fb29aa499c859fa9afb257524645c04e7325011242be3", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Compiling futures-core v0.3.28 [INFO] [stderr] Checking pin-project-lite v0.2.12 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Compiling pkg-config v0.3.27 [INFO] [stderr] Compiling slab v0.4.8 [INFO] [stderr] Compiling futures-channel v0.3.28 [INFO] [stderr] Compiling futures-task v0.3.28 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Checking futures-sink v0.3.28 [INFO] [stderr] Checking bytes v1.4.0 [INFO] [stderr] Compiling futures-util v0.3.28 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Checking futures-io v0.3.28 [INFO] [stderr] Compiling parking_lot_core v0.9.8 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Checking tracing-core v0.1.31 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Compiling rustix v0.38.8 [INFO] [stderr] Compiling serde v1.0.183 [INFO] [stderr] Checking smallvec v1.11.0 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Compiling openssl v0.10.56 [INFO] [stderr] Checking mio v0.8.8 [INFO] [stderr] Checking socket2 v0.5.3 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Compiling cc v1.0.82 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking signal-hook-registry v1.4.1 [INFO] [stderr] Checking tracing v0.1.37 [INFO] [stderr] Checking http v0.2.9 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Compiling serde_derive v1.0.183 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking signal-hook-mio v0.2.3 [INFO] [stderr] Checking parking_lot v0.12.1 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking try-lock v0.2.4 [INFO] [stderr] Checking percent-encoding v2.3.0 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking form_urlencoded v1.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.1 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Checking socket2 v0.4.9 [INFO] [stderr] Compiling serde_json v1.0.105 [INFO] [stderr] Compiling openssl-sys v0.9.91 [INFO] [stderr] Checking anstyle v1.0.1 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Checking unicode-bidi v0.3.13 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking anstyle-query v1.0.0 [INFO] [stderr] Checking aho-corasick v1.0.4 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking num_threads v0.1.6 [INFO] [stderr] Checking anstream v0.3.2 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking time-core v0.1.1 [INFO] [stderr] Checking idna v0.4.0 [INFO] [stderr] Checking deranged v0.3.7 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking clap_lex v0.5.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Compiling thiserror v1.0.46 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking clap_builder v4.3.21 [INFO] [stderr] Checking time v0.3.25 [INFO] [stderr] Checking url v2.4.0 [INFO] [stderr] Checking crossterm v0.26.1 [INFO] [stderr] Checking crossterm v0.27.0 [INFO] [stderr] Checking encoding_rs v0.8.32 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking base64 v0.21.2 [INFO] [stderr] Compiling indoc v2.0.3 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking unicode-segmentation v1.10.1 [INFO] [stderr] Checking mime v0.3.17 [INFO] [stderr] Checking ipnet v2.8.0 [INFO] [stderr] Checking unsafe-libyaml v0.2.9 [INFO] [stderr] Checking eventsource-stream v0.2.3 [INFO] [stderr] Checking tui-input v0.8.0 [INFO] [stderr] Checking ratatui v0.22.0 [INFO] [stderr] Compiling futures-macro v0.3.28 [INFO] [stderr] Compiling tokio-macros v2.1.0 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling clap_derive v4.3.12 [INFO] [stderr] Compiling thiserror-impl v1.0.46 [INFO] [stderr] Checking serde_yaml v0.9.25 [INFO] [stderr] Checking tokio v1.31.0 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Checking clap v4.3.21 [INFO] [stderr] Checking futures-executor v0.3.28 [INFO] [stderr] Checking futures v0.3.28 [INFO] [stderr] Checking tokio-util v0.7.8 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking h2 v0.3.20 [INFO] [stderr] Checking hyper v0.14.27 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking reqwest v0.11.18 [INFO] [stderr] Checking shai v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:46 [INFO] [stdout] | [INFO] [stdout] 102 | .map_err(|err| ModelError::Error(Box::new(err))), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:455:12 [INFO] [stdout] | [INFO] [stdout] 443 | let mut stdout = io::stdout().lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | crossterm::execute!(stdout, EnterAlternateScreen)?; [INFO] [stdout] 445 | let backend = CrosstermBackend::new(stdout); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | let term = Terminal::new(backend)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | Ok(ShaiUI { [INFO] [stdout] | ____________^ [INFO] [stdout] 456 | | args, [INFO] [stdout] 457 | | term, [INFO] [stdout] 458 | | layout: Layout::InputResponse, [INFO] [stdout] ... | [INFO] [stdout] 464 | | response_focus: Focus::MainResponse, [INFO] [stdout] 465 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:451:30 [INFO] [stdout] | [INFO] [stdout] 451 | .and_then(|file| fs::read_to_string(file).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:831:66 [INFO] [stdout] | [INFO] [stdout] 831 | ... .map_err(|err| ModelError::Error(Box::new(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:832:82 [INFO] [stdout] | [INFO] [stdout] 832 | ... .map(|each| each.map_err(|err| ModelError::Error(Box::new(err)))), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:21:39 [INFO] [stdout] | [INFO] [stdout] 21 | .and_then(|depth| get_directory_tree(depth).ok()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:31:39 [INFO] [stdout] | [INFO] [stdout] 31 | .and_then(|depth| get_directory_tree(depth).ok()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shai` (lib) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:46 [INFO] [stdout] | [INFO] [stdout] 102 | .map_err(|err| ModelError::Error(Box::new(err))), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:455:12 [INFO] [stdout] | [INFO] [stdout] 443 | let mut stdout = io::stdout().lock(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 444 | crossterm::execute!(stdout, EnterAlternateScreen)?; [INFO] [stdout] 445 | let backend = CrosstermBackend::new(stdout); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 446 | let term = Terminal::new(backend)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 455 | Ok(ShaiUI { [INFO] [stdout] | ____________^ [INFO] [stdout] 456 | | args, [INFO] [stdout] 457 | | term, [INFO] [stdout] 458 | | layout: Layout::InputResponse, [INFO] [stdout] ... | [INFO] [stdout] 464 | | response_focus: Focus::MainResponse, [INFO] [stdout] 465 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:451:30 [INFO] [stdout] | [INFO] [stdout] 451 | .and_then(|file| fs::read_to_string(file).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:831:66 [INFO] [stdout] | [INFO] [stdout] 831 | ... .map_err(|err| ModelError::Error(Box::new(err)))? [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli.rs:832:82 [INFO] [stdout] | [INFO] [stdout] 832 | ... .map(|each| each.map_err(|err| ModelError::Error(Box::new(err)))), [INFO] [stdout] | --- ^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:21:39 [INFO] [stdout] | [INFO] [stdout] 21 | .and_then(|depth| get_directory_tree(depth).ok()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/context.rs:31:39 [INFO] [stdout] | [INFO] [stdout] 31 | .and_then(|depth| get_directory_tree(depth).ok()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `shai` (lib test) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "2b757a2a635735a62e8fb29aa499c859fa9afb257524645c04e7325011242be3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2b757a2a635735a62e8fb29aa499c859fa9afb257524645c04e7325011242be3", kill_on_drop: false }` [INFO] [stdout] 2b757a2a635735a62e8fb29aa499c859fa9afb257524645c04e7325011242be3