[INFO] fetching crate sgmlish 0.2.0... [INFO] checking sgmlish-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sgmlish 0.2.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate sgmlish 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sgmlish 0.2.0 [INFO] finished tweaking crates.io crate sgmlish 0.2.0 [INFO] tweaked toml for crates.io crate sgmlish 0.2.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate sgmlish 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0a38661577f4efa37e836b08ddaa324951b52c2019c98af014ec62aac1b9af39 [INFO] running `Command { std: "docker" "start" "-a" "0a38661577f4efa37e836b08ddaa324951b52c2019c98af014ec62aac1b9af39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0a38661577f4efa37e836b08ddaa324951b52c2019c98af014ec62aac1b9af39", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0a38661577f4efa37e836b08ddaa324951b52c2019c98af014ec62aac1b9af39", kill_on_drop: false }` [INFO] [stdout] 0a38661577f4efa37e836b08ddaa324951b52c2019c98af014ec62aac1b9af39 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 42129f3b71fdf25562a2509754270c82f30cdcde5623921f932fa4b9cf1f341e [INFO] running `Command { std: "docker" "start" "-a" "42129f3b71fdf25562a2509754270c82f30cdcde5623921f932fa4b9cf1f341e", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling autocfg v1.0.1 [INFO] [stderr] Compiling syn v1.0.76 [INFO] [stderr] Compiling libc v0.2.102 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Compiling version_check v0.9.3 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking minimal-lexical v0.1.3 [INFO] [stderr] Checking arrayvec v0.5.2 [INFO] [stderr] Compiling nom v7.0.0 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling num-integer v0.1.44 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking colored v1.9.3 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking simple_logger v1.13.0 [INFO] [stderr] Compiling thiserror-impl v1.0.29 [INFO] [stderr] Checking thiserror v1.0.29 [INFO] [stderr] Checking rust_decimal v1.16.0 [INFO] [stderr] Checking sgmlish v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:324:61 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn expand_entities(mut self, f: F) -> Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | self.config.entity_fn = Some(Box::new(move |entity| f(entity).map(Into::into))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:337:71 [INFO] [stdout] | [INFO] [stdout] 332 | pub fn expand_parameter_entities(mut self, f: F) -> Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | self.config.parameter_entity_fn = Some(Box::new(move |entity| f(entity).map(Into::into))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 380 | pub fn parse(self, input: &str) -> crate::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | self.build().parse(input) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/events.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 40 | |(_, declarations, content, epilogue)| { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / declarations [INFO] [stdout] 42 | | .into_iter() [INFO] [stdout] 43 | | .chain(content) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/events.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | |input| Err(nom::Err::Error(E::from_char(input, '<'))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:283:5 [INFO] [stdout] | [INFO] [stdout] 277 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | / context( [INFO] [stdout] 284 | | "attribute", [INFO] [stdout] 285 | | pair( [INFO] [stdout] 286 | | name, [INFO] [stdout] ... | [INFO] [stdout] 297 | | ), [INFO] [stdout] 298 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:293:28 [INFO] [stdout] | [INFO] [stdout] 293 | Ok((rest, f(value, quoted)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:330:39 [INFO] [stdout] | [INFO] [stdout] 330 | |c, terminator, ctx| preceded(char(c), take_until_terminated(ctx, terminator)); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:330:48 [INFO] [stdout] | [INFO] [stdout] 330 | |c, terminator, ctx| preceded(char(c), take_until_terminated(ctx, terminator)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:873:12 [INFO] [stdout] | [INFO] [stdout] 860 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), DeserializationError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 865 | let name = if self.use_tag_name_for_variant { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 873 | Ok((name, self)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sgmlish` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:324:61 [INFO] [stdout] | [INFO] [stdout] 319 | pub fn expand_entities(mut self, f: F) -> Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 324 | self.config.entity_fn = Some(Box::new(move |entity| f(entity).map(Into::into))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:337:71 [INFO] [stdout] | [INFO] [stdout] 332 | pub fn expand_parameter_entities(mut self, f: F) -> Self [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 337 | self.config.parameter_entity_fn = Some(Box::new(move |entity| f(entity).map(Into::into))); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/mod.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 380 | pub fn parse(self, input: &str) -> crate::Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 381 | self.build().parse(input) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/events.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 40 | |(_, declarations, content, epilogue)| { [INFO] [stdout] | ------------------------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | / declarations [INFO] [stdout] 42 | | .into_iter() [INFO] [stdout] 43 | | .chain(content) [INFO] [stdout] | |_______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/events.rs:232:21 [INFO] [stdout] | [INFO] [stdout] 232 | |input| Err(nom::Err::Error(E::from_char(input, '<'))), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:283:5 [INFO] [stdout] | [INFO] [stdout] 277 | mut f: F, [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 283 | / context( [INFO] [stdout] 284 | | "attribute", [INFO] [stdout] 285 | | pair( [INFO] [stdout] 286 | | name, [INFO] [stdout] ... | [INFO] [stdout] 297 | | ), [INFO] [stdout] 298 | | )(input) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:293:28 [INFO] [stdout] | [INFO] [stdout] 293 | Ok((rest, f(value, quoted)?)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:330:39 [INFO] [stdout] | [INFO] [stdout] 330 | |c, terminator, ctx| preceded(char(c), take_until_terminated(ctx, terminator)); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/parser/raw.rs:330:48 [INFO] [stdout] | [INFO] [stdout] 330 | |c, terminator, ctx| preceded(char(c), take_until_terminated(ctx, terminator)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:873:12 [INFO] [stdout] | [INFO] [stdout] 860 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), DeserializationError> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 865 | let name = if self.use_tag_name_for_variant { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 873 | Ok((name, self)) [INFO] [stdout] | ^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sgmlish` (lib test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "42129f3b71fdf25562a2509754270c82f30cdcde5623921f932fa4b9cf1f341e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "42129f3b71fdf25562a2509754270c82f30cdcde5623921f932fa4b9cf1f341e", kill_on_drop: false }` [INFO] [stdout] 42129f3b71fdf25562a2509754270c82f30cdcde5623921f932fa4b9cf1f341e