[INFO] fetching crate sfz 0.7.1... [INFO] checking sfz-0.7.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sfz 0.7.1 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sfz 0.7.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sfz 0.7.1 [INFO] finished tweaking crates.io crate sfz 0.7.1 [INFO] tweaked toml for crates.io crate sfz 0.7.1 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate sfz 0.7.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 204635bd21d9d162db014b4f45c3b7c425e1c70f42d329f542c8f6ec7fc50c23 [INFO] running `Command { std: "docker" "start" "-a" "204635bd21d9d162db014b4f45c3b7c425e1c70f42d329f542c8f6ec7fc50c23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "204635bd21d9d162db014b4f45c3b7c425e1c70f42d329f542c8f6ec7fc50c23", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "204635bd21d9d162db014b4f45c3b7c425e1c70f42d329f542c8f6ec7fc50c23", kill_on_drop: false }` [INFO] [stdout] 204635bd21d9d162db014b4f45c3b7c425e1c70f42d329f542c8f6ec7fc50c23 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 084602f5f4d089760a2af7377f4599e2defa881cdf6e79bfe6f0adb09d6cca2b [INFO] running `Command { std: "docker" "start" "-a" "084602f5f4d089760a2af7377f4599e2defa881cdf6e79bfe6f0adb09d6cca2b", kill_on_drop: false }` [INFO] [stderr] Compiling version_check v0.9.4 [INFO] [stderr] Compiling proc-macro2 v1.0.43 [INFO] [stderr] Compiling autocfg v1.1.0 [INFO] [stderr] Compiling quote v1.0.21 [INFO] [stderr] Compiling unicode-ident v1.0.3 [INFO] [stderr] Compiling syn v1.0.99 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Compiling libc v0.2.132 [INFO] [stderr] Compiling memchr v2.5.0 [INFO] [stderr] Checking once_cell v1.14.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Compiling futures-core v0.3.24 [INFO] [stderr] Checking fnv v1.0.7 [INFO] [stderr] Compiling siphasher v0.3.10 [INFO] [stderr] Checking pin-project-lite v0.2.9 [INFO] [stderr] Compiling typenum v1.15.0 [INFO] [stderr] Compiling rand_core v0.6.3 [INFO] [stderr] Compiling regex-syntax v0.6.27 [INFO] [stderr] Checking itoa v1.0.3 [INFO] [stderr] Compiling futures-task v0.3.24 [INFO] [stderr] Checking bytes v1.2.1 [INFO] [stderr] Compiling futures-channel v0.3.24 [INFO] [stderr] Checking futures-sink v0.3.24 [INFO] [stderr] Compiling crossbeam-utils v0.8.11 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling futures-util v0.3.24 [INFO] [stderr] Compiling serde_derive v1.0.144 [INFO] [stderr] Compiling uncased v0.9.7 [INFO] [stderr] Compiling generic-array v0.14.6 [INFO] [stderr] Compiling num-traits v0.2.15 [INFO] [stderr] Compiling slab v0.4.7 [INFO] [stderr] Compiling unicase v2.6.0 [INFO] [stderr] Compiling tokio v1.21.0 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crc32fast v1.3.2 [INFO] [stderr] Compiling ucd-trie v0.1.5 [INFO] [stderr] Compiling phf_shared v0.11.1 [INFO] [stderr] Compiling phf_generator v0.11.1 [INFO] [stderr] Compiling phf v0.11.1 [INFO] [stderr] Checking http v0.2.8 [INFO] [stderr] Compiling phf_codegen v0.11.1 [INFO] [stderr] Compiling serde v1.0.144 [INFO] [stderr] Checking futures-io v0.3.24 [INFO] [stderr] Checking unic-common v0.9.0 [INFO] [stderr] Checking adler v1.0.2 [INFO] [stderr] Checking pin-utils v0.1.0 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Checking num_cpus v1.13.1 [INFO] [stderr] Checking aho-corasick v0.7.19 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking socket2 v0.4.7 [INFO] [stderr] Checking mio v0.8.4 [INFO] [stderr] Checking getrandom v0.2.7 [INFO] [stderr] Checking alloc-no-stdlib v2.0.3 [INFO] [stderr] Checking bitflags v1.3.2 [INFO] [stderr] Checking unic-char-range v0.9.0 [INFO] [stderr] Checking alloc-stdlib v0.2.1 [INFO] [stderr] Checking walkdir v2.3.2 [INFO] [stderr] Checking miniz_oxide v0.5.4 [INFO] [stderr] Checking unic-char-property v0.9.0 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking unic-ucd-version v0.9.0 [INFO] [stderr] Compiling regex v1.6.0 [INFO] [stderr] Compiling indexmap v1.9.1 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking iana-time-zone v0.1.47 [INFO] [stderr] Checking ppv-lite86 v0.2.16 [INFO] [stderr] Compiling serde_json v1.0.85 [INFO] [stderr] Compiling httparse v1.8.0 [INFO] [stderr] Checking lazy_static v1.4.0 [INFO] [stderr] Checking flate2 v1.0.24 [INFO] [stderr] Compiling mime_guess v2.0.4 [INFO] [stderr] Checking unic-ucd-segment v0.9.0 [INFO] [stderr] Checking brotli-decompressor v2.3.2 [INFO] [stderr] Checking chrono v0.4.22 [INFO] [stderr] Checking tracing-core v0.1.29 [INFO] [stderr] Checking httpdate v1.0.2 [INFO] [stderr] Checking os_str_bytes v6.3.0 [INFO] [stderr] Checking try-lock v0.2.3 [INFO] [stderr] Checking mime v0.3.16 [INFO] [stderr] Checking hashbrown v0.12.3 [INFO] [stderr] Checking cpufeatures v0.2.5 [INFO] [stderr] Checking deunicode v0.4.3 [INFO] [stderr] Checking ryu v1.0.11 [INFO] [stderr] Checking percent-encoding v2.1.0 [INFO] [stderr] Checking clap_lex v0.2.4 [INFO] [stderr] Checking unic-segment v0.9.0 [INFO] [stderr] Checking slug v0.1.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking want v0.3.0 [INFO] [stderr] Checking http-body v0.4.5 [INFO] [stderr] Checking headers-core v0.2.0 [INFO] [stderr] Compiling parse-zoneinfo v0.3.0 [INFO] [stderr] Checking block-buffer v0.10.3 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking tracing v0.1.36 [INFO] [stderr] Checking humansize v1.1.1 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking base64 v0.13.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Checking digest v0.10.3 [INFO] [stderr] Checking tower-service v0.3.2 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking textwrap v0.15.0 [INFO] [stderr] Compiling chrono-tz-build v0.0.3 [INFO] [stderr] Checking sha1 v0.10.4 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking zip v0.6.2 [INFO] [stderr] Checking qstring v0.7.2 [INFO] [stderr] Checking headers v0.3.8 [INFO] [stderr] Checking clap v3.2.20 [INFO] [stderr] Checking brotli v3.3.4 [INFO] [stderr] Compiling chrono-tz v0.6.3 [INFO] [stderr] Checking globset v0.4.9 [INFO] [stderr] Checking ignore v0.4.18 [INFO] [stderr] Checking globwalk v0.8.1 [INFO] [stderr] Compiling thiserror-impl v1.0.34 [INFO] [stderr] Compiling futures-macro v0.3.24 [INFO] [stderr] Compiling tokio-macros v1.8.0 [INFO] [stderr] Compiling thiserror v1.0.34 [INFO] [stderr] Compiling pest v2.3.0 [INFO] [stderr] Compiling pest_meta v2.3.0 [INFO] [stderr] Compiling pest_generator v2.3.0 [INFO] [stderr] Checking async-compression v0.3.14 [INFO] [stderr] Checking tokio-util v0.7.4 [INFO] [stderr] Compiling pest_derive v2.3.0 [INFO] [stderr] Checking futures-executor v0.3.24 [INFO] [stderr] Checking hyper v0.14.20 [INFO] [stderr] Checking futures v0.3.24 [INFO] [stderr] Checking tera v1.17.0 [INFO] [stderr] Checking sfz v0.7.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/app.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 15 | let arg_port = Arg::new("port") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let arg_address = Arg::new("address") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let arg_cors = Arg::new("cors") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let arg_coi = Arg::new("coi") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let arg_cache = Arg::new("cache") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let arg_path = Arg::new("path") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let arg_unzipped = Arg::new("unzipped") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let arg_all = Arg::new("all") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let arg_no_ignore = Arg::new("no-ignore") [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let arg_no_log = Arg::new("no-log") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let arg_follow_links = Arg::new("follow-links") [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let arg_render_index = Arg::new("render-index") [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let arg_path_prefix = Arg::new("path-prefix") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / clap::command!() [INFO] [stdout] 85 | | .about(ABOUT) [INFO] [stdout] 86 | | .arg(arg_address) [INFO] [stdout] 87 | | .arg(arg_port) [INFO] [stdout] ... | [INFO] [stdout] 96 | | .arg(arg_follow_links) [INFO] [stdout] 97 | | .arg(arg_render_index) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/args.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 77 | fn parse_path>(path: P) -> BoxResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / env::current_dir() [INFO] [stdout] 84 | | .and_then(|mut p| { [INFO] [stdout] 85 | | p.push(path); // If path is absolute, it replaces the current path. [INFO] [stdout] 86 | | canonicalize(p) [INFO] [stdout] 87 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 45 | dir_path: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | WalkBuilder::new(dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:161:15 [INFO] [stdout] | [INFO] [stdout] 152 | let mut r = match self.reader.lock() { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | eprintln!("{e:?}"); [INFO] [stdout] 156 | let e = io::Error::new(io::ErrorKind::Other, "Failed to read file"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let mut buf = BytesMut::zeroed(4_096); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | match r.read(&mut buf[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn send_file>(file_path: P) -> io::Result<(FileStream>, u64)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let file = File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let size = file.metadata()?.len(); [INFO] [stdout] 179 | let reader = Mutex::new(BufReader::new(file)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Ok((FileStream { reader }, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:230:8 [INFO] [stdout] | [INFO] [stdout] 185 | dir_path: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let zip_file = tempfile::tempfile()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let mut zip_writer = ZipWriter::new(zip_file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let files_iter = get_dir_contents(dir_path, with_ignore, show_all, None) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let mut zip = zip_writer [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let reader = Mutex::new(BufReader::new(zip)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Ok((FileStream { reader }, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:258:8 [INFO] [stdout] | [INFO] [stdout] 240 | file_path: P, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let mut f = File::open(file_path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let reader = Mutex::new(BufReader::new(f).take(end - start + 1)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | Ok((FileStream { reader }, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/serve.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 65 | let inner = inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | async { [INFO] [stdout] 67 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 68 | | let inner = inner.clone(); [INFO] [stdout] 69 | | inner.call(req) [INFO] [stdout] 70 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/serve.rs:103:60 [INFO] [stdout] | [INFO] [stdout] 103 | .unwrap_or_else(|_| res::internal_server_error(Response::default())); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/serve.rs:240:15 [INFO] [stdout] | [INFO] [stdout] 238 | fn path_is_under_basepath>(&self, path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let path = path.as_ref(); [INFO] [stdout] 240 | match path.canonicalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sfz` (bin "sfz") due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/app.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 15 | let arg_port = Arg::new("port") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 22 | let arg_address = Arg::new("address") [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | let arg_cors = Arg::new("cors") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 34 | let arg_coi = Arg::new("coi") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 38 | let arg_cache = Arg::new("cache") [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 45 | let arg_path = Arg::new("path") [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let arg_unzipped = Arg::new("unzipped") [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 55 | let arg_all = Arg::new("all") [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let arg_no_ignore = Arg::new("no-ignore") [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 65 | let arg_no_log = Arg::new("no-log") [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 69 | let arg_follow_links = Arg::new("follow-links") [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let arg_render_index = Arg::new("render-index") [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 79 | let arg_path_prefix = Arg::new("path-prefix") [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | / clap::command!() [INFO] [stdout] 85 | | .about(ABOUT) [INFO] [stdout] 86 | | .arg(arg_address) [INFO] [stdout] 87 | | .arg(arg_port) [INFO] [stdout] ... | [INFO] [stdout] 96 | | .arg(arg_follow_links) [INFO] [stdout] 97 | | .arg(arg_render_index) [INFO] [stdout] | |______________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/cli/args.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 77 | fn parse_path>(path: P) -> BoxResult { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | / env::current_dir() [INFO] [stdout] 84 | | .and_then(|mut p| { [INFO] [stdout] 85 | | p.push(path); // If path is absolute, it replaces the current path. [INFO] [stdout] 86 | | canonicalize(p) [INFO] [stdout] 87 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 45 | dir_path: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | WalkBuilder::new(dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:161:15 [INFO] [stdout] | [INFO] [stdout] 152 | let mut r = match self.reader.lock() { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 153 | Ok(r) => r, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 154 | Err(e) => { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 155 | eprintln!("{e:?}"); [INFO] [stdout] 156 | let e = io::Error::new(io::ErrorKind::Other, "Failed to read file"); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 160 | let mut buf = BytesMut::zeroed(4_096); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 161 | match r.read(&mut buf[..]) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:180:8 [INFO] [stdout] | [INFO] [stdout] 176 | pub fn send_file>(file_path: P) -> io::Result<(FileStream>, u64)> { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 177 | let file = File::open(file_path)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 178 | let size = file.metadata()?.len(); [INFO] [stdout] 179 | let reader = Mutex::new(BufReader::new(file)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 180 | Ok((FileStream { reader }, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:230:8 [INFO] [stdout] | [INFO] [stdout] 185 | dir_path: P, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 192 | let zip_file = tempfile::tempfile()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 193 | let mut zip_writer = ZipWriter::new(zip_file); [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 200 | let files_iter = get_dir_contents(dir_path, with_ignore, show_all, None) [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 222 | let mut zip = zip_writer [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 229 | let reader = Mutex::new(BufReader::new(zip)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 230 | Ok((FileStream { reader }, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/send.rs:258:8 [INFO] [stdout] | [INFO] [stdout] 240 | file_path: P, [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 248 | let mut f = File::open(file_path)?; [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 252 | let reader = Mutex::new(BufReader::new(f).take(end - start + 1)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 258 | Ok((FileStream { reader }, size)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/serve.rs:67:33 [INFO] [stdout] | [INFO] [stdout] 65 | let inner = inner.clone(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | async { [INFO] [stdout] 67 | Ok::<_, Infallible>(service_fn(move |req| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 68 | | let inner = inner.clone(); [INFO] [stdout] 69 | | inner.call(req) [INFO] [stdout] 70 | | })) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/serve.rs:103:60 [INFO] [stdout] | [INFO] [stdout] 103 | .unwrap_or_else(|_| res::internal_server_error(Response::default())); [INFO] [stdout] | - ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server/serve.rs:240:15 [INFO] [stdout] | [INFO] [stdout] 238 | fn path_is_under_basepath>(&self, path: P) -> bool { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 239 | let path = path.as_ref(); [INFO] [stdout] 240 | match path.canonicalize() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sfz` (bin "sfz" test) due to 11 previous errors [INFO] running `Command { std: "docker" "inspect" "084602f5f4d089760a2af7377f4599e2defa881cdf6e79bfe6f0adb09d6cca2b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "084602f5f4d089760a2af7377f4599e2defa881cdf6e79bfe6f0adb09d6cca2b", kill_on_drop: false }` [INFO] [stdout] 084602f5f4d089760a2af7377f4599e2defa881cdf6e79bfe6f0adb09d6cca2b