[INFO] fetching crate sfm 0.5.0... [INFO] checking sfm-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sfm 0.5.0 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate sfm 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sfm 0.5.0 [INFO] finished tweaking crates.io crate sfm 0.5.0 [INFO] tweaked toml for crates.io crate sfm 0.5.0 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] crate crates.io crate sfm 0.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 96e6ea20fac4ed242493ed9e2fe3dd43acca1b58860bc497b2d5887a782091d3 [INFO] running `Command { std: "docker" "start" "-a" "96e6ea20fac4ed242493ed9e2fe3dd43acca1b58860bc497b2d5887a782091d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "96e6ea20fac4ed242493ed9e2fe3dd43acca1b58860bc497b2d5887a782091d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "96e6ea20fac4ed242493ed9e2fe3dd43acca1b58860bc497b2d5887a782091d3", kill_on_drop: false }` [INFO] [stdout] 96e6ea20fac4ed242493ed9e2fe3dd43acca1b58860bc497b2d5887a782091d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d9b910bcff4297dfa8d25df76ce9272847904146695213afc1d374cae71c2113 [INFO] running `Command { std: "docker" "start" "-a" "d9b910bcff4297dfa8d25df76ce9272847904146695213afc1d374cae71c2113", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.86 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking num-integer v0.1.44 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking dirs-sys v0.3.5 [INFO] [stderr] Checking time v0.1.44 [INFO] [stderr] Checking dirs v3.0.1 [INFO] [stderr] Checking signal-hook v0.1.17 [INFO] [stderr] Checking chrono v0.4.19 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Checking crossterm v0.18.2 [INFO] [stderr] Checking crossterm v0.19.0 [INFO] [stderr] Checking tui v0.14.0 [INFO] [stderr] Checking toml v0.5.8 [INFO] [stderr] Checking sfm v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `show_icons` and `error_icon` are never read [INFO] [stdout] --> src/app/components/error_modal.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 23 | pub struct ErrorModalComponentProps { [INFO] [stdout] | ------------------------ fields in this struct [INFO] [stdout] 24 | message: Option, [INFO] [stdout] 25 | show_icons: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 26 | error_icon: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ErrorModalComponentProps` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `modal_style` is never read [INFO] [stdout] --> src/app/components/rename_modal.rs:32:5 [INFO] [stdout] | [INFO] [stdout] 28 | pub struct RenameModalComponentProps { [INFO] [stdout] | ------------------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | modal_style: ModalStyle, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `RenameModalComponentProps` has a derived impl for the trait `Clone`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `has_displayed_tabs` is never read [INFO] [stdout] --> src/app/components/tab.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 31 | pub struct TabComponentProps { [INFO] [stdout] | ----------------- field in this struct [INFO] [stdout] 32 | state: Option>, [INFO] [stdout] 33 | has_displayed_tabs: bool, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `TabComponentProps` has derived impls for the traits `Debug` and `Clone`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/file_system/mod.rs:54:15 [INFO] [stdout] | [INFO] [stdout] 51 | path: TPath, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 54 | match fs::read_dir(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/file_system/mod.rs:72:15 [INFO] [stdout] | [INFO] [stdout] 71 | fn read_to_string>(&self, path: TPath) -> Option { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 72 | match fs::read_to_string(path) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/app/file_system/functions.rs:84:34 [INFO] [stdout] | [INFO] [stdout] 84 | .map(|mut i| i.next().is_none()) [INFO] [stdout] | ----- ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/events.rs:104:31 [INFO] [stdout] | [INFO] [stdout] 58 | let (sender, receiver) = channel(); [INFO] [stdout] | ------ -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 59 | let tick_rate = Duration::from_millis(config.tick_rate); [INFO] [stdout] 60 | let skip_input_event = Arc::new(AtomicBool::new(false)); [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | let skip_event_read = skip_input_event.clone(); [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 63 | let runner_handle = thread::spawn(move || { [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 104 | skip_input_event: skip_input_event.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/core/store.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 65 | fn dispatch_reducer(&self, action: TAction) -> TState { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | (self.root_reducer)(self.state.clone(), action) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sfm` (bin "sfm") due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d9b910bcff4297dfa8d25df76ce9272847904146695213afc1d374cae71c2113", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d9b910bcff4297dfa8d25df76ce9272847904146695213afc1d374cae71c2113", kill_on_drop: false }` [INFO] [stdout] d9b910bcff4297dfa8d25df76ce9272847904146695213afc1d374cae71c2113