[INFO] fetching crate service-install 0.4.3... [INFO] checking service-install-0.4.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate service-install 0.4.3 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate service-install 0.4.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate service-install 0.4.3 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate service-install 0.4.3 [INFO] tweaked toml for crates.io crate service-install 0.4.3 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] crate crates.io crate service-install 0.4.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 722eabe06320cd696e162bdd8f9d023dde750b7a218583b7af73746631a9e36e [INFO] running `Command { std: "docker" "start" "-a" "722eabe06320cd696e162bdd8f9d023dde750b7a218583b7af73746631a9e36e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "722eabe06320cd696e162bdd8f9d023dde750b7a218583b7af73746631a9e36e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "722eabe06320cd696e162bdd8f9d023dde750b7a218583b7af73746631a9e36e", kill_on_drop: false }` [INFO] [stdout] 722eabe06320cd696e162bdd8f9d023dde750b7a218583b7af73746631a9e36e [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4d812c4e3625468fcd72a55401fbba21ee93bf069556ff15395234234cb1f7af [INFO] running `Command { std: "docker" "start" "-a" "4d812c4e3625468fcd72a55401fbba21ee93bf069556ff15395234234cb1f7af", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.79 [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling rustix v0.38.32 [INFO] [stderr] Checking bitflags v2.5.0 [INFO] [stderr] Checking linux-raw-sys v0.4.13 [INFO] [stderr] Compiling thiserror v1.0.58 [INFO] [stderr] Checking either v1.10.0 [INFO] [stderr] Checking regex-syntax v0.8.3 [INFO] [stderr] Checking fastrand v2.0.2 [INFO] [stderr] Checking unicode-width v0.1.11 [INFO] [stderr] Checking shell-words v1.1.0 [INFO] [stderr] Checking zeroize v1.7.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking shell-escape v0.1.5 [INFO] [stderr] Checking console v0.15.8 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking sudo v0.6.0 [INFO] [stderr] Checking uzers v0.11.3 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Compiling syn v2.0.58 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking tempfile v3.10.1 [INFO] [stderr] Checking regex v1.10.4 [INFO] [stderr] Checking sysinfo v0.30.8 [INFO] [stderr] Compiling thiserror-impl v1.0.58 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Checking service-install v0.4.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait `Assigned` is never used [INFO] [stdout] --> src/install/builder.rs:20:11 [INFO] [stdout] | [INFO] [stdout] 20 | pub trait Assigned: ToAssign {} [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `NotAssigned` is never used [INFO] [stdout] --> src/install/builder.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 21 | pub trait NotAssigned: ToAssign {} [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:490:49 [INFO] [stdout] | [INFO] [stdout] 490 | .partition_map(|mut step| match step.perform() { [INFO] [stdout] | -------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install.rs:562:12 [INFO] [stdout] | [INFO] [stdout] 550 | let (mut steps, path) = loop { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 555 | if let Some(install) = init.tear_down_steps(&name, bin_name, mode, run_as.as_deref())? { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 562 | Ok(RemoveSteps(steps)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/files.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 170 | Ok(Some(Box::new(RestorePermissions { [INFO] [stdout] | ____________^ [INFO] [stdout] 171 | | path: self.path.clone(), [INFO] [stdout] 172 | | org_permissions, [INFO] [stdout] 173 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/files.rs:249:8 [INFO] [stdout] | [INFO] [stdout] 225 | let mut steps = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 230 | let disable_steps = disable_if_running(&target, init_systems, mode, run_as)?; [INFO] [stdout] | ------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 249 | Ok((steps, target)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/files.rs:262:8 [INFO] [stdout] | [INFO] [stdout] 257 | Err(e) if e.kind() == ErrorKind::NotFound => return Ok(None), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 258 | Err(e) => return Err(MoveError::CheckExistingFilePermissions(e)), [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 262 | Ok(if permissions.readonly() { [INFO] [stdout] | ________^ [INFO] [stdout] 263 | | let step = MakeRemovable(target.to_owned()); [INFO] [stdout] 264 | | let step = Box::new(step) as Box; [INFO] [stdout] 265 | | Some(step) [INFO] [stdout] 266 | | } else { [INFO] [stdout] 267 | | None [INFO] [stdout] 268 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/files.rs:299:12 [INFO] [stdout] | [INFO] [stdout] 299 | Ok(Some(Box::new(RestorePermissions { [INFO] [stdout] | ____________^ [INFO] [stdout] 300 | | path: self.0.clone(), [INFO] [stdout] 301 | | org_permissions, [INFO] [stdout] 302 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/cron.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 102 | let mut command = Command::new("crontab"); [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 126 | Err(GetCrontabError::CommandFailed { stderr }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/cron/disable.rs:203:12 [INFO] [stdout] | [INFO] [stdout] 203 | Ok(Some(Box::new(RollbackCommentOut { [INFO] [stdout] | ____________^ [INFO] [stdout] 204 | | commented_rule, [INFO] [stdout] 205 | | original_rule: rule.clone(), [INFO] [stdout] 206 | | user: user.clone(), [INFO] [stdout] 207 | | }))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/cron/setup.rs:148:12 [INFO] [stdout] | [INFO] [stdout] 148 | Ok(Some(Box::new(RollbackImpossible))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/cron/setup.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | Ok(Some(Box::new(RollbackImpossible))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/cron/teardown.rs:88:8 [INFO] [stdout] | [INFO] [stdout] 83 | let step = Box::new(RemoveInstalled { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 88 | Ok(Some((vec![step], install_path))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/systemd.rs:140:8 [INFO] [stdout] | [INFO] [stdout] 112 | let mut steps = Vec::new(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 140 | Ok(Some((steps, exe_path))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/systemd.rs:163:9 [INFO] [stdout] | [INFO] [stdout] 163 | Err(SystemCtlError::Failed { reason }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/systemd/disable_existing.rs:116:12 [INFO] [stdout] | [INFO] [stdout] 102 | let mut rollback = Box::new(ReEnable { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 115 | let rollback = rollback as Box; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | Ok(Some(rollback)) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/install/init/systemd/disable_existing.rs:179:21 [INFO] [stdout] | [INFO] [stdout] 179 | .map(|unit| unit.exe_path().map(|exe| (exe, unit))) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `service-install` (lib) due to 16 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "4d812c4e3625468fcd72a55401fbba21ee93bf069556ff15395234234cb1f7af", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4d812c4e3625468fcd72a55401fbba21ee93bf069556ff15395234234cb1f7af", kill_on_drop: false }` [INFO] [stdout] 4d812c4e3625468fcd72a55401fbba21ee93bf069556ff15395234234cb1f7af