[INFO] fetching crate serf-rpc 0.2.0... [INFO] checking serf-rpc-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serf-rpc 0.2.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate serf-rpc 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serf-rpc 0.2.0 [INFO] finished tweaking crates.io crate serf-rpc 0.2.0 [INFO] tweaked toml for crates.io crate serf-rpc 0.2.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] crate crates.io crate serf-rpc 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6e4fa67f07b46d537dbac79206afed40fa8199391f7c2406ab01302ace754cbc [INFO] running `Command { std: "docker" "start" "-a" "6e4fa67f07b46d537dbac79206afed40fa8199391f7c2406ab01302ace754cbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6e4fa67f07b46d537dbac79206afed40fa8199391f7c2406ab01302ace754cbc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6e4fa67f07b46d537dbac79206afed40fa8199391f7c2406ab01302ace754cbc", kill_on_drop: false }` [INFO] [stdout] 6e4fa67f07b46d537dbac79206afed40fa8199391f7c2406ab01302ace754cbc [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b913f695d2b359fc7512db8d2ebf22c49045bb8165d8c4941c0680538e041597 [INFO] running `Command { std: "docker" "start" "-a" "b913f695d2b359fc7512db8d2ebf22c49045bb8165d8c4941c0680538e041597", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.24 [INFO] [stderr] Compiling syn v1.0.60 [INFO] [stderr] Compiling libc v0.2.85 [INFO] [stderr] Compiling proc-macro-hack v0.5.19 [INFO] [stderr] Compiling memchr v2.3.4 [INFO] [stderr] Checking once_cell v1.5.2 [INFO] [stderr] Compiling proc-macro-nested v0.1.7 [INFO] [stderr] Compiling num-traits v0.2.14 [INFO] [stderr] Compiling serde_derive v1.0.123 [INFO] [stderr] Checking futures-core v0.3.12 [INFO] [stderr] Checking futures-sink v0.3.12 [INFO] [stderr] Checking pin-project-lite v0.2.4 [INFO] [stderr] Checking futures-io v0.3.12 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Compiling serde v1.0.123 [INFO] [stderr] Checking instant v0.1.9 [INFO] [stderr] Checking scopeguard v1.1.0 [INFO] [stderr] Checking futures-channel v0.3.12 [INFO] [stderr] Checking futures-task v0.3.12 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking byteorder v1.4.2 [INFO] [stderr] Checking lock_api v0.4.2 [INFO] [stderr] Compiling tokio v1.2.0 [INFO] [stderr] Checking bytes v1.0.1 [INFO] [stderr] Compiling quote v1.0.8 [INFO] [stderr] Checking parking_lot_core v0.8.2 [INFO] [stderr] Checking mio v0.7.7 [INFO] [stderr] Checking signal-hook-registry v1.3.0 [INFO] [stderr] Checking num_cpus v1.13.0 [INFO] [stderr] Checking rmp v0.8.10 [INFO] [stderr] Checking parking_lot v0.11.1 [INFO] [stderr] Compiling futures-macro v0.3.12 [INFO] [stderr] Compiling tokio-macros v1.1.0 [INFO] [stderr] Checking futures-util v0.3.12 [INFO] [stderr] Checking futures-executor v0.3.12 [INFO] [stderr] Checking futures v0.3.12 [INFO] [stderr] Checking rmp-serde v0.15.4 [INFO] [stderr] Checking serf-rpc v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn send_ignored(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match std::mem::replace(&mut *self.state.lock().unwrap(), RequestState::Invalid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 59 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | match std::mem::replace(&mut *state, RequestState::Invalid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 86 | let res = res.and_then(T::read_from); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let ready = RequestState::Ready(res); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | match std::mem::replace(&mut *self.lock().unwrap(), ready) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 20 | let handler = Arc::new(Mutex::new(RPCStreamHandler { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | client: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serf-rpc` (lib test) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:41:15 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn send_ignored(self) { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 41 | match std::mem::replace(&mut *self.state.lock().unwrap(), RequestState::Invalid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 59 | let mut state = self.state.lock().unwrap(); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 60 | [INFO] [stdout] 61 | match std::mem::replace(&mut *state, RequestState::Invalid) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/request.rs:89:15 [INFO] [stdout] | [INFO] [stdout] 86 | let res = res.and_then(T::read_from); [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | let ready = RequestState::Ready(res); [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 88 | [INFO] [stdout] 89 | match std::mem::replace(&mut *self.lock().unwrap(), ready) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/stream.rs:29:21 [INFO] [stdout] | [INFO] [stdout] 20 | let handler = Arc::new(Mutex::new(RPCStreamHandler { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 29 | client: self.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serf-rpc` (lib) due to 5 previous errors [INFO] running `Command { std: "docker" "inspect" "b913f695d2b359fc7512db8d2ebf22c49045bb8165d8c4941c0680538e041597", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b913f695d2b359fc7512db8d2ebf22c49045bb8165d8c4941c0680538e041597", kill_on_drop: false }` [INFO] [stdout] b913f695d2b359fc7512db8d2ebf22c49045bb8165d8c4941c0680538e041597