[INFO] fetching crate serde_spaniel 0.4.0... [INFO] checking serde_spaniel-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde_spaniel 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate serde_spaniel 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_spaniel 0.4.0 [INFO] finished tweaking crates.io crate serde_spaniel 0.4.0 [INFO] tweaked toml for crates.io crate serde_spaniel 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate serde_spaniel 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 6b1230a89678fdf2b10ace79f04e28bcfe6e792d707ee86ff586cd0c35427ea1 [INFO] running `Command { std: "docker" "start" "-a" "6b1230a89678fdf2b10ace79f04e28bcfe6e792d707ee86ff586cd0c35427ea1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "6b1230a89678fdf2b10ace79f04e28bcfe6e792d707ee86ff586cd0c35427ea1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b1230a89678fdf2b10ace79f04e28bcfe6e792d707ee86ff586cd0c35427ea1", kill_on_drop: false }` [INFO] [stdout] 6b1230a89678fdf2b10ace79f04e28bcfe6e792d707ee86ff586cd0c35427ea1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 39a9ee3aee85aa28d19d07ba2f0440b4c79495a14409fffeb75e5a95a551da89 [INFO] running `Command { std: "docker" "start" "-a" "39a9ee3aee85aa28d19d07ba2f0440b4c79495a14409fffeb75e5a95a551da89", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.27 [INFO] [stderr] Compiling libc v0.2.126 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling io-lifetimes v0.7.2 [INFO] [stderr] Compiling syn v1.0.72 [INFO] [stderr] Compiling rustix v0.35.7 [INFO] [stderr] Compiling serde_derive v1.0.126 [INFO] [stderr] Compiling serde v1.0.126 [INFO] [stderr] Compiling memchr v2.4.0 [INFO] [stderr] Checking linux-raw-sys v0.0.46 [INFO] [stderr] Compiling log v0.4.14 [INFO] [stderr] Checking smallvec v1.6.1 [INFO] [stderr] Checking endian-type v0.1.2 [INFO] [stderr] Checking unicode-width v0.1.8 [INFO] [stderr] Checking unicode-segmentation v1.7.1 [INFO] [stderr] Checking utf8parse v0.2.0 [INFO] [stderr] Checking nibble_vec v0.1.0 [INFO] [stderr] Checking radix_trie v0.2.1 [INFO] [stderr] Compiling quote v1.0.9 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking nix v0.24.2 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking fd-lock v3.0.6 [INFO] [stderr] Checking rustyline v10.0.0 [INFO] [stderr] Checking serde_bytes v0.11.5 [INFO] [stderr] Checking serde_spaniel v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:14:33 [INFO] [stdout] | [INFO] [stdout] 12 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | ) -> Result { [INFO] [stdout] 14 | Deserialize::deserialize(&mut Deserializer::from_prompt(prompt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 90 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ) -> Result { [INFO] [stdout] 92 | from_replay_prompt(MetaCommandPrompt::new(CompactPrompt::new(prompt))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 116 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | ) -> Result<()> { [INFO] [stdout] 118 | Serialize::serialize(value, &mut Serializer::from_prompt(prompt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 125 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | ) -> Result<()> { [INFO] [stdout] 127 | to_bare_prompt(value, MetaCommandPrompt::new(CompactPrompt::new(prompt))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn from_prompt(prompt: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Deserializer { [INFO] [stdout] 24 | prompt: InternalPrompt::from_prompt(prompt), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn from_prompt(prompt: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Serializer { [INFO] [stdout] 15 | prompt: InternalPrompt::from_prompt(prompt), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_spaniel` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:14:33 [INFO] [stdout] | [INFO] [stdout] 12 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | ) -> Result { [INFO] [stdout] 14 | Deserialize::deserialize(&mut Deserializer::from_prompt(prompt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 90 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 91 | ) -> Result { [INFO] [stdout] 92 | from_replay_prompt(MetaCommandPrompt::new(CompactPrompt::new(prompt))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 116 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 117 | ) -> Result<()> { [INFO] [stdout] 118 | Serialize::serialize(value, &mut Serializer::from_prompt(prompt)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util.rs:127:25 [INFO] [stdout] | [INFO] [stdout] 125 | prompt: P, [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 126 | ) -> Result<()> { [INFO] [stdout] 127 | to_bare_prompt(value, MetaCommandPrompt::new(CompactPrompt::new(prompt))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:24:15 [INFO] [stdout] | [INFO] [stdout] 22 | pub fn from_prompt(prompt: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 23 | Deserializer { [INFO] [stdout] 24 | prompt: InternalPrompt::from_prompt(prompt), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:15:15 [INFO] [stdout] | [INFO] [stdout] 13 | pub fn from_prompt(prompt: P) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | Serializer { [INFO] [stdout] 15 | prompt: InternalPrompt::from_prompt(prompt), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_spaniel` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "39a9ee3aee85aa28d19d07ba2f0440b4c79495a14409fffeb75e5a95a551da89", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "39a9ee3aee85aa28d19d07ba2f0440b4c79495a14409fffeb75e5a95a551da89", kill_on_drop: false }` [INFO] [stdout] 39a9ee3aee85aa28d19d07ba2f0440b4c79495a14409fffeb75e5a95a551da89