[INFO] fetching crate serde_postgres 0.2.0... [INFO] checking serde_postgres-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde_postgres 0.2.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate serde_postgres 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_postgres 0.2.0 [INFO] finished tweaking crates.io crate serde_postgres 0.2.0 [INFO] tweaked toml for crates.io crate serde_postgres 0.2.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate serde_postgres 0.2.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `tokio-postgres` dependency) [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef1057c86e50ac2db8adc3173ab57a92688d497fd778f0e001901aab2b142bd6 [INFO] running `Command { std: "docker" "start" "-a" "ef1057c86e50ac2db8adc3173ab57a92688d497fd778f0e001901aab2b142bd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef1057c86e50ac2db8adc3173ab57a92688d497fd778f0e001901aab2b142bd6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef1057c86e50ac2db8adc3173ab57a92688d497fd778f0e001901aab2b142bd6", kill_on_drop: false }` [INFO] [stdout] ef1057c86e50ac2db8adc3173ab57a92688d497fd778f0e001901aab2b142bd6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b165032cdb7debc183f91ee50f8fe4b88819e2af15b66ec7e00c9a686ae9104f [INFO] running `Command { std: "docker" "start" "-a" "b165032cdb7debc183f91ee50f8fe4b88819e2af15b66ec7e00c9a686ae9104f", kill_on_drop: false }` [INFO] [stderr] warning: `default_features` is deprecated in favor of `default-features` and will not work in the 2024 edition [INFO] [stderr] (in the `tokio-postgres` dependency) [INFO] [stderr] Compiling proc-macro2 v1.0.19 [INFO] [stderr] Compiling libc v0.2.74 [INFO] [stderr] Checking cfg-if v0.1.10 [INFO] [stderr] Compiling syn v1.0.38 [INFO] [stderr] Compiling version_check v0.9.2 [INFO] [stderr] Compiling typenum v1.12.0 [INFO] [stderr] Compiling memchr v2.3.3 [INFO] [stderr] Compiling getrandom v0.1.14 [INFO] [stderr] Checking slab v0.4.2 [INFO] [stderr] Checking futures-core v0.3.5 [INFO] [stderr] Compiling pin-project-internal v0.4.23 [INFO] [stderr] Compiling log v0.4.11 [INFO] [stderr] Checking futures-sink v0.3.5 [INFO] [stderr] Compiling proc-macro-nested v0.1.6 [INFO] [stderr] Checking matches v0.1.8 [INFO] [stderr] Compiling proc-macro-hack v0.5.18 [INFO] [stderr] Checking bytes v0.5.6 [INFO] [stderr] Checking ppv-lite86 v0.2.8 [INFO] [stderr] Compiling byteorder v1.3.4 [INFO] [stderr] Checking once_cell v1.4.0 [INFO] [stderr] Checking subtle v2.2.3 [INFO] [stderr] Checking tinyvec v0.3.3 [INFO] [stderr] Checking futures-channel v0.3.5 [INFO] [stderr] Checking futures-task v0.3.5 [INFO] [stderr] Checking unicode-normalization v0.1.13 [INFO] [stderr] Checking unicode-bidi v0.3.4 [INFO] [stderr] Checking cpuid-bool v0.1.2 [INFO] [stderr] Checking futures-io v0.3.5 [INFO] [stderr] Checking opaque-debug v0.3.0 [INFO] [stderr] Checking pin-project-lite v0.1.7 [INFO] [stderr] Checking md5 v0.7.0 [INFO] [stderr] Checking base64 v0.12.3 [INFO] [stderr] Checking fallible-iterator v0.2.0 [INFO] [stderr] Compiling generic-array v0.14.3 [INFO] [stderr] Checking smallvec v1.4.1 [INFO] [stderr] Checking instant v0.1.6 [INFO] [stderr] Checking siphasher v0.3.3 [INFO] [stderr] Checking lock_api v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.114 [INFO] [stderr] Compiling serde v1.0.114 [INFO] [stderr] Checking phf_shared v0.8.0 [INFO] [stderr] Compiling quote v1.0.7 [INFO] [stderr] Checking phf v0.8.0 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking net2 v0.2.34 [INFO] [stderr] Checking parking_lot_core v0.8.0 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking parking_lot v0.11.0 [INFO] [stderr] Checking mio v0.6.22 [INFO] [stderr] Checking stringprep v0.1.2 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Checking digest v0.9.0 [INFO] [stderr] Checking crypto-mac v0.8.0 [INFO] [stderr] Checking block-buffer v0.9.0 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking sha2 v0.9.1 [INFO] [stderr] Checking hmac v0.8.1 [INFO] [stderr] Checking postgres-protocol v0.5.2 [INFO] [stderr] Checking postgres-types v0.1.2 [INFO] [stderr] Compiling futures-macro v0.3.5 [INFO] [stderr] Compiling tokio-macros v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.36 [INFO] [stderr] Checking tokio v0.2.22 [INFO] [stderr] Checking pin-project v0.4.23 [INFO] [stderr] Checking futures-util v0.3.5 [INFO] [stderr] Checking tokio-util v0.3.1 [INFO] [stderr] Checking futures-executor v0.3.5 [INFO] [stderr] Checking futures v0.3.5 [INFO] [stderr] Checking tokio-postgres v0.5.5 [INFO] [stderr] Checking postgres v0.17.5 [INFO] [stderr] Checking serde_postgres v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/de.rs:510:49 [INFO] [stdout] | [INFO] [stdout] 510 | struct Person { name: String, age: i32 }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | input: impl IntoIterator, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> DeResult { [INFO] [stdout] 34 | / input [INFO] [stdout] 35 | | .into_iter() [INFO] [stdout] 36 | | .map(|row| { [INFO] [stdout] 37 | | let mut deserializer = Deserializer::from_row(row); [INFO] [stdout] 38 | | T::deserialize(&mut deserializer) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:207:23 [INFO] [stdout] | [INFO] [stdout] 197 | fn next_key_seed>(&mut self, seed: T) -> DeResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .and_then(|n| seed.deserialize(n).map(Some)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:207:27 [INFO] [stdout] | [INFO] [stdout] 197 | fn next_key_seed>(&mut self, seed: T) -> DeResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .and_then(|n| seed.deserialize(n).map(Some)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_postgres` (lib) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 32 | input: impl IntoIterator, [INFO] [stdout] | ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 33 | ) -> DeResult { [INFO] [stdout] 34 | / input [INFO] [stdout] 35 | | .into_iter() [INFO] [stdout] 36 | | .map(|row| { [INFO] [stdout] 37 | | let mut deserializer = Deserializer::from_row(row); [INFO] [stdout] 38 | | T::deserialize(&mut deserializer) [INFO] [stdout] 39 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:207:23 [INFO] [stdout] | [INFO] [stdout] 197 | fn next_key_seed>(&mut self, seed: T) -> DeResult> { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .and_then(|n| seed.deserialize(n).map(Some)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:207:27 [INFO] [stdout] | [INFO] [stdout] 197 | fn next_key_seed>(&mut self, seed: T) -> DeResult> { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 207 | .and_then(|n| seed.deserialize(n).map(Some)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_postgres` (lib test) due to 4 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "b165032cdb7debc183f91ee50f8fe4b88819e2af15b66ec7e00c9a686ae9104f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b165032cdb7debc183f91ee50f8fe4b88819e2af15b66ec7e00c9a686ae9104f", kill_on_drop: false }` [INFO] [stdout] b165032cdb7debc183f91ee50f8fe4b88819e2af15b66ec7e00c9a686ae9104f