[INFO] fetching crate serde_json_any_key 2.0.0... [INFO] checking serde_json_any_key-2.0.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde_json_any_key 2.0.0 into /workspace/builds/worker-2-tc2/source [INFO] validating manifest of crates.io crate serde_json_any_key 2.0.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_json_any_key 2.0.0 [INFO] finished tweaking crates.io crate serde_json_any_key 2.0.0 [INFO] tweaked toml for crates.io crate serde_json_any_key 2.0.0 written to /workspace/builds/worker-2-tc2/source/Cargo.toml [INFO] crate crates.io crate serde_json_any_key 2.0.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 07decc99451e2c6f094a1f99dc3ac502ed358bbb15cfefe8c8e4309d2e9e0f93 [INFO] running `Command { std: "docker" "start" "-a" "07decc99451e2c6f094a1f99dc3ac502ed358bbb15cfefe8c8e4309d2e9e0f93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "07decc99451e2c6f094a1f99dc3ac502ed358bbb15cfefe8c8e4309d2e9e0f93", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "07decc99451e2c6f094a1f99dc3ac502ed358bbb15cfefe8c8e4309d2e9e0f93", kill_on_drop: false }` [INFO] [stdout] 07decc99451e2c6f094a1f99dc3ac502ed358bbb15cfefe8c8e4309d2e9e0f93 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 38052c2ca670ea8d500ed9e7411dcb2ca5a3e12e8be45bce53d66e6a474aff3d [INFO] running `Command { std: "docker" "start" "-a" "38052c2ca670ea8d500ed9e7411dcb2ca5a3e12e8be45bce53d66e6a474aff3d", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.39 [INFO] [stderr] Compiling unicode-ident v1.0.0 [INFO] [stderr] Compiling syn v1.0.95 [INFO] [stderr] Compiling serde_derive v1.0.137 [INFO] [stderr] Compiling serde v1.0.137 [INFO] [stderr] Compiling serde_json v1.0.81 [INFO] [stderr] Checking itoa v1.0.2 [INFO] [stderr] Checking ryu v1.0.10 [INFO] [stderr] Compiling quote v1.0.18 [INFO] [stderr] Checking serde_json_any_key v2.0.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:28 [INFO] [stdout] | [INFO] [stdout] 138 | fn to_json_map(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | serde_json::to_string(&SerializeMapIterWrapper { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 140 | | iter: RefCell::new(self.into_iter()) [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:374:28 [INFO] [stdout] | [INFO] [stdout] 373 | fn to_json_map(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | serde_json::to_string(&SerializeVecIterWrapper { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 375 | | iter: RefCell::new(self.into_iter()) [INFO] [stdout] 376 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:482:28 [INFO] [stdout] | [INFO] [stdout] 481 | fn into_json_map(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | serde_json::to_string(&SerializeConsumingIterWrapper { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 483 | | iter: RefCell::new(self.into_iter()) [INFO] [stdout] 484 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:663:20 [INFO] [stdout] | [INFO] [stdout] 650 | res.and_then(|value: (String,V)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | let key_obj: K = match TypeId::of::() == TypeId::of::() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 654 | true => match ::deserialize(serde_json::Value::from(value.0)) { [INFO] [stdout] 655 | Ok(k) => k, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 656 | Err(e) => { return Err(e).map_err(serde::de::Error::custom); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | Ok(k) => k, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 660 | Err(e) => { return Err(e).map_err(serde::de::Error::custom); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 663 | Ok((key_obj, value.1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 4 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_json_any_key` (lib) due to 5 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:139:28 [INFO] [stdout] | [INFO] [stdout] 138 | fn to_json_map(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 139 | serde_json::to_string(&SerializeMapIterWrapper { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 140 | | iter: RefCell::new(self.into_iter()) [INFO] [stdout] 141 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:374:28 [INFO] [stdout] | [INFO] [stdout] 373 | fn to_json_map(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 374 | serde_json::to_string(&SerializeVecIterWrapper { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 375 | | iter: RefCell::new(self.into_iter()) [INFO] [stdout] 376 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:482:28 [INFO] [stdout] | [INFO] [stdout] 481 | fn into_json_map(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 482 | serde_json::to_string(&SerializeConsumingIterWrapper { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 483 | | iter: RefCell::new(self.into_iter()) [INFO] [stdout] 484 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:663:20 [INFO] [stdout] | [INFO] [stdout] 650 | res.and_then(|value: (String,V)| { [INFO] [stdout] | ----------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 653 | let key_obj: K = match TypeId::of::() == TypeId::of::() { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 654 | true => match ::deserialize(serde_json::Value::from(value.0)) { [INFO] [stdout] 655 | Ok(k) => k, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 656 | Err(e) => { return Err(e).map_err(serde::de::Error::custom); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 659 | Ok(k) => k, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 660 | Err(e) => { return Err(e).map_err(serde::de::Error::custom); } [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 663 | Ok((key_obj, value.1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:1135:71 [INFO] [stdout] | [INFO] [stdout] 1135 | let string_map: HashMap = map.iter().map(|(k, &v)| (serde_json::to_string(k).unwrap(), v)).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_json_any_key` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "38052c2ca670ea8d500ed9e7411dcb2ca5a3e12e8be45bce53d66e6a474aff3d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "38052c2ca670ea8d500ed9e7411dcb2ca5a3e12e8be45bce53d66e6a474aff3d", kill_on_drop: false }` [INFO] [stdout] 38052c2ca670ea8d500ed9e7411dcb2ca5a3e12e8be45bce53d66e6a474aff3d