[INFO] fetching crate serde_eetf 0.2.0... [INFO] checking serde_eetf-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde_eetf 0.2.0 into /workspace/builds/worker-3-tc2/source [INFO] validating manifest of crates.io crate serde_eetf 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_eetf 0.2.0 [INFO] finished tweaking crates.io crate serde_eetf 0.2.0 [INFO] tweaked toml for crates.io crate serde_eetf 0.2.0 written to /workspace/builds/worker-3-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 25 packages to latest compatible versions [INFO] [stderr] Adding eetf v0.4.0 (latest: v0.9.0) [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding libflate v0.1.27 (latest: v2.1.0) [INFO] [stderr] Adding num v0.2.1 (latest: v0.4.3) [INFO] [stderr] Adding num-bigint v0.2.6 (latest: v0.4.6) [INFO] [stderr] Adding num-complex v0.2.4 (latest: v0.4.6) [INFO] [stderr] Adding num-rational v0.2.4 (latest: v0.4.2) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de2437daf9fa4a98866b31c10fb6d636191977de521fead4997533898564b0f8 [INFO] running `Command { std: "docker" "start" "-a" "de2437daf9fa4a98866b31c10fb6d636191977de521fead4997533898564b0f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de2437daf9fa4a98866b31c10fb6d636191977de521fead4997533898564b0f8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de2437daf9fa4a98866b31c10fb6d636191977de521fead4997533898564b0f8", kill_on_drop: false }` [INFO] [stdout] de2437daf9fa4a98866b31c10fb6d636191977de521fead4997533898564b0f8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 68f91959f9a683bf9c5b843a6b795a0f6525da6292f290fd32d820b5c4596300 [INFO] running `Command { std: "docker" "start" "-a" "68f91959f9a683bf9c5b843a6b795a0f6525da6292f290fd32d820b5c4596300", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling num-bigint v0.2.6 [INFO] [stderr] Compiling num-rational v0.2.4 [INFO] [stderr] Compiling num-complex v0.2.4 [INFO] [stderr] Checking rle-decode-fast v1.0.3 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking take_mut v0.2.2 [INFO] [stderr] Checking heck v0.3.3 [INFO] [stderr] Checking libflate v0.1.27 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num v0.2.1 [INFO] [stderr] Checking eetf v0.4.0 [INFO] [stderr] Checking serde_eetf v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:53:48 [INFO] [stdout] | [INFO] [stdout] 53 | formatter.write_str(std::error::Error::description(self)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/de.rs:790:10 [INFO] [stdout] | [INFO] [stdout] 790 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/de.rs:804:10 [INFO] [stdout] | [INFO] [stdout] 804 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/de.rs:821:10 [INFO] [stdout] | [INFO] [stdout] 821 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ser.rs:568:10 [INFO] [stdout] | [INFO] [stdout] 568 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ser.rs:582:10 [INFO] [stdout] | [INFO] [stdout] 582 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/ser.rs:602:10 [INFO] [stdout] | [INFO] [stdout] 602 | }; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:53:48 [INFO] [stdout] | [INFO] [stdout] 53 | formatter.write_str(std::error::Error::description(self)) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:89:38 [INFO] [stdout] | [INFO] [stdout] 89 | self::Error::DecodeError(err.description().to_string()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:468:34 [INFO] [stdout] | [INFO] [stdout] 467 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | ListDeserializer { iter: iter.fuse() } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:510:20 [INFO] [stdout] | [INFO] [stdout] 508 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | MapDeserializer { [INFO] [stdout] 510 | items: iter.fuse(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:541:15 [INFO] [stdout] | [INFO] [stdout] 533 | fn next_key_seed(&mut self, seed: K) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | match self.items.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:590:12 [INFO] [stdout] | [INFO] [stdout] 585 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant)> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | let val = seed.deserialize(VariantNameDeserializer::from_term(self.variant))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | Ok((val, self)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 20 | let term = value.serialize(&serializer)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | match term.encode(writer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | let serialized_value = value.serialize(self)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | Term::Atom(eetf::Atom::from(variant.to_snake_case())), [INFO] [stdout] 219 | | serialized_value, [INFO] [stdout] 220 | | ]))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 224 | let vec = match len { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(SequenceSerializer { items: vec }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:268:12 [INFO] [stdout] | [INFO] [stdout] 264 | let vec = match len { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | Ok(MapSerializer { items: vec }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(Term::List(eetf::List { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | elements: self.items, [INFO] [stdout] 308 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:327:12 [INFO] [stdout] | [INFO] [stdout] 326 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | Ok(Term::Tuple(eetf::Tuple { [INFO] [stdout] | ____________^ [INFO] [stdout] 328 | | elements: self.items, [INFO] [stdout] 329 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 347 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(Term::Tuple(eetf::Tuple { [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | elements: self.items, [INFO] [stdout] 350 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 368 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | // TODO: rename items to elements. [INFO] [stdout] 370 | let serialized_data = Term::Tuple(eetf::Tuple { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | self.name, [INFO] [stdout] 375 | | serialized_data, [INFO] [stdout] 376 | | ]))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:412:12 [INFO] [stdout] | [INFO] [stdout] 410 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | // TODO: rename items to entries. [INFO] [stdout] 412 | Ok(Term::Map(eetf::Map { [INFO] [stdout] | ____________^ [INFO] [stdout] 413 | | entries: self.items, [INFO] [stdout] 414 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:433:12 [INFO] [stdout] | [INFO] [stdout] 432 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | Ok(Term::Map(eetf::Map { [INFO] [stdout] | ____________^ [INFO] [stdout] 434 | | entries: self.items, [INFO] [stdout] 435 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:457:12 [INFO] [stdout] | [INFO] [stdout] 453 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 454 | let serialized_data = Term::Map(eetf::Map { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | Ok(Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] | ____________^ [INFO] [stdout] 458 | | self.name, [INFO] [stdout] 459 | | serialized_data, [INFO] [stdout] 460 | | ]))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 15 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/error.rs:89:38 [INFO] [stdout] | [INFO] [stdout] 89 | self::Error::DecodeError(err.description().to_string()) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_eetf` (lib) due to 16 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variant `AnotherOption` is never constructed [INFO] [stdout] --> src/ser.rs:567:13 [INFO] [stdout] | [INFO] [stdout] 565 | enum E { [INFO] [stdout] | - variant in this enum [INFO] [stdout] 566 | AnOption, [INFO] [stdout] 567 | AnotherOption, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:468:34 [INFO] [stdout] | [INFO] [stdout] 467 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 468 | ListDeserializer { iter: iter.fuse() } [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:510:20 [INFO] [stdout] | [INFO] [stdout] 508 | fn new(iter: I) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 509 | MapDeserializer { [INFO] [stdout] 510 | items: iter.fuse(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:541:15 [INFO] [stdout] | [INFO] [stdout] 533 | fn next_key_seed(&mut self, seed: K) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 541 | match self.items.next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:590:12 [INFO] [stdout] | [INFO] [stdout] 585 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant)> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 589 | let val = seed.deserialize(VariantNameDeserializer::from_term(self.variant))?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 590 | Ok((val, self)) [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de.rs:703:9 [INFO] [stdout] | [INFO] [stdout] 696 | fn deserialize(input: Term) -> T [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 703 | from_bytes(&cursor.into_inner()).expect("deserialize failed") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:21:11 [INFO] [stdout] | [INFO] [stdout] 20 | let term = value.serialize(&serializer)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 21 | match term.encode(writer) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:217:12 [INFO] [stdout] | [INFO] [stdout] 216 | let serialized_value = value.serialize(self)?; [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 217 | Ok(Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] | ____________^ [INFO] [stdout] 218 | | Term::Atom(eetf::Atom::from(variant.to_snake_case())), [INFO] [stdout] 219 | | serialized_value, [INFO] [stdout] 220 | | ]))) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |___________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:228:12 [INFO] [stdout] | [INFO] [stdout] 224 | let vec = match len { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 228 | Ok(SequenceSerializer { items: vec }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:268:12 [INFO] [stdout] | [INFO] [stdout] 264 | let vec = match len { [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 268 | Ok(MapSerializer { items: vec }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:306:12 [INFO] [stdout] | [INFO] [stdout] 305 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 306 | Ok(Term::List(eetf::List { [INFO] [stdout] | ____________^ [INFO] [stdout] 307 | | elements: self.items, [INFO] [stdout] 308 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:327:12 [INFO] [stdout] | [INFO] [stdout] 326 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 327 | Ok(Term::Tuple(eetf::Tuple { [INFO] [stdout] | ____________^ [INFO] [stdout] 328 | | elements: self.items, [INFO] [stdout] 329 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 347 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(Term::Tuple(eetf::Tuple { [INFO] [stdout] | ____________^ [INFO] [stdout] 349 | | elements: self.items, [INFO] [stdout] 350 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:373:12 [INFO] [stdout] | [INFO] [stdout] 368 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 369 | // TODO: rename items to elements. [INFO] [stdout] 370 | let serialized_data = Term::Tuple(eetf::Tuple { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 373 | Ok(Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] | ____________^ [INFO] [stdout] 374 | | self.name, [INFO] [stdout] 375 | | serialized_data, [INFO] [stdout] 376 | | ]))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:412:12 [INFO] [stdout] | [INFO] [stdout] 410 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 411 | // TODO: rename items to entries. [INFO] [stdout] 412 | Ok(Term::Map(eetf::Map { [INFO] [stdout] | ____________^ [INFO] [stdout] 413 | | entries: self.items, [INFO] [stdout] 414 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:433:12 [INFO] [stdout] | [INFO] [stdout] 432 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 433 | Ok(Term::Map(eetf::Map { [INFO] [stdout] | ____________^ [INFO] [stdout] 434 | | entries: self.items, [INFO] [stdout] 435 | | })) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:457:12 [INFO] [stdout] | [INFO] [stdout] 453 | fn end(self) -> Result { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 454 | let serialized_data = Term::Map(eetf::Map { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 457 | Ok(Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] | ____________^ [INFO] [stdout] 458 | | self.name, [INFO] [stdout] 459 | | serialized_data, [INFO] [stdout] 460 | | ]))) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:476:9 [INFO] [stdout] | [INFO] [stdout] 471 | fn serialize_and_decode(data: T) -> Term [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 476 | Term::decode(io::Cursor::new(bytes)).expect("Decode failed") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:497:13 [INFO] [stdout] | [INFO] [stdout] 489 | let result = serialize_and_decode(TestStruct { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 497 | / Term::Map(eetf::Map::from(vec![ [INFO] [stdout] 498 | | ( [INFO] [stdout] 499 | | Term::Atom(eetf::Atom::from("unsigned8")), [INFO] [stdout] 500 | | Term::FixInteger(eetf::FixInteger::from(129)) [INFO] [stdout] ... | [INFO] [stdout] 513 | | ) [INFO] [stdout] 514 | | ])) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:526:13 [INFO] [stdout] | [INFO] [stdout] 523 | let result = serialize_and_decode(TestStruct(-127, 30000, 65530, 65530)); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 526 | / Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] 527 | | Term::FixInteger(eetf::FixInteger::from(-127)), [INFO] [stdout] 528 | | Term::FixInteger(eetf::FixInteger::from(30000)), [INFO] [stdout] 529 | | Term::FixInteger(eetf::FixInteger::from(65530)), [INFO] [stdout] 530 | | Term::BigInteger(eetf::BigInteger::from(65530)), [INFO] [stdout] 531 | | ])) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:540:13 [INFO] [stdout] | [INFO] [stdout] 537 | let result = serialize_and_decode(("ABCD", vec![0, 1, 2])); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 540 | / Term::Tuple(eetf::Tuple::from(vec![ [INFO] [stdout] 541 | | Term::Binary(eetf::Binary::from("ABCD".as_bytes())), [INFO] [stdout] 542 | | Term::List(eetf::List::from(vec![ [INFO] [stdout] 543 | | Term::FixInteger(eetf::FixInteger::from(0)), [INFO] [stdout] ... | [INFO] [stdout] 546 | | ])) [INFO] [stdout] 547 | | ])) [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/ser.rs:572:28 [INFO] [stdout] | [INFO] [stdout] 570 | let result = serialize_and_decode(E::AnOption); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 571 | [INFO] [stdout] 572 | assert_eq!(result, Term::Atom(eetf::Atom::from("an_option"))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors; 9 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_eetf` (lib test) due to 22 previous errors; 9 warnings emitted [INFO] running `Command { std: "docker" "inspect" "68f91959f9a683bf9c5b843a6b795a0f6525da6292f290fd32d820b5c4596300", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "68f91959f9a683bf9c5b843a6b795a0f6525da6292f290fd32d820b5c4596300", kill_on_drop: false }` [INFO] [stdout] 68f91959f9a683bf9c5b843a6b795a0f6525da6292f290fd32d820b5c4596300