[INFO] fetching crate serde_columnar_derive 0.3.4... [INFO] checking serde_columnar_derive-0.3.4 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde_columnar_derive 0.3.4 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate serde_columnar_derive 0.3.4 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_columnar_derive 0.3.4 [INFO] finished tweaking crates.io crate serde_columnar_derive 0.3.4 [INFO] tweaked toml for crates.io crate serde_columnar_derive 0.3.4 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3440b179b31867761ecc50eea77f3615a1675a0f8812852118b99db6c31b5062 [INFO] running `Command { std: "docker" "start" "-a" "3440b179b31867761ecc50eea77f3615a1675a0f8812852118b99db6c31b5062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3440b179b31867761ecc50eea77f3615a1675a0f8812852118b99db6c31b5062", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3440b179b31867761ecc50eea77f3615a1675a0f8812852118b99db6c31b5062", kill_on_drop: false }` [INFO] [stdout] 3440b179b31867761ecc50eea77f3615a1675a0f8812852118b99db6c31b5062 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bccc81a0e4099becc61e6efa7502fd6c3f101b8d9db5d39b2e94c00de4debfc1 [INFO] running `Command { std: "docker" "start" "-a" "bccc81a0e4099becc61e6efa7502fd6c3f101b8d9db5d39b2e94c00de4debfc1", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking darling_core v0.20.10 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Checking darling v0.20.10 [INFO] [stderr] Checking serde_columnar_derive v0.3.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition name: `exhaustive` [INFO] [stdout] --> src/args.rs:442:30 [INFO] [stdout] | [INFO] [stdout] 442 | #[cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(exhaustive)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(exhaustive)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `exhaustive` [INFO] [stdout] --> src/args.rs:442:30 [INFO] [stdout] | [INFO] [stdout] 442 | #[cfg_attr(all(test, exhaustive), deny(non_exhaustive_omitted_patterns))] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `clippy`, `debug_assertions`, `doc`, `docsrs`, `doctest`, `feature`, `miri`, `overflow_checks`, `panic`, `proc_macro`, `relocation_model`, `rustfmt`, `sanitize`, `sanitizer_cfi_generalize_pointers`, `sanitizer_cfi_normalize_integers`, `target_abi`, `target_arch`, `target_endian`, `target_env`, `target_family`, `target_feature`, `target_has_atomic`, `target_has_atomic_equal_alignment`, `target_has_atomic_load_store`, `target_os`, `target_pointer_width`, `target_thread_local`, `target_vendor`, `test`, `ub_checks`, `unix`, and `windows` [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(exhaustive)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(exhaustive)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `vis` is never read [INFO] [stdout] --> src/args.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct FieldArgs { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | pub vis: syn::Visibility, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldArgs` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `skip` is never read [INFO] [stdout] --> src/args.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub struct VariantArgs { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | pub skip: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VariantArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ident`, `attrs`, `index`, and `optional` are never used [INFO] [stdout] --> src/args.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 99 | pub trait Args { [INFO] [stdout] | ---- methods in this trait [INFO] [stdout] 100 | fn ident(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 101 | fn ty(&self) -> Option; [INFO] [stdout] 102 | fn attrs(&self) -> &[syn::Attribute]; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 103 | fn index(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 104 | fn optional(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `original` and `borrowed` are never read [INFO] [stdout] --> src/attr.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct Context<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | pub original: &'a syn::DeriveInput, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 60 | pub derive_args: DeriveArgs, [INFO] [stdout] 61 | pub borrowed: BorrowedLifetimes, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ColumnarSerAttributes` is never used [INFO] [stdout] --> src/attr.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | pub trait ColumnarSerAttributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:11 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn columnar(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let attr_args = match NestedMeta::parse_meta_list(attr.into()) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let input = match add_consume_columnar_attribute(&input) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let st = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | -- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | match expand_columnar(attr_args, st) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 109 | fn expand_columnar(args: Vec, mut st: DeriveInput) -> syn::Result { [INFO] [stdout] | --------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let mut ans = vec![quote::quote!(#st)]; [INFO] [stdout] | --- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let context = Context::new(&st, derive_args)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let iter_token = TableIterParameter::from_ctx(&context)?.generate_iterable()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let field_args = parse_field_args(&mut st)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(quote!(#(#ans)*).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/de.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 199 | let e = if !field.optional { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | elements.push(quote::quote!( [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 217 | | let mut mapping = HashMap::new(); [INFO] [stdout] 218 | | while let Ok(Some((index, bytes))) = seq.next_element::<(usize, &'de [u8])>() { [INFO] [stdout] 219 | | // ignore [INFO] [stdout] ... | [INFO] [stdout] 222 | | [INFO] [stdout] 223 | | )); [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | | Ok((init_hashmap, e)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/ser.rs:31:27 [INFO] [stdout] | [INFO] [stdout] 31 | name: f.ident.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/ser.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | ty: f.ty.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attr.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 66 | let data = match &input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let (style, fields) = struct_from_ast(&data.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let borrowed = borrowed_lifetimes(data.fields())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | [INFO] [stdout] 86 | Ok(Context { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | ident: input.ident.clone(), [INFO] [stdout] 88 | | vis: input.vis.clone(), [INFO] [stdout] 89 | | data, [INFO] [stdout] ... | [INFO] [stdout] 93 | | borrowed, [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive/utils.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | predicates: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_columnar_derive` (lib test) due to 8 previous errors; 6 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: field `vis` is never read [INFO] [stdout] --> src/args.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 29 | pub struct FieldArgs { [INFO] [stdout] | --------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 32 | pub vis: syn::Visibility, [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `FieldArgs` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `skip` is never read [INFO] [stdout] --> src/args.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 57 | pub struct VariantArgs { [INFO] [stdout] | ----------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 67 | pub skip: bool, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `VariantArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `ident`, `attrs`, `index`, and `optional` are never used [INFO] [stdout] --> src/args.rs:100:8 [INFO] [stdout] | [INFO] [stdout] 99 | pub trait Args { [INFO] [stdout] | ---- methods in this trait [INFO] [stdout] 100 | fn ident(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 101 | fn ty(&self) -> Option; [INFO] [stdout] 102 | fn attrs(&self) -> &[syn::Attribute]; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 103 | fn index(&self) -> Option; [INFO] [stdout] | ^^^^^ [INFO] [stdout] 104 | fn optional(&self) -> bool; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `original` and `borrowed` are never read [INFO] [stdout] --> src/attr.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 51 | pub struct Context<'a> { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 59 | pub original: &'a syn::DeriveInput, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 60 | pub derive_args: DeriveArgs, [INFO] [stdout] 61 | pub borrowed: BorrowedLifetimes, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ColumnarSerAttributes` is never used [INFO] [stdout] --> src/attr.rs:102:11 [INFO] [stdout] | [INFO] [stdout] 102 | pub trait ColumnarSerAttributes { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:97:11 [INFO] [stdout] | [INFO] [stdout] 85 | pub fn columnar(attr: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 86 | let attr_args = match NestedMeta::parse_meta_list(attr.into()) { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 87 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 92 | let input = match add_consume_columnar_attribute(&input) { [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 93 | Ok(v) => v, [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 96 | let st = parse_macro_input!(input as DeriveInput); [INFO] [stdout] | -- ---------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 97 | match expand_columnar(attr_args, st) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:133:8 [INFO] [stdout] | [INFO] [stdout] 109 | fn expand_columnar(args: Vec, mut st: DeriveInput) -> syn::Result { [INFO] [stdout] | --------------------- ------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 112 | let mut ans = vec![quote::quote!(#st)]; [INFO] [stdout] | --- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | let context = Context::new(&st, derive_args)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 122 | let iter_token = TableIterParameter::from_ctx(&context)?.generate_iterable()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 127 | let field_args = parse_field_args(&mut st)?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 133 | Ok(quote!(#(#ans)*).into()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/de.rs:244:12 [INFO] [stdout] | [INFO] [stdout] 199 | let e = if !field.optional { [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 216 | elements.push(quote::quote!( [INFO] [stdout] | _______________________________- [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] | |_______________________________| [INFO] [stdout] 217 | | let mut mapping = HashMap::new(); [INFO] [stdout] 218 | | while let Ok(Some((index, bytes))) = seq.next_element::<(usize, &'de [u8])>() { [INFO] [stdout] 219 | | // ignore [INFO] [stdout] ... | [INFO] [stdout] 222 | | [INFO] [stdout] 223 | | )); [INFO] [stdout] | | - [INFO] [stdout] | |_________________| [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 244 | | Ok((init_hashmap, e)) [INFO] [stdout] | | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/ser.rs:31:27 [INFO] [stdout] | [INFO] [stdout] 31 | name: f.ident.clone().unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/serde/ser.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | ty: f.ty.clone(), [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/attr.rs:86:12 [INFO] [stdout] | [INFO] [stdout] 66 | let data = match &input.data { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | let (style, fields) = struct_from_ast(&data.fields)?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 84 | let borrowed = borrowed_lifetimes(data.fields())?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 85 | [INFO] [stdout] 86 | Ok(Context { [INFO] [stdout] | ____________^ [INFO] [stdout] 87 | | ident: input.ident.clone(), [INFO] [stdout] 88 | | vis: input.vis.clone(), [INFO] [stdout] 89 | | data, [INFO] [stdout] ... | [INFO] [stdout] 93 | | borrowed, [INFO] [stdout] 94 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/derive/utils.rs:9:21 [INFO] [stdout] | [INFO] [stdout] 9 | predicates: Default::default(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 6 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_columnar_derive` (lib) due to 8 previous errors; 6 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bccc81a0e4099becc61e6efa7502fd6c3f101b8d9db5d39b2e94c00de4debfc1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bccc81a0e4099becc61e6efa7502fd6c3f101b8d9db5d39b2e94c00de4debfc1", kill_on_drop: false }` [INFO] [stdout] bccc81a0e4099becc61e6efa7502fd6c3f101b8d9db5d39b2e94c00de4debfc1