[INFO] fetching crate serde_columnar 0.3.7... [INFO] checking serde_columnar-0.3.7 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde_columnar 0.3.7 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate serde_columnar 0.3.7 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde_columnar 0.3.7 [INFO] removed 0 missing examples [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate serde_columnar 0.3.7 [INFO] tweaked toml for crates.io crate serde_columnar 0.3.7 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] crate crates.io crate serde_columnar 0.3.7 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a9b200027c8413c9b377fbb3cfb8deed98bae92df41a01ff06cc3391629086f9 [INFO] running `Command { std: "docker" "start" "-a" "a9b200027c8413c9b377fbb3cfb8deed98bae92df41a01ff06cc3391629086f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a9b200027c8413c9b377fbb3cfb8deed98bae92df41a01ff06cc3391629086f9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a9b200027c8413c9b377fbb3cfb8deed98bae92df41a01ff06cc3391629086f9", kill_on_drop: false }` [INFO] [stdout] a9b200027c8413c9b377fbb3cfb8deed98bae92df41a01ff06cc3391629086f9 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 199af6acfde847985a37c86000825b2b85a2d255fdee8b4fa09809727a1dabe8 [INFO] running `Command { std: "docker" "start" "-a" "199af6acfde847985a37c86000825b2b85a2d255fdee8b4fa09809727a1dabe8", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.66 [INFO] [stderr] Compiling unicode-ident v1.0.11 [INFO] [stderr] Compiling serde v1.0.188 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling semver v1.0.18 [INFO] [stderr] Compiling libc v0.2.147 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling lock_api v0.4.10 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling num-traits v0.2.16 [INFO] [stderr] Compiling rustix v0.38.11 [INFO] [stderr] Compiling rayon-core v1.11.0 [INFO] [stderr] Checking byteorder v1.4.3 [INFO] [stderr] Compiling serde_json v1.0.104 [INFO] [stderr] Checking linux-raw-sys v0.4.5 [INFO] [stderr] Checking ryu v1.0.15 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking plotters-backend v0.3.5 [INFO] [stderr] Checking clap_lex v0.5.1 [INFO] [stderr] Checking bitflags v2.4.0 [INFO] [stderr] Checking itoa v1.0.9 [INFO] [stderr] Compiling thiserror v1.0.44 [INFO] [stderr] Checking ciborium-io v0.2.1 [INFO] [stderr] Checking anstyle v1.0.2 [INFO] [stderr] Checking regex-syntax v0.7.4 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking half v1.8.2 [INFO] [stderr] Checking plotters-svg v0.3.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking cobs v0.2.3 [INFO] [stderr] Checking same-file v1.0.6 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking clap_builder v4.4.2 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking crossbeam-channel v0.5.8 [INFO] [stderr] Checking oorandom v11.1.3 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking ciborium-ll v0.2.1 [INFO] [stderr] Checking once_cell v1.18.0 [INFO] [stderr] Checking similar v2.2.1 [INFO] [stderr] Compiling heapless v0.7.16 [INFO] [stderr] Compiling quote v1.0.32 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Compiling syn v2.0.28 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking plotters v0.3.5 [INFO] [stderr] Checking num_cpus v1.16.0 [INFO] [stderr] Checking console v0.15.7 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking regex-automata v0.3.6 [INFO] [stderr] Checking clap v4.4.2 [INFO] [stderr] Checking rayon v1.7.0 [INFO] [stderr] Checking regex v1.9.3 [INFO] [stderr] Compiling darling_core v0.20.3 [INFO] [stderr] Compiling serde_derive v1.0.188 [INFO] [stderr] Compiling thiserror-impl v1.0.44 [INFO] [stderr] Compiling darling_macro v0.20.3 [INFO] [stderr] Compiling darling v0.20.3 [INFO] [stderr] Compiling serde_columnar_derive v0.3.4 [INFO] [stderr] Checking ciborium v0.2.1 [INFO] [stderr] Checking insta v1.31.0 [INFO] [stderr] Checking postcard v1.0.6 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking serde_columnar v0.3.7 (/opt/rustwide/workdir) [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/column/mod.rs:113:12 [INFO] [stdout] | [INFO] [stdout] 112 | let data = Deserialize::deserialize(columnar_decoder.deref_mut())?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 113 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 114 | | data, [INFO] [stdout] 115 | | attr: ColumnAttr::empty(), [INFO] [stdout] 116 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/column/rle.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 52 | let mut rle_decoder = AnyRleDecoder::new(bytes); [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 53 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 54 | | data: rle_decoder.decode()?, [INFO] [stdout] 55 | | attr: ColumnAttr::empty(), [INFO] [stdout] 56 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/iterable.rs:261:12 [INFO] [stdout] | [INFO] [stdout] 256 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 261 | Ok(AnyRleIter::new(bytes)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap.rs:36:14 [INFO] [stdout] | [INFO] [stdout] 35 | fn from(vec: IT) -> Self { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 36 | Self(Cow::Owned(vec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap.rs:74:12 [INFO] [stdout] | [INFO] [stdout] 70 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 74 | Ok(ColumnarVec(Cow::Owned(T::deserialize_columns( [INFO] [stdout] | ____________^ [INFO] [stdout] 75 | | deserializer, [INFO] [stdout] 76 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/wrap.rs:131:12 [INFO] [stdout] | [INFO] [stdout] 127 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 131 | Ok(ColumnarMap(Cow::Owned(T::deserialize_columns( [INFO] [stdout] | ____________^ [INFO] [stdout] 132 | | deserializer, [INFO] [stdout] 133 | | )?))) [INFO] [stdout] | |____________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde_columnar` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "199af6acfde847985a37c86000825b2b85a2d255fdee8b4fa09809727a1dabe8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "199af6acfde847985a37c86000825b2b85a2d255fdee8b4fa09809727a1dabe8", kill_on_drop: false }` [INFO] [stdout] 199af6acfde847985a37c86000825b2b85a2d255fdee8b4fa09809727a1dabe8