[INFO] fetching crate serde-tc-macro 0.4.0... [INFO] checking serde-tc-macro-0.4.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde-tc-macro 0.4.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate serde-tc-macro 0.4.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde-tc-macro 0.4.0 [INFO] finished tweaking crates.io crate serde-tc-macro 0.4.0 [INFO] tweaked toml for crates.io crate serde-tc-macro 0.4.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 12 packages to latest compatible versions [INFO] [stderr] Adding heck v0.3.3 (latest: v0.5.0) [INFO] [stderr] Adding proc-macro-crate v0.1.5 (latest: v3.2.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4715eb8c7df233e672c09caabad9a2d7e849a82a7dc859335c9eb702b84f3ffa [INFO] running `Command { std: "docker" "start" "-a" "4715eb8c7df233e672c09caabad9a2d7e849a82a7dc859335c9eb702b84f3ffa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4715eb8c7df233e672c09caabad9a2d7e849a82a7dc859335c9eb702b84f3ffa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4715eb8c7df233e672c09caabad9a2d7e849a82a7dc859335c9eb702b84f3ffa", kill_on_drop: false }` [INFO] [stdout] 4715eb8c7df233e672c09caabad9a2d7e849a82a7dc859335c9eb702b84f3ffa [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f4f443a1c9cff21e303036cdbf96454152291a286783b14f69552133c8bf7c6e [INFO] running `Command { std: "docker" "start" "-a" "f4f443a1c9cff21e303036cdbf96454152291a286783b14f69552133c8bf7c6e", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Checking unicode-ident v1.0.12 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking unicode-segmentation v1.11.0 [INFO] [stderr] Checking proc-macro2 v1.0.86 [INFO] [stderr] Checking heck v0.3.3 [INFO] [stderr] Checking quote v1.0.37 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking proc-macro-crate v0.1.5 [INFO] [stderr] Checking serde-tc-macro v0.4.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `encoder` and `dispatcher` are never read [INFO] [stdout] --> src/args.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct MacroArgs { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | pub encoder: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | pub dispatcher: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MacroArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn serde_tc(args: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | match expand(TokenStream2::from(args), TokenStream2::from(input)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn serde_tc_full(_args: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | match expand( [INFO] [stdout] | ___________^ [INFO] [stdout] 26 | | quote! {dispatcher, encoder, dict, tuple, async_methods, fallible = anyhow::Error, stub}, [INFO] [stdout] 27 | | TokenStream2::from(input), [INFO] [stdout] 28 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 13 | let arg_name = input.parse()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | input.parse::()?; [INFO] [stdout] 15 | let arg_value = input.parse()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | arg_name, [INFO] [stdout] 18 | | arg_value, [INFO] [stdout] 19 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:121:27 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn fill_default_values(self) -> MacroArgs { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | MacroArgs { [INFO] [stdout] 121 | serde_format: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 122 | | .serde_format [INFO] [stdout] 123 | | .unwrap_or_else(|| syn::parse2(quote! {serde_json}).unwrap()), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:123:36 [INFO] [stdout] | [INFO] [stdout] 123 | .unwrap_or_else(|| syn::parse2(quote! {serde_json}).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde-tc-macro` (lib test) due to 6 previous errors; 1 warning emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: fields `encoder` and `dispatcher` are never read [INFO] [stdout] --> src/args.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 37 | pub struct MacroArgs { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 41 | pub encoder: bool, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 42 | pub dispatcher: bool, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `MacroArgs` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:17:11 [INFO] [stdout] | [INFO] [stdout] 16 | pub fn serde_tc(args: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ----------------- ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 17 | match expand(TokenStream2::from(args), TokenStream2::from(input)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:25:11 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn serde_tc_full(_args: TokenStream, input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | match expand( [INFO] [stdout] | ___________^ [INFO] [stdout] 26 | | quote! {dispatcher, encoder, dict, tuple, async_methods, fallible = anyhow::Error, stub}, [INFO] [stdout] 27 | | TokenStream2::from(input), [INFO] [stdout] 28 | | ) { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:16:12 [INFO] [stdout] | [INFO] [stdout] 13 | let arg_name = input.parse()?; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 14 | input.parse::()?; [INFO] [stdout] 15 | let arg_value = input.parse()?; [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 16 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 17 | | arg_name, [INFO] [stdout] 18 | | arg_value, [INFO] [stdout] 19 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:121:27 [INFO] [stdout] | [INFO] [stdout] 119 | pub fn fill_default_values(self) -> MacroArgs { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | MacroArgs { [INFO] [stdout] 121 | serde_format: self [INFO] [stdout] | ___________________________^ [INFO] [stdout] 122 | | .serde_format [INFO] [stdout] 123 | | .unwrap_or_else(|| syn::parse2(quote! {serde_json}).unwrap()), [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/args.rs:123:36 [INFO] [stdout] | [INFO] [stdout] 123 | .unwrap_or_else(|| syn::parse2(quote! {serde_json}).unwrap()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde-tc-macro` (lib) due to 6 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "f4f443a1c9cff21e303036cdbf96454152291a286783b14f69552133c8bf7c6e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f4f443a1c9cff21e303036cdbf96454152291a286783b14f69552133c8bf7c6e", kill_on_drop: false }` [INFO] [stdout] f4f443a1c9cff21e303036cdbf96454152291a286783b14f69552133c8bf7c6e