[INFO] fetching crate serde-smile 0.2.1... [INFO] checking serde-smile-0.2.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde-smile 0.2.1 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate serde-smile 0.2.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde-smile 0.2.1 [INFO] finished tweaking crates.io crate serde-smile 0.2.1 [INFO] tweaked toml for crates.io crate serde-smile 0.2.1 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 16 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] b7d098dfcd5a1df5b3a0ed5e07ce7e94724f0419379e5cb0831183ee1de9f7c0 [INFO] running `Command { std: "docker" "start" "-a" "b7d098dfcd5a1df5b3a0ed5e07ce7e94724f0419379e5cb0831183ee1de9f7c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "b7d098dfcd5a1df5b3a0ed5e07ce7e94724f0419379e5cb0831183ee1de9f7c0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b7d098dfcd5a1df5b3a0ed5e07ce7e94724f0419379e5cb0831183ee1de9f7c0", kill_on_drop: false }` [INFO] [stdout] b7d098dfcd5a1df5b3a0ed5e07ce7e94724f0419379e5cb0831183ee1de9f7c0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c1a8c9b8995f7cbedf1cb994529a6b9ff09dd24e6ae4246a1c4d0b93fac317fb [INFO] running `Command { std: "docker" "start" "-a" "c1a8c9b8995f7cbedf1cb994529a6b9ff09dd24e6ae4246a1c4d0b93fac317fb", kill_on_drop: false }` [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking indexmap v2.5.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde-smile v0.2.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:103:27 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn from_reader(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Deserializer::new(IoRead::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:500:32 [INFO] [stdout] | [INFO] [stdout] 496 | fn parse_array(&mut self, visitor: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | self.recursion_checked(|de| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 501 | | let value = visitor.visit_seq(SeqAccess { de })?; [INFO] [stdout] 502 | | match de.reader.next()? { [INFO] [stdout] 503 | | Some(0xf9) => Ok(value), [INFO] [stdout] ... | [INFO] [stdout] 506 | | } [INFO] [stdout] 507 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:514:32 [INFO] [stdout] | [INFO] [stdout] 510 | fn parse_map(&mut self, visitor: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 514 | self.recursion_checked(|de| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 515 | | let value = visitor.visit_map(MapAccess { de })?; [INFO] [stdout] 516 | | match de.reader.next()? { [INFO] [stdout] 517 | | Some(0xfb) => Ok(value), [INFO] [stdout] ... | [INFO] [stdout] 520 | | } [INFO] [stdout] 521 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:727:9 [INFO] [stdout] | [INFO] [stdout] 717 | fn next_element_seed(&mut self, seed: T) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | seed.deserialize(&mut *self.de).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 741 | fn next_key_seed(&mut self, seed: K) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 751 | seed.deserialize(KeyDeserializer { de: &mut *self.de }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:780:12 [INFO] [stdout] | [INFO] [stdout] 775 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | let variant = seed.deserialize(KeyDeserializer { de: &mut *self.de })?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 780 | Ok((variant, self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:837:12 [INFO] [stdout] | [INFO] [stdout] 832 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | let variant = seed.deserialize(&mut *self.de)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 837 | Ok((variant, self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:855:13 [INFO] [stdout] | [INFO] [stdout] 851 | fn newtype_variant_seed(self, _seed: T) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 855 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 856 | | de::Unexpected::UnitVariant, [INFO] [stdout] 857 | | &"newtype variant", [INFO] [stdout] 858 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:865:13 [INFO] [stdout] | [INFO] [stdout] 861 | fn tuple_variant(self, _len: usize, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 865 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 866 | | de::Unexpected::UnitVariant, [INFO] [stdout] 867 | | &"tuple variant", [INFO] [stdout] 868 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:879:13 [INFO] [stdout] | [INFO] [stdout] 874 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 879 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 880 | | de::Unexpected::UnitVariant, [INFO] [stdout] 881 | | &"struct variant", [INFO] [stdout] 882 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/big_integer_deserializer.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn next_key_seed(&mut self, seed: K) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | seed.deserialize(BorrowedStrDeserializer::new(BigInteger::FIELD_NAME)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 201 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let variant = seed.deserialize(self.de)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Ok((variant, UnitVariantAccess)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 219 | fn newtype_variant_seed(self, _seed: T) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 224 | | de::Unexpected::UnitVariant, [INFO] [stdout] 225 | | &"newtype variant", [INFO] [stdout] 226 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 229 | fn tuple_variant(self, _len: usize, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 234 | | de::Unexpected::UnitVariant, [INFO] [stdout] 235 | | &"tuple variant", [INFO] [stdout] 236 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 242 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 248 | | de::Unexpected::UnitVariant, [INFO] [stdout] 249 | | &"struct variant", [INFO] [stdout] 250 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 63 | fn custom(msg: T) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Error(Box::new(ErrorKind::Custom(msg.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:76:15 [INFO] [stdout] | [INFO] [stdout] 72 | fn custom(msg: T) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Error(Box::new(ErrorKind::Custom(msg.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn io(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Error(Box::new(ErrorKind::Io(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 162 | fn visit_seq(self, mut seq: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let mut vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Value::Array(vec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 173 | fn visit_map(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let mut v = IndexMap::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Ok(Value::Object(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/big_integer.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) fn finish_map<'de, A>(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | map.next_value::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde-smile` (lib) due to 22 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:103:27 [INFO] [stdout] | [INFO] [stdout] 102 | pub fn from_reader(reader: R) -> Self { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 103 | Deserializer::new(IoRead::new(reader)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:500:32 [INFO] [stdout] | [INFO] [stdout] 496 | fn parse_array(&mut self, visitor: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 500 | self.recursion_checked(|de| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 501 | | let value = visitor.visit_seq(SeqAccess { de })?; [INFO] [stdout] 502 | | match de.reader.next()? { [INFO] [stdout] 503 | | Some(0xf9) => Ok(value), [INFO] [stdout] ... | [INFO] [stdout] 506 | | } [INFO] [stdout] 507 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:514:32 [INFO] [stdout] | [INFO] [stdout] 510 | fn parse_map(&mut self, visitor: V) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 514 | self.recursion_checked(|de| { [INFO] [stdout] | ________________________________^ [INFO] [stdout] 515 | | let value = visitor.visit_map(MapAccess { de })?; [INFO] [stdout] 516 | | match de.reader.next()? { [INFO] [stdout] 517 | | Some(0xfb) => Ok(value), [INFO] [stdout] ... | [INFO] [stdout] 520 | | } [INFO] [stdout] 521 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:727:9 [INFO] [stdout] | [INFO] [stdout] 717 | fn next_element_seed(&mut self, seed: T) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 727 | seed.deserialize(&mut *self.de).map(Some) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:751:9 [INFO] [stdout] | [INFO] [stdout] 741 | fn next_key_seed(&mut self, seed: K) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 751 | seed.deserialize(KeyDeserializer { de: &mut *self.de }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:780:12 [INFO] [stdout] | [INFO] [stdout] 775 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 779 | let variant = seed.deserialize(KeyDeserializer { de: &mut *self.de })?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 780 | Ok((variant, self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:837:12 [INFO] [stdout] | [INFO] [stdout] 832 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 836 | let variant = seed.deserialize(&mut *self.de)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 837 | Ok((variant, self)) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:855:13 [INFO] [stdout] | [INFO] [stdout] 851 | fn newtype_variant_seed(self, _seed: T) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 855 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 856 | | de::Unexpected::UnitVariant, [INFO] [stdout] 857 | | &"newtype variant", [INFO] [stdout] 858 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:865:13 [INFO] [stdout] | [INFO] [stdout] 861 | fn tuple_variant(self, _len: usize, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 865 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 866 | | de::Unexpected::UnitVariant, [INFO] [stdout] 867 | | &"tuple variant", [INFO] [stdout] 868 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/mod.rs:879:13 [INFO] [stdout] | [INFO] [stdout] 874 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 879 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 880 | | de::Unexpected::UnitVariant, [INFO] [stdout] 881 | | &"struct variant", [INFO] [stdout] 882 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/big_integer_deserializer.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 15 | fn next_key_seed(&mut self, seed: K) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 23 | seed.deserialize(BorrowedStrDeserializer::new(BigInteger::FIELD_NAME)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:206:12 [INFO] [stdout] | [INFO] [stdout] 201 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 205 | let variant = seed.deserialize(self.de)?; [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 206 | Ok((variant, UnitVariantAccess)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 219 | fn newtype_variant_seed(self, _seed: T) -> Result [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 223 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 224 | | de::Unexpected::UnitVariant, [INFO] [stdout] 225 | | &"newtype variant", [INFO] [stdout] 226 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:233:13 [INFO] [stdout] | [INFO] [stdout] 229 | fn tuple_variant(self, _len: usize, _visitor: V) -> Result [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 233 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 234 | | de::Unexpected::UnitVariant, [INFO] [stdout] 235 | | &"tuple variant", [INFO] [stdout] 236 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/key_deserializer.rs:247:13 [INFO] [stdout] | [INFO] [stdout] 242 | _visitor: V, [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 247 | Err(de::Error::invalid_type( [INFO] [stdout] | _____________^ [INFO] [stdout] 248 | | de::Unexpected::UnitVariant, [INFO] [stdout] 249 | | &"struct variant", [INFO] [stdout] 250 | | )) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:67:15 [INFO] [stdout] | [INFO] [stdout] 63 | fn custom(msg: T) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 67 | Error(Box::new(ErrorKind::Custom(msg.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:76:15 [INFO] [stdout] | [INFO] [stdout] 72 | fn custom(msg: T) -> Self [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 76 | Error(Box::new(ErrorKind::Custom(msg.to_string()))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/error.rs:82:15 [INFO] [stdout] | [INFO] [stdout] 81 | pub(crate) fn io(e: io::Error) -> Self { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 82 | Error(Box::new(ErrorKind::Io(e))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:170:12 [INFO] [stdout] | [INFO] [stdout] 162 | fn visit_seq(self, mut seq: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 166 | let mut vec = vec![]; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 170 | Ok(Value::Array(vec)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/mod.rs:196:12 [INFO] [stdout] | [INFO] [stdout] 173 | fn visit_map(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 177 | let mut v = IndexMap::new(); [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 196 | Ok(Value::Object(v)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value/big_integer.rs:68:9 [INFO] [stdout] | [INFO] [stdout] 64 | pub(crate) fn finish_map<'de, A>(self, mut map: A) -> Result [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 68 | map.next_value::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 21 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde-smile` (lib test) due to 22 previous errors [INFO] running `Command { std: "docker" "inspect" "c1a8c9b8995f7cbedf1cb994529a6b9ff09dd24e6ae4246a1c4d0b93fac317fb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c1a8c9b8995f7cbedf1cb994529a6b9ff09dd24e6ae4246a1c4d0b93fac317fb", kill_on_drop: false }` [INFO] [stdout] c1a8c9b8995f7cbedf1cb994529a6b9ff09dd24e6ae4246a1c4d0b93fac317fb