[INFO] fetching crate serde-loader 0.2.0... [INFO] checking serde-loader-0.2.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde-loader 0.2.0 into /workspace/builds/worker-1-tc2/source [INFO] validating manifest of crates.io crate serde-loader 0.2.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde-loader 0.2.0 [INFO] finished tweaking crates.io crate serde-loader 0.2.0 [INFO] tweaked toml for crates.io crate serde-loader 0.2.0 written to /workspace/builds/worker-1-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 43 packages to latest compatible versions [INFO] [stderr] Adding generic-array v0.14.7 (latest: v1.1.0) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding prost v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding prost-derive v0.11.9 (latest: v0.13.2) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0e8a18a3335ba202bc942599023235e1da676647d9a60a24936d1c4c2fe7d75f [INFO] running `Command { std: "docker" "start" "-a" "0e8a18a3335ba202bc942599023235e1da676647d9a60a24936d1c4c2fe7d75f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0e8a18a3335ba202bc942599023235e1da676647d9a60a24936d1c4c2fe7d75f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0e8a18a3335ba202bc942599023235e1da676647d9a60a24936d1c4c2fe7d75f", kill_on_drop: false }` [INFO] [stdout] 0e8a18a3335ba202bc942599023235e1da676647d9a60a24936d1c4c2fe7d75f [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] bd3f1702ff523ceb01a441e2a7b32b1cbcd6b508f085fbc36b3f44c165593e58 [INFO] running `Command { std: "docker" "start" "-a" "bd3f1702ff523ceb01a441e2a7b32b1cbcd6b508f085fbc36b3f44c165593e58", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking serde-loader v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `Context as _` [INFO] [stdout] --> src/common.rs:1:30 [INFO] [stdout] | [INFO] [stdout] 1 | pub use anyhow::{format_err, Context as _, Result}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `fs`, `mem::ManuallyDrop`, `ptr::NonNull`, and `ptr` [INFO] [stdout] --> src/common.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | fmt, fs, io, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 17 | mem::ManuallyDrop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | ptr, [INFO] [stdout] | ^^^ [INFO] [stdout] 21 | ptr::NonNull, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `Context as _` [INFO] [stdout] --> src/common.rs:1:30 [INFO] [stdout] | [INFO] [stdout] 1 | pub use anyhow::{format_err, Context as _, Result}; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `fs`, `mem::ManuallyDrop`, `ptr::NonNull`, and `ptr` [INFO] [stdout] --> src/common.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | fmt, fs, io, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 17 | mem::ManuallyDrop, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 20 | ptr, [INFO] [stdout] | ^^^ [INFO] [stdout] 21 | ptr::NonNull, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn open

(path: P) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let data = with_rebased_dir(parent, || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | inner: Some(Inner { [INFO] [stdout] 59 | | data, [INFO] [stdout] 60 | | ref_path: ref_path.to_path_buf(), [INFO] [stdout] ... | [INFO] [stdout] 63 | | _phantom: PhantomData, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn open_and_take

(path: P) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Self::open(path)?.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn create

(path: P, data: T) -> Result> [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | inner: Some(Inner { [INFO] [stdout] 110 | | data, [INFO] [stdout] 111 | | ref_path: ref_path.to_path_buf(), [INFO] [stdout] ... | [INFO] [stdout] 114 | | _phantom: PhantomData, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn take(mut self) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | self.inner.take().unwrap().data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 208 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Self::open(ref_path).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:57:12 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn open

(path: P) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | let data = with_rebased_dir(parent, || { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 57 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 58 | | inner: Some(Inner { [INFO] [stdout] 59 | | data, [INFO] [stdout] 60 | | ref_path: ref_path.to_path_buf(), [INFO] [stdout] ... | [INFO] [stdout] 63 | | _phantom: PhantomData, [INFO] [stdout] 64 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:72:12 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn open_and_take

(path: P) -> Result> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 72 | Ok(Self::open(path)?.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:108:12 [INFO] [stdout] | [INFO] [stdout] 80 | pub fn create

(path: P, data: T) -> Result> [INFO] [stdout] | ------- ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 108 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 109 | | inner: Some(Inner { [INFO] [stdout] 110 | | data, [INFO] [stdout] 111 | | ref_path: ref_path.to_path_buf(), [INFO] [stdout] ... | [INFO] [stdout] 114 | | _phantom: PhantomData, [INFO] [stdout] 115 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:149:9 [INFO] [stdout] | [INFO] [stdout] 148 | pub fn take(mut self) -> T { [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 149 | self.inner.take().unwrap().data [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/file.rs:213:9 [INFO] [stdout] | [INFO] [stdout] 208 | fn deserialize(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 213 | Self::open(ref_path).map_err(D::Error::custom) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde-loader` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `serde-loader` (lib test) due to 6 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "bd3f1702ff523ceb01a441e2a7b32b1cbcd6b508f085fbc36b3f44c165593e58", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "bd3f1702ff523ceb01a441e2a7b32b1cbcd6b508f085fbc36b3f44c165593e58", kill_on_drop: false }` [INFO] [stdout] bd3f1702ff523ceb01a441e2a7b32b1cbcd6b508f085fbc36b3f44c165593e58