[INFO] fetching crate serde-firestore-value 0.9.0... [INFO] checking serde-firestore-value-0.9.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate serde-firestore-value 0.9.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate serde-firestore-value 0.9.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate serde-firestore-value 0.9.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate serde-firestore-value 0.9.0 [INFO] tweaked toml for crates.io crate serde-firestore-value 0.9.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding addr2line v0.22.0 (latest: v0.24.1) [INFO] [stderr] Adding gimli v0.29.0 (latest: v0.31.0) [INFO] [stderr] Adding googleapis-tonic-google-api v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding googleapis-tonic-google-firestore-v1 v0.6.0 (latest: v0.7.0) [INFO] [stderr] Adding miniz_oxide v0.7.4 (latest: v0.8.0) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ab454d4fdc9e63e3d093b9cda3dd822f0021f4cdbd5e55093374d319c01c8149 [INFO] running `Command { std: "docker" "start" "-a" "ab454d4fdc9e63e3d093b9cda3dd822f0021f4cdbd5e55093374d319c01c8149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ab454d4fdc9e63e3d093b9cda3dd822f0021f4cdbd5e55093374d319c01c8149", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ab454d4fdc9e63e3d093b9cda3dd822f0021f4cdbd5e55093374d319c01c8149", kill_on_drop: false }` [INFO] [stdout] ab454d4fdc9e63e3d093b9cda3dd822f0021f4cdbd5e55093374d319c01c8149 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f41dadf03a5376fd41193f0c8c287ce07f1ac67e687933924b743a922e53cf3b [INFO] running `Command { std: "docker" "start" "-a" "f41dadf03a5376fd41193f0c8c287ce07f1ac67e687933924b743a922e53cf3b", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling either v1.13.0 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking tokio v1.40.0 [INFO] [stderr] Checking http-body-util v0.1.2 [INFO] [stderr] Compiling itertools v0.13.0 [INFO] [stderr] Checking tokio-stream v0.1.15 [INFO] [stderr] Compiling prost-derive v0.13.2 [INFO] [stderr] Compiling pin-project-internal v1.1.5 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling async-trait v0.1.81 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Checking pin-project v1.1.5 [INFO] [stderr] Checking thiserror v1.0.63 [INFO] [stderr] Checking prost v0.13.2 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking prost-types v0.13.2 [INFO] [stderr] Checking tonic v0.12.2 [INFO] [stderr] Checking googleapis-tonic-google-rpc v0.6.0 [INFO] [stderr] Checking googleapis-tonic-google-api v0.6.0 [INFO] [stderr] Checking googleapis-tonic-google-type v0.6.0 [INFO] [stderr] Checking serde v1.0.209 [INFO] [stderr] Checking googleapis-tonic-google-firestore-v1 v0.6.0 [INFO] [stderr] Checking serde_json v1.0.127 [INFO] [stderr] Checking serde-firestore-value v0.9.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/firestore_array_value_deserializer.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 23 | fn next_element_seed(&mut self, seed: T) -> Result, Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | / self.iter [INFO] [stdout] 28 | | .next() [INFO] [stdout] 29 | | .map(|value| seed.deserialize(FirestoreValueDeserializer::new(value))) [INFO] [stdout] | |__________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/firestore_enum_deserializer.rs:28:9 [INFO] [stdout] | [INFO] [stdout] 24 | fn variant_seed(self, seed: V) -> Result<(V::Value, Self::Variant), Self::Error> [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 28 | seed.deserialize(FirestoreValueDeserializer::new(self.value)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/lat_lng_as_geo_point.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub(crate) fn deserialize_lat_lng<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 10 | LatLng::deserialize(deserializer).map(GoogleApiProtoLatLng::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/lat_lng_as_geo_point.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 14 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 19 | Option::::deserialize(deserializer).map(|o| o.map(GoogleApiProtoLatLng::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/string_as_reference.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub(crate) fn deserialize_string_as_reference<'de, D>(deserializer: D) -> Result [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 9 | Reference::deserialize(deserializer).map(String::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/string_as_reference.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 13 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 18 | Option::::deserialize(deserializer).map(|o| o.map(String::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/string_as_reference.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 22 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 27 | Vec::::deserialize(deserializer).map(|o| o.into_iter().map(String::from).collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/timestamp_as_timestamp.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 6 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 11 | Timestamp::deserialize(deserializer).map(prost_types::Timestamp::from) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/de/with/timestamp_as_timestamp.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 15 | deserializer: D, [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | Option::::deserialize(deserializer).map(|o| o.map(prost_types::Timestamp::from)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/value_ext.rs:100:25 [INFO] [stdout] | [INFO] [stdout] 93 | fn from_fields(fields: I) -> Self [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 100 | fields: fields [INFO] [stdout] | _________________________^ [INFO] [stdout] 101 | | .into_iter() [INFO] [stdout] 102 | | .map(|(s, v)| (s.into(), v)) [INFO] [stdout] | |________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 10 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `serde-firestore-value` (lib) due to 11 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] running `Command { std: "docker" "inspect" "f41dadf03a5376fd41193f0c8c287ce07f1ac67e687933924b743a922e53cf3b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f41dadf03a5376fd41193f0c8c287ce07f1ac67e687933924b743a922e53cf3b", kill_on_drop: false }` [INFO] [stdout] f41dadf03a5376fd41193f0c8c287ce07f1ac67e687933924b743a922e53cf3b