[INFO] fetching crate sequin-derive 0.1.1... [INFO] checking sequin-derive-0.1.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sequin-derive 0.1.1 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate sequin-derive 0.1.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sequin-derive 0.1.1 [INFO] finished tweaking crates.io crate sequin-derive 0.1.1 [INFO] tweaked toml for crates.io crate sequin-derive 0.1.1 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 53dd894a59c8b30ecb5b636fb12496756cbb98f929bfde5e04c39c5cb23b1308 [INFO] running `Command { std: "docker" "start" "-a" "53dd894a59c8b30ecb5b636fb12496756cbb98f929bfde5e04c39c5cb23b1308", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "53dd894a59c8b30ecb5b636fb12496756cbb98f929bfde5e04c39c5cb23b1308", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "53dd894a59c8b30ecb5b636fb12496756cbb98f929bfde5e04c39c5cb23b1308", kill_on_drop: false }` [INFO] [stdout] 53dd894a59c8b30ecb5b636fb12496756cbb98f929bfde5e04c39c5cb23b1308 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3fdb84dadfffe88f4da16f13f895c3a4b2fd7e8fe84d8c780216026e977f649d [INFO] running `Command { std: "docker" "start" "-a" "3fdb84dadfffe88f4da16f13f895c3a4b2fd7e8fe84d8c780216026e977f649d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling derive_more-impl v1.0.0 [INFO] [stderr] Checking derive_more v1.0.0 [INFO] [stderr] Checking sequin-derive v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn derive_sequential(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let input = parse_macro_input!(input as input::DataInput); [INFO] [stdout] | ----- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | [INFO] [stdout] 13 | let impl_sequential = derive::ImplSequential { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | impl_sequential.into_token_stream().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn impl_sequential_for_tuples_up_to_len(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let input = parse_macro_input!(input as input::TupleInput); [INFO] [stdout] | ----- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | [INFO] [stdout] 27 | / input [INFO] [stdout] 28 | | .tuples [INFO] [stdout] 29 | | .into_iter() [INFO] [stdout] 30 | | .map(|tuple| { [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | .collect::() [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 20 | let derive_input: DeriveInput = input.parse()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let type_info = sequential::TypeInfo::from_data_type(name, data).map_err(|err| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let generics = derive_input.generics; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let ty = parse_quote!( #name #ty_generics ); [INFO] [stdout] | -- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | type_info, [INFO] [stdout] 43 | | ty, [INFO] [stdout] 44 | | generics, [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 56 | let max_len_lit: LitInt = input.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let tuples = (0..=max_len).map(TupleInputTuple::from_len).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(Self { tuples }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn from_named_fields<'a, I>(fields: I) -> (Vec<&'a Ident>, Vec) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | / fields [INFO] [stdout] 176 | | .into_iter() [INFO] [stdout] 177 | | .enumerate() [INFO] [stdout] 178 | | .map(|(index, field)| { [INFO] [stdout] ... | [INFO] [stdout] 184 | | (field_name, sequential_field) [INFO] [stdout] 185 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn from_unnamed_fields<'a, I>(fields: I) -> Vec [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | / fields [INFO] [stdout] 194 | | .into_iter() [INFO] [stdout] 195 | | .enumerate() [INFO] [stdout] 196 | | .map(|(index, field)| FieldInfo::from_field(field, index)) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn from_types<'a, I>(types: I) -> Vec [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | / types [INFO] [stdout] 205 | | .into_iter() [INFO] [stdout] 206 | | .enumerate() [INFO] [stdout] 207 | | .map(|(index, ty)| FieldInfo::from_type(ty, index)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sequin-derive` (lib test) due to 8 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub fn derive_sequential(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 11 | let input = parse_macro_input!(input as input::DataInput); [INFO] [stdout] | ----- --------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 12 | [INFO] [stdout] 13 | let impl_sequential = derive::ImplSequential { [INFO] [stdout] | --------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 20 | impl_sequential.into_token_stream().into() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn impl_sequential_for_tuples_up_to_len(input: TokenStream) -> TokenStream { [INFO] [stdout] | ------------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 25 | let input = parse_macro_input!(input as input::TupleInput); [INFO] [stdout] | ----- ---------------------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 26 | [INFO] [stdout] 27 | / input [INFO] [stdout] 28 | | .tuples [INFO] [stdout] 29 | | .into_iter() [INFO] [stdout] 30 | | .map(|tuple| { [INFO] [stdout] ... | [INFO] [stdout] 39 | | }) [INFO] [stdout] 40 | | .collect::() [INFO] [stdout] | |______________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:41:12 [INFO] [stdout] | [INFO] [stdout] 20 | let derive_input: DeriveInput = input.parse()?; [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 26 | let type_info = sequential::TypeInfo::from_data_type(name, data).map_err(|err| { [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 36 | let generics = derive_input.generics; [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 39 | let ty = parse_quote!( #name #ty_generics ); [INFO] [stdout] | -- ---------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 40 | [INFO] [stdout] 41 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 42 | | type_info, [INFO] [stdout] 43 | | ty, [INFO] [stdout] 44 | | generics, [INFO] [stdout] 45 | | }) [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/input.rs:62:12 [INFO] [stdout] | [INFO] [stdout] 56 | let max_len_lit: LitInt = input.parse()?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 60 | let tuples = (0..=max_len).map(TupleInputTuple::from_len).collect(); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 61 | [INFO] [stdout] 62 | Ok(Self { tuples }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:175:9 [INFO] [stdout] | [INFO] [stdout] 171 | pub fn from_named_fields<'a, I>(fields: I) -> (Vec<&'a Ident>, Vec) [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 175 | / fields [INFO] [stdout] 176 | | .into_iter() [INFO] [stdout] 177 | | .enumerate() [INFO] [stdout] 178 | | .map(|(index, field)| { [INFO] [stdout] ... | [INFO] [stdout] 184 | | (field_name, sequential_field) [INFO] [stdout] 185 | | }) [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:193:9 [INFO] [stdout] | [INFO] [stdout] 189 | pub fn from_unnamed_fields<'a, I>(fields: I) -> Vec [INFO] [stdout] | --------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 193 | / fields [INFO] [stdout] 194 | | .into_iter() [INFO] [stdout] 195 | | .enumerate() [INFO] [stdout] 196 | | .map(|(index, field)| FieldInfo::from_field(field, index)) [INFO] [stdout] | |______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sequential.rs:204:9 [INFO] [stdout] | [INFO] [stdout] 200 | pub fn from_types<'a, I>(types: I) -> Vec [INFO] [stdout] | -------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 204 | / types [INFO] [stdout] 205 | | .into_iter() [INFO] [stdout] 206 | | .enumerate() [INFO] [stdout] 207 | | .map(|(index, ty)| FieldInfo::from_type(ty, index)) [INFO] [stdout] | |_______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sequin-derive` (lib) due to 8 previous errors [INFO] running `Command { std: "docker" "inspect" "3fdb84dadfffe88f4da16f13f895c3a4b2fd7e8fe84d8c780216026e977f649d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3fdb84dadfffe88f4da16f13f895c3a4b2fd7e8fe84d8c780216026e977f649d", kill_on_drop: false }` [INFO] [stdout] 3fdb84dadfffe88f4da16f13f895c3a4b2fd7e8fe84d8c780216026e977f649d