[INFO] fetching crate semalock 0.3.1... [INFO] checking semalock-0.3.1 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate semalock 0.3.1 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate semalock 0.3.1 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate semalock 0.3.1 [INFO] finished tweaking crates.io crate semalock 0.3.1 [INFO] tweaked toml for crates.io crate semalock 0.3.1 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 28 packages to latest compatible versions [INFO] [stderr] Adding errno v0.2.8 (latest: v0.3.9) [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 83b5130cad7827666dd1fb62263bf7d74492392ff06f4412d390184e808235b0 [INFO] running `Command { std: "docker" "start" "-a" "83b5130cad7827666dd1fb62263bf7d74492392ff06f4412d390184e808235b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "83b5130cad7827666dd1fb62263bf7d74492392ff06f4412d390184e808235b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "83b5130cad7827666dd1fb62263bf7d74492392ff06f4412d390184e808235b0", kill_on_drop: false }` [INFO] [stdout] 83b5130cad7827666dd1fb62263bf7d74492392ff06f4412d390184e808235b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 807d8e9a1773616710bf75f8e41f2e98b2feb15efa7dddaa7d734d76056c367f [INFO] running `Command { std: "docker" "start" "-a" "807d8e9a1773616710bf75f8e41f2e98b2feb15efa7dddaa7d734d76056c367f", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking tempfile v3.12.0 [INFO] [stderr] Checking semalock v0.3.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:38:68 [INFO] [stdout] | [INFO] [stdout] 38 | .map_err(|e| format!("OpenOptions::open failed: {}", e.description())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:51:71 [INFO] [stdout] | [INFO] [stdout] 51 | .map_err(|e| format!("CString::new failed: {}", e.description())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:38:68 [INFO] [stdout] | [INFO] [stdout] 38 | .map_err(|e| format!("OpenOptions::open failed: {}", e.description())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/lib.rs:51:71 [INFO] [stdout] | [INFO] [stdout] 51 | .map_err(|e| format!("CString::new failed: {}", e.description())) [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(move |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / CString::new(sem_name) [INFO] [stdout] 51 | | .map_err(|e| format!("CString::new failed: {}", e.description())) [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(move |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |sem_name_cstring| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 53 | | // @TODO move most of this out of unsafe [INFO] [stdout] 54 | | let sem = unsafe { [INFO] [stdout] 55 | | let sem = [INFO] [stdout] ... | [INFO] [stdout] 71 | | }) [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:33 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(move |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |sem_name_cstring| { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | sem.map(|sem| Semalock { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 67 | | fd, [INFO] [stdout] 68 | | file, [INFO] [stdout] 69 | | sem, [INFO] [stdout] 70 | | sem_name_cstring, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn with(&mut self, a: A) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | self.acquire().and_then(|_| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 103 | | let result = a(self); [INFO] [stdout] 104 | | [INFO] [stdout] 105 | | self.release().map(|_| result) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn with(&mut self, a: A) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let result = a(self); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | self.release().map(|_| result) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `semalock` (lib) due to 6 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:50:17 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(move |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 50 | / CString::new(sem_name) [INFO] [stdout] 51 | | .map_err(|e| format!("CString::new failed: {}", e.description())) [INFO] [stdout] | |_____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:52:31 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(move |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |sem_name_cstring| { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 53 | | // @TODO move most of this out of unsafe [INFO] [stdout] 54 | | let sem = unsafe { [INFO] [stdout] 55 | | let sem = [INFO] [stdout] ... | [INFO] [stdout] 71 | | }) [INFO] [stdout] 72 | | }) [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:66:33 [INFO] [stdout] | [INFO] [stdout] 39 | .and_then(move |file| { [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 52 | .and_then(move |sem_name_cstring| { [INFO] [stdout] | ---------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 66 | sem.map(|sem| Semalock { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 67 | | fd, [INFO] [stdout] 68 | | file, [INFO] [stdout] 69 | | sem, [INFO] [stdout] 70 | | sem_name_cstring, [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:102:33 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn with(&mut self, a: A) -> Result [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 102 | self.acquire().and_then(|_| { [INFO] [stdout] | _________________________________^ [INFO] [stdout] 103 | | let result = a(self); [INFO] [stdout] 104 | | [INFO] [stdout] 105 | | self.release().map(|_| result) [INFO] [stdout] 106 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:105:32 [INFO] [stdout] | [INFO] [stdout] 98 | pub fn with(&mut self, a: A) -> Result [INFO] [stdout] | - these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 103 | let result = a(self); [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 104 | [INFO] [stdout] 105 | self.release().map(|_| result) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:297:19 [INFO] [stdout] | [INFO] [stdout] 297 | lock.with(|l| l.file.write_all(b"hello world!").unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lib.rs:304:19 [INFO] [stdout] | [INFO] [stdout] 304 | lock.with(|l| l.file.write_all(b"hello world 2!").unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 7 previous errors; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `semalock` (lib test) due to 8 previous errors; 2 warnings emitted [INFO] running `Command { std: "docker" "inspect" "807d8e9a1773616710bf75f8e41f2e98b2feb15efa7dddaa7d734d76056c367f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "807d8e9a1773616710bf75f8e41f2e98b2feb15efa7dddaa7d734d76056c367f", kill_on_drop: false }` [INFO] [stdout] 807d8e9a1773616710bf75f8e41f2e98b2feb15efa7dddaa7d734d76056c367f