[INFO] fetching crate seeed-lora-e5-at-commands 0.1.0... [INFO] checking seeed-lora-e5-at-commands-0.1.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate seeed-lora-e5-at-commands 0.1.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate seeed-lora-e5-at-commands 0.1.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate seeed-lora-e5-at-commands 0.1.0 [INFO] finished tweaking crates.io crate seeed-lora-e5-at-commands 0.1.0 [INFO] tweaked toml for crates.io crate seeed-lora-e5-at-commands 0.1.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 65 packages to latest compatible versions [INFO] [stderr] Adding atat v0.22.0 (latest: v0.23.0) [INFO] [stderr] Adding atat_derive v0.22.0 (latest: v0.23.0) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding embassy-sync v0.5.0 (latest: v0.6.0) [INFO] [stderr] Adding embedded-hal v0.2.7 (latest: v1.0.0) [INFO] [stderr] Adding hash32 v0.2.1 (latest: v0.3.1) [INFO] [stderr] Adding heapless v0.7.17 (latest: v0.8.0) [INFO] [stderr] Adding heapless-bytes v0.3.0 (latest: v0.4.0) [INFO] [stderr] Adding nb v0.1.3 (latest: v1.1.0) [INFO] [stderr] Adding serde_at v0.22.0 (latest: v0.23.0) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cf21e22d81c6559e385dce81d17aecdaf1a0b8962e3f1df6ce1c67700fb3095a [INFO] running `Command { std: "docker" "start" "-a" "cf21e22d81c6559e385dce81d17aecdaf1a0b8962e3f1df6ce1c67700fb3095a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cf21e22d81c6559e385dce81d17aecdaf1a0b8962e3f1df6ce1c67700fb3095a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf21e22d81c6559e385dce81d17aecdaf1a0b8962e3f1df6ce1c67700fb3095a", kill_on_drop: false }` [INFO] [stdout] cf21e22d81c6559e385dce81d17aecdaf1a0b8962e3f1df6ce1c67700fb3095a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 9211fe3e5c8c467957e96880baf6d0ea8a6bec237278e0418b3b254887d9be0d [INFO] running `Command { std: "docker" "start" "-a" "9211fe3e5c8c467957e96880baf6d0ea8a6bec237278e0418b3b254887d9be0d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling defmt v0.3.8 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling defmt-macros v0.3.9 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Compiling typenum v1.17.0 [INFO] [stderr] Checking futures-task v0.3.30 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking nb v1.1.0 [INFO] [stderr] Compiling embedded-io-async v0.6.1 [INFO] [stderr] Compiling embassy-time-queue-driver v0.1.0 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling litrs v0.4.1 [INFO] [stderr] Compiling heapless v0.7.17 [INFO] [stderr] Compiling embedded-hal-async v1.0.0 [INFO] [stderr] Compiling embassy-time-driver v0.1.0 [INFO] [stderr] Checking nb v0.1.3 [INFO] [stderr] Compiling document-features v0.2.10 [INFO] [stderr] Checking embedded-hal v1.0.0 [INFO] [stderr] Checking critical-section v1.1.3 [INFO] [stderr] Compiling embassy-sync v0.5.0 [INFO] [stderr] Checking void v1.0.2 [INFO] [stderr] Checking embedded-hal v0.2.7 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Checking heapless-bytes v0.3.0 [INFO] [stderr] Checking serde_bytes v0.11.15 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Compiling serde_at v0.22.0 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling atat_derive v0.22.0 [INFO] [stderr] Compiling defmt-parser v0.3.4 [INFO] [stderr] Checking embedded-io v0.6.1 [INFO] [stderr] Checking embassy-time v0.3.2 [INFO] [stderr] Checking atat v0.22.0 [INFO] [stderr] Checking seeed-lora-e5-at-commands v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lora/commands.rs:494:30 [INFO] [stdout] | [INFO] [stdout] 494 | .map(|s| s.try_into().map_err(|_| Error::Parse)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lora/commands.rs:538:12 [INFO] [stdout] | [INFO] [stdout] 534 | let resp = core::str::from_utf8(buf) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | Ok(Self::Response { response: resp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lora/commands.rs:536:22 [INFO] [stdout] | [INFO] [stdout] 536 | .map(|b| b.try_into().map_err(|_| Error::Parse)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn signal(&self, val: T) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | self.state.lock(|cell| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 67 | | let state = cell.replace(State::Signaled(val)); [INFO] [stdout] 68 | | if let State::Waiting(waker) = state { [INFO] [stdout] 69 | | waker.wake(); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:76:41 [INFO] [stdout] | [INFO] [stdout] 76 | self.state.lock(|cell| cell.set(State::None)); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `seeed-lora-e5-at-commands` (lib) due to 6 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lora/commands.rs:494:30 [INFO] [stdout] | [INFO] [stdout] 494 | .map(|s| s.try_into().map_err(|_| Error::Parse)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lora/commands.rs:538:12 [INFO] [stdout] | [INFO] [stdout] 534 | let resp = core::str::from_utf8(buf) [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 538 | Ok(Self::Response { response: resp }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/lora/commands.rs:536:22 [INFO] [stdout] | [INFO] [stdout] 536 | .map(|b| b.try_into().map_err(|_| Error::Parse)) [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:66:25 [INFO] [stdout] | [INFO] [stdout] 65 | pub fn signal(&self, val: T) { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 66 | self.state.lock(|cell| { [INFO] [stdout] | _________________________^ [INFO] [stdout] 67 | | let state = cell.replace(State::Signaled(val)); [INFO] [stdout] 68 | | if let State::Waiting(waker) = state { [INFO] [stdout] 69 | | waker.wake(); [INFO] [stdout] 70 | | } [INFO] [stdout] 71 | | }) [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/signal.rs:76:41 [INFO] [stdout] | [INFO] [stdout] 76 | self.state.lock(|cell| cell.set(State::None)); [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `seeed-lora-e5-at-commands` (lib test) due to 6 previous errors [INFO] running `Command { std: "docker" "inspect" "9211fe3e5c8c467957e96880baf6d0ea8a6bec237278e0418b3b254887d9be0d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9211fe3e5c8c467957e96880baf6d0ea8a6bec237278e0418b3b254887d9be0d", kill_on_drop: false }` [INFO] [stdout] 9211fe3e5c8c467957e96880baf6d0ea8a6bec237278e0418b3b254887d9be0d