[INFO] fetching crate secop-core 0.1.3... [INFO] checking secop-core-0.1.3 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate secop-core 0.1.3 into /workspace/builds/worker-0-tc2/source [INFO] validating manifest of crates.io crate secop-core 0.1.3 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate secop-core 0.1.3 [INFO] finished tweaking crates.io crate secop-core 0.1.3 [INFO] tweaked toml for crates.io crate secop-core 0.1.3 written to /workspace/builds/worker-0-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 116 packages to latest compatible versions [INFO] [stderr] Adding ahash v0.4.8 (latest: v0.8.11) [INFO] [stderr] Adding ahash v0.7.8 (latest: v0.8.11) [INFO] [stderr] Adding base64 v0.13.1 (latest: v0.22.1) [INFO] [stderr] Adding bitflags v1.3.2 (latest: v2.6.0) [INFO] [stderr] Adding darling v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_core v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding darling_macro v0.13.4 (latest: v0.20.10) [INFO] [stderr] Adding derive-new v0.5.9 (latest: v0.7.0) [INFO] [stderr] Adding dns-lookup v1.0.8 (latest: v2.0.4) [INFO] [stderr] Adding hashbrown v0.9.1 (latest: v0.14.5) [INFO] [stderr] Adding hashbrown v0.11.2 (latest: v0.14.5) [INFO] [stderr] Adding hostname v0.3.1 (latest: v0.4.0) [INFO] [stderr] Adding idna v0.5.0 (latest: v1.0.2) [INFO] [stderr] Adding itertools v0.10.5 (latest: v0.13.0) [INFO] [stderr] Adding mlzlog v0.7.0 (latest: v0.8.2) [INFO] [stderr] Adding mlzutil v0.2.2 (latest: v0.3.0) [INFO] [stderr] Adding parking_lot v0.11.2 (latest: v0.12.3) [INFO] [stderr] Adding parking_lot_core v0.8.6 (latest: v0.9.10) [INFO] [stderr] Adding redox_syscall v0.2.16 (latest: v0.5.3) [INFO] [stderr] Adding socket2 v0.4.10 (latest: v0.5.7) [INFO] [stderr] Adding strsim v0.10.0 (latest: v0.11.1) [INFO] [stderr] Adding syn v1.0.109 (latest: v2.0.77) [INFO] [stderr] Adding synstructure v0.12.6 (latest: v0.13.1) [INFO] [stderr] Adding systemstat v0.1.12 (latest: v0.2.3) [INFO] [stderr] Adding time v0.1.45 (latest: v0.3.36) [INFO] [stderr] Adding toml v0.5.11 (latest: v0.8.19) [INFO] [stderr] Adding wasi v0.10.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding wasi v0.11.0+wasi-snapshot-preview1 (latest: v0.13.2+wasi-0.2.1) [INFO] [stderr] Adding windows-core v0.52.0 (latest: v0.58.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] aa66abc4fe46aa6a983d53add61ad83389c264ca40d002b1d0f51a833f029fd1 [INFO] running `Command { std: "docker" "start" "-a" "aa66abc4fe46aa6a983d53add61ad83389c264ca40d002b1d0f51a833f029fd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "aa66abc4fe46aa6a983d53add61ad83389c264ca40d002b1d0f51a833f029fd1", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "aa66abc4fe46aa6a983d53add61ad83389c264ca40d002b1d0f51a833f029fd1", kill_on_drop: false }` [INFO] [stdout] aa66abc4fe46aa6a983d53add61ad83389c264ca40d002b1d0f51a833f029fd1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4f9af6c533e1c2c54c034d0ccfe2fffd5f9ae95c8759b0ef2dc69b91212c452b [INFO] running `Command { std: "docker" "start" "-a" "4f9af6c533e1c2c54c034d0ccfe2fffd5f9ae95c8759b0ef2dc69b91212c452b", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.86 [INFO] [stderr] Compiling libc v0.2.158 [INFO] [stderr] Compiling unicode-ident v1.0.12 [INFO] [stderr] Compiling autocfg v1.3.0 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking cfg-if v1.0.0 [INFO] [stderr] Checking memchr v2.7.4 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling version_check v0.9.5 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Checking tinyvec_macros v0.1.1 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling parking_lot_core v0.8.6 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling thiserror v1.0.63 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Checking once_cell v1.19.0 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking ahash v0.4.8 [INFO] [stderr] Compiling unicode-xid v0.2.5 [INFO] [stderr] Checking percent-encoding v2.3.1 [INFO] [stderr] Checking log-mdc v0.1.0 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking match_cfg v0.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling ahash v0.7.8 [INFO] [stderr] Checking bytesize v1.3.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking arc-swap v1.7.1 [INFO] [stderr] Checking hashbrown v0.9.1 [INFO] [stderr] Checking form_urlencoded v1.2.1 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking base64 v0.13.1 [INFO] [stderr] Checking crossbeam-channel v0.5.13 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Compiling syn v2.0.77 [INFO] [stderr] Checking thread-id v4.2.2 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking time v0.1.45 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Checking hostname v0.3.1 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking dns-lookup v1.0.8 [INFO] [stderr] Checking parking_lot v0.11.2 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking systemstat v0.1.12 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking mlzutil v0.2.2 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Compiling thiserror-impl v1.0.63 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling darling_core v0.13.4 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling derive-new v0.5.9 [INFO] [stderr] Checking log4rs v1.3.0 [INFO] [stderr] Compiling darling_macro v0.13.4 [INFO] [stderr] Checking mlzlog v0.7.0 [INFO] [stderr] Compiling darling v0.13.4 [INFO] [stderr] Compiling secop-derive v0.1.3 [INFO] [stderr] Checking secop-core v0.1.3 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:35 [INFO] [stdout] | [INFO] [stdout] 86 | while let Ok((stream, addr)) = tcp_sock.accept() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let new_req_sender = REQ_SENDER.lock().clone().expect("no server running?"); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (rep_sender, rep_receiver) = unbounded(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | thread::spawn(move || Handler::new(hid, stream, addr, [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 95 | | new_req_sender, rep_sender, rep_receiver).handle()); [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:121:14 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new(modname: impl Into) -> Option { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let con_sender = CON_SENDER.lock().clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let req_sender = REQ_SENDER.lock().clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let (rep_sender, rep_receiver) = unbounded(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | con_sender.send((hid, rep_sender.clone())).unwrap(); [INFO] [stdout] 121 | Some(Self { hid, modname: modname.into(), timeout, req_sender, rep_receiver }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:98:49 [INFO] [stdout] | [INFO] [stdout] 98 | self.parameters.get(param).and_then(|v| td.from_json(v).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secop-core` (lib test) due to 4 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/server.rs:94:35 [INFO] [stdout] | [INFO] [stdout] 86 | while let Ok((stream, addr)) = tcp_sock.accept() { [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 89 | let new_req_sender = REQ_SENDER.lock().clone().expect("no server running?"); [INFO] [stdout] | -------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 90 | let (rep_sender, rep_receiver) = unbounded(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 94 | thread::spawn(move || Handler::new(hid, stream, addr, [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 95 | | new_req_sender, rep_sender, rep_receiver).handle()); [INFO] [stdout] | |________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/client.rs:121:14 [INFO] [stdout] | [INFO] [stdout] 114 | pub fn new(modname: impl Into) -> Option { [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 117 | let con_sender = CON_SENDER.lock().clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 118 | let req_sender = REQ_SENDER.lock().clone()?; [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 119 | let (rep_sender, rep_receiver) = unbounded(); [INFO] [stdout] | ---------- ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 120 | con_sender.send((hid, rep_sender.clone())).unwrap(); [INFO] [stdout] 121 | Some(Self { hid, modname: modname.into(), timeout, req_sender, rep_receiver }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/config.rs:98:49 [INFO] [stdout] | [INFO] [stdout] 98 | self.parameters.get(param).and_then(|v| td.from_json(v).ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secop-core` (lib) due to 4 previous errors [INFO] running `Command { std: "docker" "inspect" "4f9af6c533e1c2c54c034d0ccfe2fffd5f9ae95c8759b0ef2dc69b91212c452b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4f9af6c533e1c2c54c034d0ccfe2fffd5f9ae95c8759b0ef2dc69b91212c452b", kill_on_drop: false }` [INFO] [stdout] 4f9af6c533e1c2c54c034d0ccfe2fffd5f9ae95c8759b0ef2dc69b91212c452b