[INFO] fetching crate secmem-alloc 0.3.0... [INFO] checking secmem-alloc-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate secmem-alloc 0.3.0 into /workspace/builds/worker-4-tc2/source [INFO] validating manifest of crates.io crate secmem-alloc 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate secmem-alloc 0.3.0 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate secmem-alloc 0.3.0 [INFO] tweaked toml for crates.io crate secmem-alloc 0.3.0 written to /workspace/builds/worker-4-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 32 packages to latest compatible versions [INFO] [stderr] Adding linux-raw-sys v0.4.14 (latest: v0.6.5) [INFO] [stderr] Adding windows-sys v0.52.0 (latest: v0.59.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 69f3c26b3ecbb038ad7609cd753bbd2f0eb21cc10fe1b8742b7200209c5d0040 [INFO] running `Command { std: "docker" "start" "-a" "69f3c26b3ecbb038ad7609cd753bbd2f0eb21cc10fe1b8742b7200209c5d0040", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "69f3c26b3ecbb038ad7609cd753bbd2f0eb21cc10fe1b8742b7200209c5d0040", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "69f3c26b3ecbb038ad7609cd753bbd2f0eb21cc10fe1b8742b7200209c5d0040", kill_on_drop: false }` [INFO] [stdout] 69f3c26b3ecbb038ad7609cd753bbd2f0eb21cc10fe1b8742b7200209c5d0040 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4c88996ad112007cf089be36c745ae4a85a598f0f1bc718cd9cb72d683cc9793 [INFO] running `Command { std: "docker" "start" "-a" "4c88996ad112007cf089be36c745ae4a85a598f0f1bc718cd9cb72d683cc9793", kill_on_drop: false }` [INFO] [stderr] Compiling rustix v0.38.35 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking sptr v0.3.2 [INFO] [stderr] Checking mirai-annotations v1.12.0 [INFO] [stderr] Checking secmem-alloc v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: method `page_ptr_nonnull` is never used [INFO] [stdout] --> src/internals/mem.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Page { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] 20 | /// Get [`NonNull`] pointer to the page. [INFO] [stdout] 21 | pub fn page_ptr_nonnull(&self) -> NonNull { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `zeroize_mem` is never used [INFO] [stdout] --> src/zeroize/mod.rs:101:19 [INFO] [stdout] | [INFO] [stdout] 101 | pub unsafe fn zeroize_mem(mut ptr: *mut u8, len: usize) { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sec_alloc.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 175 | let page = mem::Page::alloc_new_lock()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | //let stack_ptr = page.page_ptr_nonnull(); [INFO] [stdout] 177 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | bytes: Cell::new(0), [INFO] [stdout] 179 | | page, [INFO] [stdout] 180 | | //stack_ptr, [INFO] [stdout] 181 | | stack_offset: Cell::new(0), [INFO] [stdout] 182 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 2 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secmem-alloc` (lib) due to 2 previous errors; 2 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: method `page_ptr_nonnull` is never used [INFO] [stdout] --> src/internals/mem.rs:21:12 [INFO] [stdout] | [INFO] [stdout] 19 | impl Page { [INFO] [stdout] | --------- method in this implementation [INFO] [stdout] 20 | /// Get [`NonNull`] pointer to the page. [INFO] [stdout] 21 | pub fn page_ptr_nonnull(&self) -> NonNull { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/sec_alloc.rs:177:12 [INFO] [stdout] | [INFO] [stdout] 175 | let page = mem::Page::alloc_new_lock()?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 176 | //let stack_ptr = page.page_ptr_nonnull(); [INFO] [stdout] 177 | Ok(Self { [INFO] [stdout] | ____________^ [INFO] [stdout] 178 | | bytes: Cell::new(0), [INFO] [stdout] 179 | | page, [INFO] [stdout] 180 | | //stack_ptr, [INFO] [stdout] 181 | | stack_offset: Cell::new(0), [INFO] [stdout] 182 | | }) [INFO] [stdout] | | ^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | |_________| [INFO] [stdout] | [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error; 1 warning emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `secmem-alloc` (lib test) due to 2 previous errors; 1 warning emitted [INFO] running `Command { std: "docker" "inspect" "4c88996ad112007cf089be36c745ae4a85a598f0f1bc718cd9cb72d683cc9793", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4c88996ad112007cf089be36c745ae4a85a598f0f1bc718cd9cb72d683cc9793", kill_on_drop: false }` [INFO] [stdout] 4c88996ad112007cf089be36c745ae4a85a598f0f1bc718cd9cb72d683cc9793