[INFO] fetching crate sea-canal 0.3.0... [INFO] checking sea-canal-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sea-canal 0.3.0 into /workspace/builds/worker-6-tc2/source [INFO] validating manifest of crates.io crate sea-canal 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sea-canal 0.3.0 [INFO] finished tweaking crates.io crate sea-canal 0.3.0 [INFO] tweaked toml for crates.io crate sea-canal 0.3.0 written to /workspace/builds/worker-6-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 311db07d18c3f2998602729f2db390ff9251cb53975c7924dc217d71ead67a28 [INFO] running `Command { std: "docker" "start" "-a" "311db07d18c3f2998602729f2db390ff9251cb53975c7924dc217d71ead67a28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "311db07d18c3f2998602729f2db390ff9251cb53975c7924dc217d71ead67a28", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "311db07d18c3f2998602729f2db390ff9251cb53975c7924dc217d71ead67a28", kill_on_drop: false }` [INFO] [stdout] 311db07d18c3f2998602729f2db390ff9251cb53975c7924dc217d71ead67a28 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e4263fd07d3a781d017d0dcad7972b60c5665ee50c42e8150c6b1d7366aa90a5 [INFO] running `Command { std: "docker" "start" "-a" "e4263fd07d3a781d017d0dcad7972b60c5665ee50c42e8150c6b1d7366aa90a5", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Checking sea-canal v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | try!(write!(fmt, "{}", elem)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | try!(write!(fmt, "{}", elem)); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/pattern.rs:163:17 [INFO] [stdout] | [INFO] [stdout] 163 | try!(write!(fmt, ", ")); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 100 | fn from_iter>(iterator: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Pattern(iterator.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn extend_each(&self, iter: T) -> Vec where T: Iterator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / iter.map(|elem| { [INFO] [stdout] 144 | | let mut v = self.0.clone(); [INFO] [stdout] 145 | | v.push(elem); [INFO] [stdout] 146 | | Pattern::new(v) [INFO] [stdout] 147 | | }).collect() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/choice.rs:62:27 [INFO] [stdout] | [INFO] [stdout] 61 | fn from_iter>(iterator: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | PatternElemChoice(iterator.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sea-canal` (lib test) due to 4 previous errors; 4 warnings emitted [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:68:19 [INFO] [stdout] | [INFO] [stdout] 68 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/pattern.rs:160:19 [INFO] [stdout] | [INFO] [stdout] 160 | fn fmt(&self, mut fmt: &mut Formatter) -> Result<(), Error> { [INFO] [stdout] | ----^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:101:17 [INFO] [stdout] | [INFO] [stdout] 100 | fn from_iter>(iterator: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 101 | Pattern(iterator.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/pattern.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 142 | pub fn extend_each(&self, iter: T) -> Vec where T: Iterator { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 143 | / iter.map(|elem| { [INFO] [stdout] 144 | | let mut v = self.0.clone(); [INFO] [stdout] 145 | | v.push(elem); [INFO] [stdout] 146 | | Pattern::new(v) [INFO] [stdout] 147 | | }).collect() [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/choice.rs:62:27 [INFO] [stdout] | [INFO] [stdout] 61 | fn from_iter>(iterator: I) -> Self { [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 62 | PatternElemChoice(iterator.into_iter().collect()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 3 previous errors; 4 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sea-canal` (lib) due to 4 previous errors; 4 warnings emitted [INFO] running `Command { std: "docker" "inspect" "e4263fd07d3a781d017d0dcad7972b60c5665ee50c42e8150c6b1d7366aa90a5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e4263fd07d3a781d017d0dcad7972b60c5665ee50c42e8150c6b1d7366aa90a5", kill_on_drop: false }` [INFO] [stdout] e4263fd07d3a781d017d0dcad7972b60c5665ee50c42e8150c6b1d7366aa90a5