[INFO] fetching crate sdoc 0.8.11... [INFO] checking sdoc-0.8.11 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sdoc 0.8.11 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate sdoc 0.8.11 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sdoc 0.8.11 [INFO] finished tweaking crates.io crate sdoc 0.8.11 [INFO] tweaked toml for crates.io crate sdoc 0.8.11 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate sdoc 0.8.11 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f99f4f7f8af82952d89ce12e8859b54834e44d498dcc08de138ad5c3b08da470 [INFO] running `Command { std: "docker" "start" "-a" "f99f4f7f8af82952d89ce12e8859b54834e44d498dcc08de138ad5c3b08da470", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f99f4f7f8af82952d89ce12e8859b54834e44d498dcc08de138ad5c3b08da470", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f99f4f7f8af82952d89ce12e8859b54834e44d498dcc08de138ad5c3b08da470", kill_on_drop: false }` [INFO] [stdout] f99f4f7f8af82952d89ce12e8859b54834e44d498dcc08de138ad5c3b08da470 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d28765f36b2251baa531d02e3925679d6c680615ab9e5467cd2a5911d3eecaa5 [INFO] running `Command { std: "docker" "start" "-a" "d28765f36b2251baa531d02e3925679d6c680615ab9e5467cd2a5911d3eecaa5", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while the latest is 2021 [INFO] [stderr] Compiling libc v0.2.103 [INFO] [stderr] Compiling proc-macro2 v1.0.29 [INFO] [stderr] Compiling unicode-xid v0.2.2 [INFO] [stderr] Compiling indexmap v1.7.0 [INFO] [stderr] Compiling syn v1.0.80 [INFO] [stderr] Compiling serde v1.0.130 [INFO] [stderr] Compiling serde_derive v1.0.130 [INFO] [stderr] Checking linked-hash-map v0.5.4 [INFO] [stderr] Compiling memchr v2.4.1 [INFO] [stderr] Checking hashbrown v0.11.2 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking dtoa v0.4.8 [INFO] [stderr] Compiling doc-comment v0.3.3 [INFO] [stderr] Checking predicates-core v1.0.2 [INFO] [stderr] Checking either v1.6.1 [INFO] [stderr] Checking ppv-lite86 v0.2.10 [INFO] [stderr] Checking itertools v0.10.1 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Compiling quote v1.0.10 [INFO] [stderr] Checking termtree v0.2.1 [INFO] [stderr] Checking getrandom v0.2.3 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking rand_core v0.6.3 [INFO] [stderr] Checking predicates-tree v1.0.4 [INFO] [stderr] Checking wait-timeout v0.2.0 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking bstr v0.2.17 [INFO] [stderr] Checking rand v0.8.4 [INFO] [stderr] Checking predicates v2.0.3 [INFO] [stderr] Checking tempfile v3.2.0 [INFO] [stderr] Checking assert_cmd v1.0.8 [INFO] [stderr] Checking serde_yaml v0.8.21 [INFO] [stderr] Checking sdoc v0.8.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/workflow/mod.rs:61:51 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn run_workflow(workflow: Vec, runner: &InstructionRunner) -> Response { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 61 | pub fn run_workflow(workflow: Vec, runner: &dyn InstructionRunner) -> Response { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/workflow/mod.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | fn run(self, runner: &InstructionRunner) -> Response { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | fn run(self, runner: &dyn InstructionRunner) -> Response { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/workflow/mod.rs:61:51 [INFO] [stdout] | [INFO] [stdout] 61 | pub fn run_workflow(workflow: Vec, runner: &InstructionRunner) -> Response { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` on by default [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 61 | pub fn run_workflow(workflow: Vec, runner: &dyn InstructionRunner) -> Response { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/workflow/mod.rs:24:27 [INFO] [stdout] | [INFO] [stdout] 24 | fn run(self, runner: &InstructionRunner) -> Response { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is an object-safe trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | fn run(self, runner: &dyn InstructionRunner) -> Response { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ConfigSource` is never used [INFO] [stdout] --> src/config/mod.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait ConfigSource { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/init.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 115 | .and_then(|mut bin| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | bin.write_all(content.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/init.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 121 | .and_then(|mut y| [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | / serde_yaml::to_string(&default_config()) [INFO] [stdout] 123 | | .map_err(|e| Error::new(ErrorKind::Other, e)) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:125:10 [INFO] [stdout] | [INFO] [stdout] 125 | #[derive(Deserialize, Serialize, Debug, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:137:10 [INFO] [stdout] | [INFO] [stdout] 137 | #[derive(Deserialize, Serialize, Debug, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | fn _run_system_command_with_output(command: &String, stdio: Stdio) -> Response { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | / Command::new("sh") [INFO] [stdout] 14 | | .arg("-c") [INFO] [stdout] 15 | | .arg(command) [INFO] [stdout] 16 | | .stdout(stdio) [INFO] [stdout] ... | [INFO] [stdout] 21 | | .unwrap_or(Response::Err(13)) [INFO] [stdout] 22 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdoc` (lib) due to 6 previous errors; 3 warnings emitted [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] warning: trait `ConfigSource` is never used [INFO] [stdout] --> src/config/mod.rs:10:11 [INFO] [stdout] | [INFO] [stdout] 10 | pub trait ConfigSource { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/init.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 115 | .and_then(|mut bin| { [INFO] [stdout] | ------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 116 | bin.write_all(content.as_bytes()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/commands/init.rs:122:13 [INFO] [stdout] | [INFO] [stdout] 121 | .and_then(|mut y| [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | / serde_yaml::to_string(&default_config()) [INFO] [stdout] 123 | | .map_err(|e| Error::new(ErrorKind::Other, e)) [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:125:10 [INFO] [stdout] | [INFO] [stdout] 125 | #[derive(Deserialize, Serialize, Debug, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/model/mod.rs:137:10 [INFO] [stdout] | [INFO] [stdout] 137 | #[derive(Deserialize, Serialize, Debug, PartialEq)] [INFO] [stdout] | ^^^^^^^^^^^ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: this error originates in the macro `try` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/util/mod.rs:13:5 [INFO] [stdout] | [INFO] [stdout] 12 | fn _run_system_command_with_output(command: &String, stdio: Stdio) -> Response { [INFO] [stdout] | ------------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 13 | / Command::new("sh") [INFO] [stdout] 14 | | .arg("-c") [INFO] [stdout] 15 | | .arg(command) [INFO] [stdout] 16 | | .stdout(stdio) [INFO] [stdout] ... | [INFO] [stdout] 21 | | .unwrap_or(Response::Err(13)) [INFO] [stdout] 22 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 5 previous errors; 3 warnings emitted [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdoc` (lib test) due to 6 previous errors; 3 warnings emitted [INFO] running `Command { std: "docker" "inspect" "d28765f36b2251baa531d02e3925679d6c680615ab9e5467cd2a5911d3eecaa5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d28765f36b2251baa531d02e3925679d6c680615ab9e5467cd2a5911d3eecaa5", kill_on_drop: false }` [INFO] [stdout] d28765f36b2251baa531d02e3925679d6c680615ab9e5467cd2a5911d3eecaa5