[INFO] fetching crate sdf-df-guest 0.5.0... [INFO] checking sdf-df-guest-0.5.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate sdf-df-guest 0.5.0 into /workspace/builds/worker-7-tc2/source [INFO] validating manifest of crates.io crate sdf-df-guest 0.5.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate sdf-df-guest 0.5.0 [INFO] finished tweaking crates.io crate sdf-df-guest 0.5.0 [INFO] tweaked toml for crates.io crate sdf-df-guest 0.5.0 written to /workspace/builds/worker-7-tc2/source/Cargo.toml [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 40 packages to latest compatible versions [INFO] [stderr] Adding wasm-encoder v0.209.1 (latest: v0.216.0) [INFO] [stderr] Adding wasm-metadata v0.209.1 (latest: v0.216.0) [INFO] [stderr] Adding wasmparser v0.209.1 (latest: v0.216.0) [INFO] [stderr] Adding wit-bindgen v0.26.0 (latest: v0.30.0) [INFO] [stderr] Adding wit-bindgen-core v0.26.0 (latest: v0.30.0) [INFO] [stderr] Adding wit-bindgen-rt v0.26.0 (latest: v0.30.0) [INFO] [stderr] Adding wit-bindgen-rust v0.26.0 (latest: v0.30.0) [INFO] [stderr] Adding wit-bindgen-rust-macro v0.26.0 (latest: v0.30.0) [INFO] [stderr] Adding wit-component v0.209.1 (latest: v0.216.0) [INFO] [stderr] Adding wit-parser v0.209.1 (latest: v0.216.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f28b4d627ee0fd1f824227295dba04cf729f4db72daf5a630857a40af2831a31 [INFO] running `Command { std: "docker" "start" "-a" "f28b4d627ee0fd1f824227295dba04cf729f4db72daf5a630857a40af2831a31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f28b4d627ee0fd1f824227295dba04cf729f4db72daf5a630857a40af2831a31", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f28b4d627ee0fd1f824227295dba04cf729f4db72daf5a630857a40af2831a31", kill_on_drop: false }` [INFO] [stdout] f28b4d627ee0fd1f824227295dba04cf729f4db72daf5a630857a40af2831a31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 350267cd19c7d81e457a1f8a7f8cd65c4633869a791b0a7e3e5ee6f5613aeeaa [INFO] running `Command { std: "docker" "start" "-a" "350267cd19c7d81e457a1f8a7f8cd65c4633869a791b0a7e3e5ee6f5613aeeaa", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.209 [INFO] [stderr] Compiling zerocopy v0.7.35 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Compiling once_cell v1.19.0 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling ryu v1.0.18 [INFO] [stderr] Compiling itoa v1.0.11 [INFO] [stderr] Compiling bitflags v2.6.0 [INFO] [stderr] Compiling serde_json v1.0.127 [INFO] [stderr] Compiling leb128 v0.2.5 [INFO] [stderr] Compiling id-arena v2.2.1 [INFO] [stderr] Compiling spdx v0.10.6 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Compiling wit-bindgen-rust v0.26.0 [INFO] [stderr] Compiling wit-bindgen-rt v0.26.0 [INFO] [stderr] Compiling serde_derive v1.0.209 [INFO] [stderr] Compiling wit-bindgen-rust-macro v0.26.0 [INFO] [stderr] Compiling wasm-encoder v0.209.1 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling indexmap v2.5.0 [INFO] [stderr] Compiling wasmparser v0.209.1 [INFO] [stderr] Compiling wit-parser v0.209.1 [INFO] [stderr] Compiling wasm-metadata v0.209.1 [INFO] [stderr] Compiling wit-component v0.209.1 [INFO] [stderr] Compiling wit-bindgen-core v0.26.0 [INFO] [stderr] Checking wit-bindgen v0.26.0 [INFO] [stderr] Checking sdf-df-guest v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 121 | left: impl Into>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | op: impl Into, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | right: impl Into>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | ) -> Expr { [INFO] [stdout] 125 | Expr::Binary(BinaryExp { [INFO] [stdout] | __________________^ [INFO] [stdout] 126 | | left: left.into(), [INFO] [stdout] 127 | | right: right.into(), [INFO] [stdout] 128 | | op: op.into(), [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 302 | pub fn filter(&self, expr: Expr) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let wit_expr = expr.as_wit_operation(); [INFO] [stdout] 304 | let df = self.0.run(&wit_expr).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn sort(&self, columns: impl Into, options: SortOptions) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let df = self.0.sort(&columns.into(), &options).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:315:12 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn select(&self, columns: impl Into) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let df = self.0.select(&columns.into()).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:343:12 [INFO] [stdout] | [INFO] [stdout] 342 | let row = self.0.rows().map_err(map_str)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | Ok(LazyRow { row }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 347 | let df = self.0.sql(query).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdf-df-guest` (lib) due to 7 previous errors [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:125:18 [INFO] [stdout] | [INFO] [stdout] 121 | left: impl Into>, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 122 | op: impl Into, [INFO] [stdout] | -------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 123 | right: impl Into>, [INFO] [stdout] | --------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 124 | ) -> Expr { [INFO] [stdout] 125 | Expr::Binary(BinaryExp { [INFO] [stdout] | __________________^ [INFO] [stdout] 126 | | left: left.into(), [INFO] [stdout] 127 | | right: right.into(), [INFO] [stdout] 128 | | op: op.into(), [INFO] [stdout] 129 | | }) [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:305:12 [INFO] [stdout] | [INFO] [stdout] 302 | pub fn filter(&self, expr: Expr) -> Result { [INFO] [stdout] | ---------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 303 | let wit_expr = expr.as_wit_operation(); [INFO] [stdout] 304 | let df = self.0.run(&wit_expr).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 305 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:310:12 [INFO] [stdout] | [INFO] [stdout] 308 | pub fn sort(&self, columns: impl Into, options: SortOptions) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 309 | let df = self.0.sort(&columns.into(), &options).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 310 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:315:12 [INFO] [stdout] | [INFO] [stdout] 313 | pub fn select(&self, columns: impl Into) -> Result { [INFO] [stdout] | ------------------------------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 314 | let df = self.0.select(&columns.into()).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 315 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:343:12 [INFO] [stdout] | [INFO] [stdout] 342 | let row = self.0.rows().map_err(map_str)?; [INFO] [stdout] | --- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 343 | Ok(LazyRow { row }) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/expr.rs:348:12 [INFO] [stdout] | [INFO] [stdout] 347 | let df = self.0.sql(query).map_err(map_str)?; [INFO] [stdout] | -- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 348 | Ok(Self(df)) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 6 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `sdf-df-guest` (lib test) due to 7 previous errors [INFO] running `Command { std: "docker" "inspect" "350267cd19c7d81e457a1f8a7f8cd65c4633869a791b0a7e3e5ee6f5613aeeaa", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "350267cd19c7d81e457a1f8a7f8cd65c4633869a791b0a7e3e5ee6f5613aeeaa", kill_on_drop: false }` [INFO] [stdout] 350267cd19c7d81e457a1f8a7f8cd65c4633869a791b0a7e3e5ee6f5613aeeaa