[INFO] fetching crate scutiger-bin 0.3.0... [INFO] checking scutiger-bin-0.3.0 against try#4d98531622e1718ae0bc3c7a1ab9cd8938428452+rustflags=-Dtail_expr_drop_order for pr-129604 [INFO] extracting crate scutiger-bin 0.3.0 into /workspace/builds/worker-5-tc2/source [INFO] validating manifest of crates.io crate scutiger-bin 0.3.0 on toolchain 4d98531622e1718ae0bc3c7a1ab9cd8938428452 [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] started tweaking crates.io crate scutiger-bin 0.3.0 [INFO] finished tweaking crates.io crate scutiger-bin 0.3.0 [INFO] tweaked toml for crates.io crate scutiger-bin 0.3.0 written to /workspace/builds/worker-5-tc2/source/Cargo.toml [INFO] crate crates.io crate scutiger-bin 0.3.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while 2018 is compatible with `rust-version` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a165f6056ef22f27b47370d50065e5489a8d5a2ce4d34d8c2bf4497379ac8eb5 [INFO] running `Command { std: "docker" "start" "-a" "a165f6056ef22f27b47370d50065e5489a8d5a2ce4d34d8c2bf4497379ac8eb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a165f6056ef22f27b47370d50065e5489a8d5a2ce4d34d8c2bf4497379ac8eb5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a165f6056ef22f27b47370d50065e5489a8d5a2ce4d34d8c2bf4497379ac8eb5", kill_on_drop: false }` [INFO] [stdout] a165f6056ef22f27b47370d50065e5489a8d5a2ce4d34d8c2bf4497379ac8eb5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc2/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid -Dtail_expr_drop_order" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:923055f121b5182466d55868a8b05e67af8ba4a3a3f6bad814e953ca3cd3ac2a" "/opt/rustwide/cargo-home/bin/cargo" "+4d98531622e1718ae0bc3c7a1ab9cd8938428452" "check" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ce74336bff088616a56ba3f7326ef684ab81d81f6c6c018fae69932cd9652ea8 [INFO] running `Command { std: "docker" "start" "-a" "ce74336bff088616a56ba3f7326ef684ab81d81f6c6c018fae69932cd9652ea8", kill_on_drop: false }` [INFO] [stderr] warning: no edition set: defaulting to the 2015 edition while 2018 is compatible with `rust-version` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling libc v0.2.133 [INFO] [stderr] Compiling pkg-config v0.3.25 [INFO] [stderr] Checking tinyvec_macros v0.1.0 [INFO] [stderr] Compiling log v0.4.17 [INFO] [stderr] Checking unicode-bidi v0.3.8 [INFO] [stderr] Checking percent-encoding v2.2.0 [INFO] [stderr] Checking once_cell v1.15.0 [INFO] [stderr] Checking unicode-width v0.1.10 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking remove_dir_all v0.5.3 [INFO] [stderr] Checking fastrand v1.8.0 [INFO] [stderr] Checking tinyvec v1.6.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking form_urlencoded v1.1.0 [INFO] [stderr] Checking thread_local v1.1.4 [INFO] [stderr] Checking unicode-normalization v0.1.22 [INFO] [stderr] Compiling jobserver v0.1.24 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking tempfile v3.3.0 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling cc v1.0.73 [INFO] [stderr] Checking idna v0.3.0 [INFO] [stderr] Checking url v2.3.1 [INFO] [stderr] Compiling libz-sys v1.1.8 [INFO] [stderr] Compiling pcre2-sys v0.2.5 [INFO] [stderr] Compiling libgit2-sys v0.12.26+1.3.0 [INFO] [stderr] Checking pcre2 v0.2.3 [INFO] [stderr] Checking git2 v0.13.25 [INFO] [stderr] Checking scutiger-core v0.3.0 [INFO] [stderr] Checking scutiger-bin v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/git-at.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 67 | let regex = self.pattern(self.text)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let fixup_regex = self.pattern("\\A\\s*(?:fixup|squash)!")?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let head = self.repo.revparse_single(self.head)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut walker = self.repo.revwalk()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Err(Error::new::(ErrorKind::NoSuchRevision, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/git-at.rs:83:13 [INFO] [stdout] | [INFO] [stdout] 67 | let regex = self.pattern(self.text)?; [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 68 | let fixup_regex = self.pattern("\\A\\s*(?:fixup|squash)!")?; [INFO] [stdout] | ----------- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 69 | let head = self.repo.revparse_single(self.head)?; [INFO] [stdout] | ---- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] 70 | let mut walker = self.repo.revwalk()?; [INFO] [stdout] | ------ these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 83 | Err(Error::new::(ErrorKind::NoSuchRevision, None)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/git-recent-refs.rs:81:57 [INFO] [stdout] | [INFO] [stdout] 81 | iter.map(move |rev| Self::stringify(repo.revparse_ext(&rev).ok())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/pager/mod.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 15 | let pager: Result, _> = Self::find_pager(repo) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Pager { process: pager? }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scutiger-bin` (bin "git-recent-refs") due to 3 previous errors [INFO] [stdout] error: aborting due to 1 previous error [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: could not compile `scutiger-bin` (bin "git-at" test) due to 2 previous errors [INFO] [stderr] error: could not compile `scutiger-bin` (bin "git-at") due to 2 previous errors [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/git-recent-refs.rs:81:57 [INFO] [stdout] | [INFO] [stdout] 81 | iter.map(move |rev| Self::stringify(repo.revparse_ext(&rev).ok())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] = note: requested on the command line with `-D tail-expr-drop-order` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: these values and local bindings have significant drop implementation that will have a different drop order from that of Edition 2021 [INFO] [stdout] --> src/bin/pager/mod.rs:24:12 [INFO] [stdout] | [INFO] [stdout] 15 | let pager: Result, _> = Self::find_pager(repo) [INFO] [stdout] | ----- these values have significant drop implementation and will observe changes in drop order under Edition 2024 [INFO] [stdout] ... [INFO] [stdout] 24 | Ok(Pager { process: pager? }) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this changes meaning in Rust 2024 [INFO] [stdout] = note: for more information, see issue #123739 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] error: aborting due to 2 previous errors [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] error: could not compile `scutiger-bin` (bin "git-recent-refs" test) due to 3 previous errors [INFO] running `Command { std: "docker" "inspect" "ce74336bff088616a56ba3f7326ef684ab81d81f6c6c018fae69932cd9652ea8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce74336bff088616a56ba3f7326ef684ab81d81f6c6c018fae69932cd9652ea8", kill_on_drop: false }` [INFO] [stdout] ce74336bff088616a56ba3f7326ef684ab81d81f6c6c018fae69932cd9652ea8